Merge branch 'main' into RFC30/rust-runtime-impl-serde-on-runtime-types

Author: thomas-k-cameron

.github/workflows/github-pages.yml

@@ -1,5 +1,11 @@
 on:
   workflow_dispatch:
+    inputs:
+      opt-in-to-sparse-registry:
+        description: Enable/disable CARGO_UNSTABLE_SPARSE_REGISTRY (https://blog.rust-lang.org/2022/06/22/sparse-registry-testing.html)
+        required: true
+        type: boolean
+        default: false
   push:
     branches: [main]
     paths:
@@ -24,6 +30,7 @@ jobs:
     - name: Generate docs
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        CARGO_UNSTABLE_SPARSE_REGISTRY: ${{ inputs.opt-in-to-sparse-registry }}
       run: |
         git config --local user.name "AWS SDK Rust Bot"
         git config --local user.email "aws-sdk-rust-primary@amazon.com"

.gitignore

@@ -56,3 +56,6 @@ target/
 
 # tools
 .tool-versions
+
+# python
+__pycache__

CHANGELOG.next.toml

@@ -11,6 +11,18 @@
 # meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"}
 # author = "rcoh"
 
+[[aws-sdk-rust]]
+message = "Implement std::error::Error#source() properly for the service meta Error enum"
+references = ["aws-sdk-rust#784"]
+meta = { "breaking" = false, "tada" = false, "bug" = false }
+author = "abusch"
+
+[[smithy-rs]]
+message = "Implement std::error::Error#source() properly for the service meta Error enum"
+references = ["aws-sdk-rust#784"]
+meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client"}
+author = "abusch"
+
 [[aws-sdk-rust]]
 message = "The outputs for event stream operations (for example, S3's SelectObjectContent) now implement the `Sync` auto-trait."
 references = ["smithy-rs#2496"]
@@ -82,7 +94,7 @@ meta = { "breaking" = false, "tada" = false, "bug" = false }
 author = "parker-timmerman"
 
 [[aws-sdk-rust]]
-message = "Fix but where an incorrect endpoint was produced for WriteGetObjectResponse"
+message = "Fix bug where an incorrect endpoint was produced for `WriteGetObjectResponse`"
 references = ["smithy-rs#781", "aws-sdk-rust#781"]
 meta = { "breaking" = false, "tada" = false, "bug" = true }
 author = "rcoh"
@@ -92,3 +104,43 @@ message = "Update the `std::fmt::Debug` implementation for `aws-sigv4::SigningPa
 references = ["smithy-rs#2562"]
 meta = { "breaking" = false, "tada" = true, "bug" = true }
 author = "Velfi"
+
+[[aws-sdk-rust]]
+message = "`aws_smithy_types::date_time::Format` has been re-exported in SDK crates."
+references = ["smithy-rs#2534"]
+meta = { "breaking" = false, "tada" = false, "bug" = false }
+author = "ysaito1001"
+
+[[smithy-rs]]
+message = "`aws_smithy_types::date_time::Format` has been re-exported in service client crates."
+references = ["smithy-rs#2534"]
+meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client" }
+author = "ysaito1001"
+
+[[smithy-rs]]
+message = "Fix generation of constrained shapes reaching `@sensitive` shapes"
+references = ["smithy-rs#2582", "smithy-rs#2585"]
+meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "server" }
+author = "david-perez"
+
+[[smithy-rs]]
+message = "Fix server code generation bug affecting constrained shapes bound with `@httpPayload`"
+references = ["smithy-rs#2583", "smithy-rs#2584"]
+meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "server" }
+author = "david-perez"
+
+[[aws-sdk-rust]]
+message = """Reduce several instances of credential exposure in the SDK logs:
+- IMDS now suppresses the body of the response from logs
+- `aws-sigv4` marks the `x-amz-session-token` header as sensitive
+- STS & SSO credentials have been manually marked as sensitive which suppresses logging of response bodies for relevant operations
+"""
+author = "rcoh"
+references = ["smithy-rs#2603"]
+meta = { "breaking" = false, "tada" = false, "bug" = false }
+
+[[smithy-rs]]
+message = "Add a sensitive method to `ParseHttpResponse`. When this returns true, logging of the HTTP response body will be suppressed."
+author = "rcoh"
+references = ["smithy-rs#2603"]
+meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client" }

CODEOWNERS

@@ -4,6 +4,7 @@
 /codegen-server-test/                               @awslabs/smithy-rs-server
 /codegen-server/                                    @awslabs/smithy-rs-server
 /rust-runtime/aws-smithy-http-server/               @awslabs/smithy-rs-server
+/examples/                                          @awslabs/smithy-rs-server
 
 # Python Server
 /codegen-server-test/python/                        @awslabs/smithy-rs-python-server @awslabs/smithy-rs-server

aws/rust-runtime/aws-config/Cargo.toml

@@ -49,6 +49,7 @@ zeroize = { version = "1", optional = true }
 [dev-dependencies]
 futures-util = { version = "0.3.16", default-features = false }
 tracing-test = "0.2.1"
+tracing-subscriber = { version = "0.3.16", features = ["fmt", "json"] }
 
 tokio = { version = "1.23.1", features = ["full", "test-util"] }
 

aws/rust-runtime/aws-config/src/default_provider/credentials.rs

@@ -198,8 +198,6 @@ impl Builder {
 
 #[cfg(test)]
 mod test {
-    use tracing_test::traced_test;
-
     use aws_credential_types::provider::ProvideCredentials;
 
     use crate::default_provider::credentials::DefaultCredentialsChain;
@@ -242,7 +240,6 @@ mod test {
             make_test!($name, execute, $provider_config_builder);
         };
         ($name: ident, $func: ident, $provider_config_builder: expr) => {
-            #[traced_test]
             #[tokio::test]
             async fn $name() {
                 crate::test_case::TestEnvironment::from_dir(concat!(
@@ -324,7 +321,6 @@ mod test {
     }
 
     #[tokio::test]
-    #[traced_test]
     #[cfg(feature = "client-hyper")]
     async fn no_providers_configured_err() {
         use crate::provider_config::ProviderConfig;

aws/rust-runtime/aws-config/src/http_credential_provider.rs

@@ -149,6 +149,10 @@ impl ParseStrictResponse for CredentialsResponseParser {
             )),
         }
     }
+
+    fn sensitive(&self) -> bool {
+        true
+    }
 }
 
 #[derive(Clone, Debug)]

aws/rust-runtime/aws-config/src/imds/client.rs

@@ -280,6 +280,10 @@ impl ParseStrictResponse for ImdsGetResponseHandler {
             Err(InnerImdsError::BadStatus)
         }
     }
+
+    fn sensitive(&self) -> bool {
+        true
+    }
 }
 
 /// IMDSv2 Endpoint Mode

aws/rust-runtime/aws-config/src/imds/client/token.rs

@@ -197,4 +197,8 @@ impl ParseStrictResponse for GetTokenResponseHandler {
             expiry: self.time.now() + Duration::from_secs(ttl),
         })
     }
+
+    fn sensitive(&self) -> bool {
+        true
+    }
 }

aws/rust-runtime/aws-config/src/lib.rs

@@ -374,7 +374,7 @@ mod loader {
         ///
         /// # Example: Using a custom profile file path
         ///
-        /// ```
+        /// ```no_run
         /// use aws_config::profile::{ProfileFileCredentialsProvider, ProfileFileRegionProvider};
         /// use aws_config::profile::profile_file::{ProfileFiles, ProfileFileKind};
         ///
@@ -417,7 +417,7 @@ mod loader {
         ///
         /// # Example: Using a custom profile name
         ///
-        /// ```
+        /// ```no_run
         /// use aws_config::profile::{ProfileFileCredentialsProvider, ProfileFileRegionProvider};
         /// use aws_config::profile::profile_file::{ProfileFiles, ProfileFileKind};
         ///