Categorize orchestrator TODO comments into Launch and Cleanup (#2774)

This PR categorizes orchestrator TODO comments into `Launch` and
`Cleanup`:

- `enableNewSmithyRuntimeLaunch`: Comment needs to be addressed before
orchestrator launch
- `enableNewSmithyRuntimeCleanup`: Comment needs to be addressed after
launch when removing middleware

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

Author: jdisanti

.github/workflows/ci.yml

@@ -84,7 +84,7 @@ jobs:
         test:
         - action: check-aws-sdk-adhoc-tests
           runner: ubuntu-latest
-        # TODO(enableNewSmithyRuntime): Remove `check-aws-sdk-orchestrator-impl` when cleaning up middleware
+        # TODO(enableNewSmithyRuntimeCleanup): Remove `check-aws-sdk-orchestrator-impl` when cleaning up middleware
         - action: check-aws-sdk-orchestrator-impl
           runner: smithy_ubuntu-latest_8-core
         - action: check-client-codegen-integration-tests

aws/rust-runtime/aws-config/src/sso.rs

@@ -217,7 +217,7 @@ async fn load_sso_credentials(
         .region(sso_provider_config.region.clone())
         .credentials_cache(CredentialsCache::no_caching())
         .build();
-    // TODO(enableNewSmithyRuntime): Use `customize().config_override()` to set the region instead of creating a new client once middleware is removed
+    // TODO(enableNewSmithyRuntimeCleanup): Use `customize().config_override()` to set the region instead of creating a new client once middleware is removed
     let client = SsoClient::from_conf(config);
     let resp = client
         .get_role_credentials()

aws/rust-runtime/aws-http/src/recursion_detection.rs

@@ -11,7 +11,7 @@ use http::HeaderValue;
 use percent_encoding::{percent_encode, CONTROLS};
 use std::borrow::Cow;
 
-// TODO(enableNewSmithyRuntime): Delete this module
+// TODO(enableNewSmithyRuntimeCleanup): Delete this module
 
 /// Recursion Detection Middleware
 ///

aws/rust-runtime/aws-http/src/user_agent.rs

@@ -513,7 +513,7 @@ impl fmt::Display for ExecEnvMetadata {
     }
 }
 
-// TODO(enableNewSmithyRuntime): Delete the user agent Tower middleware and consider moving all the remaining code into aws-runtime
+// TODO(enableNewSmithyRuntimeCleanup): Delete the user agent Tower middleware and consider moving all the remaining code into aws-runtime
 
 /// User agent middleware
 #[non_exhaustive]

aws/rust-runtime/aws-inlineable/src/glacier_checksums.rs

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-// TODO(enableNewSmithyRuntime): Delete this file when cleaning up middleware
+// TODO(enableNewSmithyRuntimeCleanup): Delete this file when cleaning up middleware
 
 use aws_sig_auth::signer::SignableBody;
 use aws_smithy_http::body::SdkBody;

aws/rust-runtime/aws-runtime/src/request_info.rs

@@ -54,7 +54,6 @@ impl RequestInfoInterceptor {
         &self,
         cfg: &ConfigBag,
     ) -> Option<(Cow<'static, str>, Cow<'static, str>)> {
-        // TODO(enableNewSmithyRuntime) What config will we actually store in the bag? Will it be a whole config or just the max_attempts part?
         if let Some(retry_config) = cfg.get::<RetryConfig>() {
             let max_attempts = retry_config.max_attempts().to_string();
             Some((Cow::Borrowed("max"), Cow::Owned(max_attempts)))

aws/rust-runtime/aws-sig-auth/src/event_stream.rs

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-// TODO(enableNewSmithyRuntime): Remove this blanket allow once the old implementations are deleted
+// TODO(enableNewSmithyRuntimeCleanup): Remove this blanket allow once the old implementations are deleted
 #![allow(deprecated)]
 
 use crate::middleware::Signature;
@@ -123,7 +123,7 @@ mod tests {
     }
 }
 
-// TODO(enableNewSmithyRuntime): Delete this old implementation that was kept around to support patch releases.
+// TODO(enableNewSmithyRuntimeCleanup): Delete this old implementation that was kept around to support patch releases.
 #[deprecated = "use aws_sig_auth::event_stream::SigV4MessageSigner instead (this may require upgrading the smithy-rs code generator)"]
 #[derive(Debug)]
 /// Event Stream SigV4 signing implementation.
@@ -199,7 +199,7 @@ impl SignMessage for SigV4Signer {
     }
 }
 
-// TODO(enableNewSmithyRuntime): Delete this old implementation that was kept around to support patch releases.
+// TODO(enableNewSmithyRuntimeCleanup): Delete this old implementation that was kept around to support patch releases.
 #[cfg(test)]
 mod old_tests {
     use crate::event_stream::SigV4Signer;

aws/rust-runtime/aws-sig-auth/src/middleware.rs

@@ -25,7 +25,7 @@ use crate::event_stream::SigV4MessageSigner as EventStreamSigV4Signer;
 #[cfg(feature = "sign-eventstream")]
 use aws_smithy_eventstream::frame::DeferredSignerSender;
 
-// TODO(enableNewSmithyRuntime): Delete `Signature` when switching to the orchestrator
+// TODO(enableNewSmithyRuntimeCleanup): Delete `Signature` when switching to the orchestrator
 /// Container for the request signature for use in the property bag.
 #[non_exhaustive]
 #[derive(Debug, Clone)]
@@ -151,7 +151,7 @@ fn signing_config(
         request_ts: config
             .get::<SharedTimeSource>()
             .map(|t| t.now())
-            // TODO(enableNewSmithyRuntime): Remove this fallback
+            // TODO(enableNewSmithyRuntimeLaunch): Remove this fallback
             .unwrap_or_else(|| SharedTimeSource::default().now()),
         region,
         payload_override,

aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsCustomizableOperationDecorator.kt

@@ -85,7 +85,7 @@ class CustomizableOperationTestHelpers(runtimeConfig: RuntimeConfig) :
                         *codegenScope,
                     )
                 } else {
-                    // TODO(enableNewSmithyRuntime): Delete this branch when middleware is no longer used
+                    // TODO(enableNewSmithyRuntimeCleanup): Delete this branch when middleware is no longer used
                     rustTemplate(
                         """
                         ##[doc(hidden)]

aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsPresigningDecorator.kt

@@ -140,7 +140,7 @@ class AwsPresigningDecorator internal constructor(
     }
 }
 
-// TODO(enableNewSmithyRuntime): Delete this class when cleaning up middleware
+// TODO(enableNewSmithyRuntimeCleanup): Delete this class when cleaning up middleware
 class AwsInputPresignedMethod(
     private val codegenContext: ClientCodegenContext,
     private val operationShape: OperationShape,