Skip to content

Commit 30c6828

Browse files
authored
Run TODO lint against more files (#2078)
This change would have prevented me from committing what was reverted in #2076
1 parent 3fb9096 commit 30c6828

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

codegen-core/common-test-models/constraints.smithy

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ use smithy.framework#ValidationException
1010
@title("ConstraintsService")
1111
service ConstraintsService {
1212
operations: [
13-
// TODO Rename as {Verb}[{Qualifier}]{Noun}: https://github.com/awslabs/smithy-rs/pull/1342#discussion_r980936650
1413
ConstrainedShapesOperation,
1514
ConstrainedHttpBoundShapesOperation,
1615
ConstrainedRecursiveShapesOperation,
@@ -880,10 +879,8 @@ map LengthMap {
880879

881880
@error("client")
882881
structure ErrorWithLengthStringMessage {
883-
// TODO Doesn't work yet because constrained string types don't implement
884-
// `AsRef<str>`.
885-
// @required
886-
// message: LengthString
882+
@required
883+
message: LengthString
887884
}
888885

889886
map MapOfMapOfListOfListOfConB {

tools/sdk-lints/src/todos.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ impl Lint for TodosHaveContext {
2323
extension
2424
.map(|ext| {
2525
ext.eq_ignore_ascii_case("rs")
26+
|| ext.eq_ignore_ascii_case("toml")
27+
|| ext.eq_ignore_ascii_case("txt")
28+
// TODO(https://github.com/awslabs/smithy-rs/issues/2077)
29+
// || ext.eq_ignore_ascii_case("md")
30+
|| ext.eq_ignore_ascii_case("sh")
31+
|| ext.eq_ignore_ascii_case("py")
32+
|| ext.eq_ignore_ascii_case("smithy")
2633
|| ext.eq_ignore_ascii_case("kt")
2734
|| ext.eq_ignore_ascii_case("kts")
2835
})

0 commit comments

Comments
 (0)