In OkHttpEngine builder add executorService field.

[szymonsasin-nordic]

Describe the feature

In OkHttpEngine builder give an option to pass own executorService.

Is your feature request related to a problem?

Reusing executorservice should help conserve system resources by avoiding the creation of multiple thread pools. Especially when application is using multiple components that uses threadpools.

Proposed Solution

val commonThreadPool = Executors.newFixedThreadPool(4)
...
OkHttpEngine {
    executorService = commonThreadPool
}

Describe alternative solutions or features you've considered

Another option would be to pass whole Dispatcher instance.

Acknowledge

• I may be able to implement this feature request

Smithy-Kotlin version

1.4.11

Platform (JVM/JS/Native)

JVM

Operating system and version

NA

[ianbotsf]

Hi @szymonsasin-nordic, thanks for your feature request. Are you currently experiencing specific issues with thread pools related to OkHttp and/or the AWS SDK?

[szymonsasin-nordic]

Hi, not a major issue, but it would be great to be able to share thread pool. Same as it is with java aws sdk.

[ianbotsf]

Understood, thanks. We likely won't prioritize this right away because we'll want to expose more options at the same time which will require some additional design considerations. I'll leave this open for tracking and for others to 👍.

If this becomes a critical need for you in the meantime, please note that HttpClientEngine is an open interface and you could wrap your own OkHttp instances if you wish.