-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
// 0. Pattern
// Duplicated lines in branches, e.g. in if/else statements
// 1. Pattern
// Factoring out common code in branches, sometimes inverting if statements
// 1. Input
if (data.metrics) {
data.metrics.categories = _.getOr(0, 'length', data.categories)
} else {
data.metrics = user.organization.metrics
data.metrics.categories = _.getOr(0, 'length', data.categories)
}
// 1. Output
if (!data.metrics)
data.metrics = user.organization.metrics
data.metrics.categories = _.getOr(0, 'length', data.categories)
// 2. Pattern
// Collapsing if assignments to `||` assignments
// 2. Input
if (!data.metrics)
data.metrics = user.organization.metrics
// 2. Output
data.metrics = data.metrics || user.organization.metrics
data.metrics.categories = _.getOr(0, 'length', data.categories)
Metadata
Metadata
Assignees
Labels
No labels