fix: fixes a bug in Eq implementation for SVC and SVR

Volodymyr Orlov · Volodymyr Orlov · commit a9446c00c2c9 · 2020-10-31T14:43:52.000-07:00
diff --git a/src/svm/svc.rs b/src/svm/svc.rs
@@ -247,7 +247,7 @@ impl<T: RealNumber, M: Matrix<T>, K: Kernel<T, M::RowVector>> SVC<T, M, K> {
 
 impl<T: RealNumber, M: Matrix<T>, K: Kernel<T, M::RowVector>> PartialEq for SVC<T, M, K> {
     fn eq(&self, other: &Self) -> bool {
-        if self.b != other.b
+        if (self.b - other.b).abs() > T::epsilon() * T::two()
             || self.w.len() != other.w.len()
             || self.instances.len() != other.instances.len()
         {
diff --git a/src/svm/svr.rs b/src/svm/svr.rs
@@ -204,7 +204,7 @@ impl<T: RealNumber, M: Matrix<T>, K: Kernel<T, M::RowVector>> SVR<T, M, K> {
 
 impl<T: RealNumber, M: Matrix<T>, K: Kernel<T, M::RowVector>> PartialEq for SVR<T, M, K> {
     fn eq(&self, other: &Self) -> bool {
-        if self.b != other.b
+        if (self.b - other.b).abs() > T::epsilon() * T::two()
             || self.w.len() != other.w.len()
             || self.instances.len() != other.instances.len()
         {

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ impl<T: RealNumber, M: Matrix<T>, K: Kernel<T, M::RowVector>> SVC<T, M, K> {`
`247`	`247`
`248`	`248`	`impl<T: RealNumber, M: Matrix<T>, K: Kernel<T, M::RowVector>> PartialEq for SVC<T, M, K> {`
`249`	`249`	`fn eq(&self, other: &Self) -> bool {`
`250`		`- if self.b != other.b`
	`250`	`+ if (self.b - other.b).abs() > T::epsilon() * T::two()`
`251`	`251`	`\|\| self.w.len() != other.w.len()`
`252`	`252`	`\|\| self.instances.len() != other.instances.len()`
`253`	`253`	`{`
Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ impl<T: RealNumber, M: Matrix<T>, K: Kernel<T, M::RowVector>> SVR<T, M, K> {`
`204`	`204`
`205`	`205`	`impl<T: RealNumber, M: Matrix<T>, K: Kernel<T, M::RowVector>> PartialEq for SVR<T, M, K> {`
`206`	`206`	`fn eq(&self, other: &Self) -> bool {`
`207`		`- if self.b != other.b`
	`207`	`+ if (self.b - other.b).abs() > T::epsilon() * T::two()`
`208`	`208`	`\|\| self.w.len() != other.w.len()`
`209`	`209`	`\|\| self.instances.len() != other.instances.len()`
`210`	`210`	`{`