Lesson 9 - Having an issue with winnerStartingBalance

[DaurenNox]

Hey guys have an error : ReferenceError: Cannot access 'winnerStartingBalance' before initialization

I have checked the repositories, discussion, subscriptionsID's etc.

Would love if you guys can help.

Thank you.

Checked VRF, Upkeep and Entering raffle.

All seems to be working.

If not that error I get : Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/dauren/hardhat-smartcontract-lottery-fcc/test/staging/Raffle.staging.test.js)

Here is my staging test:

const { assert, expect } = require("chai")
const { getNamedAccounts, deployments, ethers, network } = require("hardhat")
const { developmentChains, networkConfig } = require("../../helper-hardhat-config")

developmentChains.includes(network.name)
    ? describe.skip
    : describe("Raffle Staging Tests", function () {
          let raffle, raffleEntranceFee, deployer

          beforeEach(async function () {
              deployer = (await getNamedAccounts()).deployer
              raffle = await ethers.getContract("Raffle", deployer)
              raffleEntranceFee = await raffle.getEntranceFee()
          })

          describe("fulfillRandomWords", function () {
              it("works with live Chainlink Keepers and Chainlink VRF, we get a random winner", async function () {
                  // enter the raffle
                  console.log("Setting up test...")
                  const startingTimeStamp = await raffle.getLatestTimeStamp()
                  const accounts = await ethers.getSigners()

                  console.log("Setting up Listener...")
                  await new Promise(async (resolve, reject) => {
                      // setup listener before we enter the raffle
                      // Just in case the blockchain moves REALLY fast
                      raffle.once("WinnerPicked", async () => {
                          console.log("WinnerPicked event fired!")
                          try {
                              // add our asserts here
                              const recentWinner = await raffle.getRecentWinner()
                              const raffleState = await raffle.getRaffleState()
                              const winnerEndingBalance = await accounts[0].getBalance()
                              const endingTimeStamp = await raffle.getLatestTimeStamp()

                              await expect(raffle.getPlayer(0)).to.be.reverted
                              assert.equal(recentWinner.toString(), accounts[0].address)
                              assert.equal(raffleState, 0)
                              assert.equal(
                                  winnerEndingBalance.toString(),
                                  winnerStartingBalance.add(raffleEntranceFee).toString()
                              )
                              assert(endingTimeStamp > startingTimeStamp)
                              resolve()
                          } catch (error) {
                              console.log(error)
                              reject(error)
                          }
                      })
                      // Then entering the raffle
                      console.log("Entering Raffle...")
                      const tx = await raffle.enterRaffle({ value: raffleEntranceFee })
                      await tx.wait(1)
                      const winnerStartingBalance = await accounts[2].getBalance()
                      console.log("Ok, time to wait...")

                      // and this code WONT complete until our listener has finished listening!
                  })
              })
          })
      })

[DaurenNox]

[WillyEth]

Having the same issue... but Ill come back afterwards, moving on

[jmhickman]

const winnerStartingBalance = await accounts[2].getBalance()
You aren't defining winnerStartingBalance until after you attempt to reference it in

assert.equal(
    winnerEndingBalance.toString(),
    winnerStartingBalance.add(raffleEntranceFee).toString()
)

[DaurenNox]

Have checked codes of other people as well as the original repo, it seems like defining like that works for everyone but me.

I have tried defining it first then referencing it, now I get this: AssertionError: expected '352953851347296051' to equal '353953851347296051'

Thank you!

[alymurtazamemon]

@DaurenNope Change the account to 0 from 2 when getting winnerStartingBalance

[alymurtazamemon]

@DaurenNope Could be please verify the line no 43?

I think this one:

- assert.equal(raffleState, 0)
+ assert.equal(raffleState.toString(), "0")

[DaurenNox]

try {
  // add our asserts here
  const recentWinner = await raffle.getRecentWinner()
  const raffleState = await raffle.getRaffleState()
  const winnerEndingBalance = await accounts[0].getBalance()
  const endingTimeStamp = await raffle.getLatestTimeStamp()

  await expect(raffle.getPlayer(0)).to.be.reverted
  assert.equal(recentWinner.toString(), accounts[0].address)
  assert.equal(raffleState, 0)
    // assert.equal(
    //     winnerEndingBalance.toString(),
    //     winnerStartingBalance.add(raffleEntranceFee).toString()
    // )
//this is line 43  expect(endingTimeStamp).to.be.greaterThan(startingTimeStamp)
  resolve() 

tried changing - assert.equal(raffleState, 0)
+ assert.equal(raffleState.toString(), "0")
Still same error.

[alymurtazamemon]

@DaurenNope If time one is the line 43 then you should check the method name of getLatestTimeStamp , because some have getLastTimeStamp

[DaurenNox]

I do have it as Latest everywhere.

 function getLatestTimeStamp() public view returns (uint256) {
        return s_lastTimeStamp;

from Riffle.sol

[alymurtazamemon]

@DaurenNope There is no any assertion that returns this 1657909794 I am not sure which one is giving that you have to just check that and your test will be passed. And paste the update code again below so I will see that in the morning and will let you know.

[DaurenNox]

Raffle Unit Tests
✔ records players when they enter
✔ emits event on enter
✔ doesnt allow entrance when raffle is calculating (101ms)
constructor
✔ Initializes the raffle correctly
enterRaffle
✔ reverts when you don't pay enough
checkUpkeep
✔ returns false if people haven't sent any ETH
✔ returns false if raffle isn't open (68ms)
✔ returns false if enough time hasn't passed
✔ returns true if enough time has passed, has players, eth, and is open
performUpkeep
✔ can only run if checkupkeep is true (49ms)
✔ reverts when checkupkeep is false
✔ updates the raffle state, emits and event and calls the vrf coordinator (65ms)
fulfillRandomWords
✔ can only be called after perfromUpkeep
Found the event!
0x70997970C51812dc3A010C7d01b50e0d17dc79C8
✔ picks a winner, resets the lottery, and sends money (4105ms)

14 passing (6s)

This is what I get running test on hardhat.

The problem is running it on rinkeby.

You know what I have just noticed that the contract doesn't do upkeep anymore.

this is the address of the contract: 0x82C26402AAA022e1c9D9cc964a305EAD5F0E5682

I have tried to copy pretty much everything from the repo but still get the same error.

[loclaidinh]

I got the same issue:

  1) Staging Tests
       fulfillRandomWords
         work with live ChainLink keeper and VRF, get a random winner:
     ReferenceError: Cannot access 'winnerStartingBalance' before initialization
      at FragmentRunningEvent.<anonymous> (test/staging/Lottery.staging.test.js:34:35)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

[Cheng2046]

this is not a perfect solution, but I at least got the test working on rinkeby:
I use the setTimeout JS function to delay the try catch for 15 seconds
waiting for someone to offer a better solution!

const { assert, expect } = require("chai");
const { network, deployments, ethers, getNamedAccounts } = require("hardhat");
const { developmentChains, networkConfig } = require("../../helper-hardhat-config");

//!only run when we're on a testnet

developmentChains.includes(network.name) //network.name = hardhat, localhost
  ? describe.skip
  : describe("Raffle Staging Tests", function () {
      let raffle, raffleEntranceFee, deployer, accounts;
      // it come from the hre object lol
      beforeEach(async function () {
        accounts = await ethers.getSigners();
        deployer = accounts[0];
        raffle = await ethers.getContract("Raffle", deployer);
        raffleEntranceFee = await raffle.getEntranceFee();
      });
      describe("fulfillRandomWords", () => {
        it("works with live Chainlink Keepers and Chainlink VRF, we get a random winner", async () => {
          console.log("Setting up test...");
          const startingTimeStamp = await raffle.getLastestTimeStamp();

          await new Promise(async (resolve, reject) => {
            raffle.once("WinnerPicked", async () => {
              console.log("WinnerPicked event fired!");

              try {
                setTimeout(async () => {       

          

                  const recentWinner = await raffle.getRecentWinner();
                  const raffleState = await raffle.getRaffleState();
                  const winnerEndingBalance = await accounts[0].getBalance();
                  const endingTimeStamp = await raffle.getLastestTimeStamp();
                  const numPlayers = await raffle.getNumberOfPlayers();

                  // await expect(raffle.getPlayer(0)).to.be.reverted;
                  assert.equal(numPlayers.toString(), "0");
                  assert.equal(recentWinner.toString(), accounts[0].address);
                  assert.equal(raffleState.toString(), "0");
                  assert.equal(
                    winnerEndingBalance.toString(),
                    winnerStartingBalance.add(raffleEntranceFee).toString()
                  );
                  assert.equal(endingTimeStamp > startingTimeStamp, true);
                  resolve();
                }, 15000);

                // add our assert here
              } catch (e) {
                reject(e);
              }
            });

            console.log("Entering Raffle...");

            const tx = await raffle.enterRaffle({ value: raffleEntranceFee });
            await tx.wait(1);
            console.log("Ok, time to wait...");
            const winnerStartingBalance = await accounts[0].getBalance();
            //! this code will not complete until our listener has finished listening!
          });
        });
      });
    });

[ggonzalez94]

Hi everyone! Im getting the same error on some runnings of the test. My take is that since the contract is already deployed and the Chainlink Keeper is checking if enough time has passed the moment it sees there's a player on the raffle it kicks and thats why you get the event before been able to capture the starting balance(and hence it is not initialized on the asserts).
I dont know if this may be the issue or Im just wrong about it.
Thats why the timeout makes it work, because it gives your code enough time before running the assert

[DaurenNox]

That's a good noticing.

I have noticed that as well but upKeep on ChainLink works only once and if your code doesn't work the first time, the upkeep stops.

[ggonzalez94]

I mean its calling checkUpkeep constantly(which is desired), and since enough time has passed the moment you enter the raffle all conditions are met, so performUpkeep is called. That in turn might cause the event to trigger before you wait for enterRaffle transaction to be mined and the startingBalance to be initialized.
Maybe its a long shot, but its the only thing I could think of, since the test sometimes succeeds and others fails, at least for me.

[yersel500]

this is not a perfect solution, but I at least got the test working on rinkeby: I use the setTimeout JS function to delay the try catch for 15 seconds waiting for someone to offer a better solution!

const { assert, expect } = require("chai");
const { network, deployments, ethers, getNamedAccounts } = require("hardhat");
const { developmentChains, networkConfig } = require("../../helper-hardhat-config");

//!only run when we're on a testnet

developmentChains.includes(network.name) //network.name = hardhat, localhost
  ? describe.skip
  : describe("Raffle Staging Tests", function () {
      let raffle, raffleEntranceFee, deployer, accounts;
      // it come from the hre object lol
      beforeEach(async function () {
        accounts = await ethers.getSigners();
        deployer = accounts[0];
        raffle = await ethers.getContract("Raffle", deployer);
        raffleEntranceFee = await raffle.getEntranceFee();
      });
      describe("fulfillRandomWords", () => {
        it("works with live Chainlink Keepers and Chainlink VRF, we get a random winner", async () => {
          console.log("Setting up test...");
          const startingTimeStamp = await raffle.getLastestTimeStamp();

          await new Promise(async (resolve, reject) => {
            raffle.once("WinnerPicked", async () => {
              console.log("WinnerPicked event fired!");

              try {
                setTimeout(async () => {       

          

                  const recentWinner = await raffle.getRecentWinner();
                  const raffleState = await raffle.getRaffleState();
                  const winnerEndingBalance = await accounts[0].getBalance();
                  const endingTimeStamp = await raffle.getLastestTimeStamp();
                  const numPlayers = await raffle.getNumberOfPlayers();

                  // await expect(raffle.getPlayer(0)).to.be.reverted;
                  assert.equal(numPlayers.toString(), "0");
                  assert.equal(recentWinner.toString(), accounts[0].address);
                  assert.equal(raffleState.toString(), "0");
                  assert.equal(
                    winnerEndingBalance.toString(),
                    winnerStartingBalance.add(raffleEntranceFee).toString()
                  );
                  assert.equal(endingTimeStamp > startingTimeStamp, true);
                  resolve();
                }, 15000);

                // add our assert here
              } catch (e) {
                reject(e);
              }
            });

            console.log("Entering Raffle...");

            const tx = await raffle.enterRaffle({ value: raffleEntranceFee });
            await tx.wait(1);
            console.log("Ok, time to wait...");
            const winnerStartingBalance = await accounts[0].getBalance();
            //! this code will not complete until our listener has finished listening!
          });
        });
      });
    });

This worked for me. Thanks!!