Lesson 7 hardhat fund me staging test withdraw() out of gas

[asserules]

When running my staging test it attempts to withdraw but I can see on rinkeby etherscan that the transaction didn't go through because of warning : Warning! Error encountered during contract execution [out of gas]

https://rinkeby.etherscan.io/address/0x27fd75bf3605ea99e216dfe51440430b0fc54a9b

Should i somehow increase the gas limit in the hardhat network config or is there something else I should do?
All help appreciated :)

[krakxn]

Uhm, on Etherscan the transaction did go through though, not understanding what your problem here is. (if it didn't go through due to gas, then it would be a different issue)

Note: Also, should have a high gas limit for tests

[asserules]

It only has three logged transactions, contract creation, funding with 0.1 eth and an attempted withdrawal that obviously failed since the contract balance is still 0.1, and since it says failed bcuz out of gas on etherscan. Am i wrong?

[krakxn]

Yeah - the problem is so because the contract has to pay gas along with the base amount when transferring back via the withdraw() function; could you send the FundMe contract here?

[asserules]

Staging test:

`const { assert } = require("chai");
const { network, ethers, getNamedAccounts } = require("hardhat");
const { developmentChains } = require("../../helper-hardhat-config");

developmentChains.includes(network.name)
? describe.skip
: describe("FundMe Staging Tests", async function () {
let deployer;
let fundMe;
const sendValue = ethers.utils.parseEther("0.01");
beforeEach(async () => {
deployer = (await getNamedAccounts()).deployer;
fundMe = await ethers.getContract("FundMe", deployer);
});

  it("allows people to fund and withdraw", async function () {
    await fundMe.fund({ value: sendValue });
    await fundMe.withdraw();

    const endingFundMeBalance = await fundMe.provider.getBalance(
      fundMe.address
    );
    console.log(
      endingFundMeBalance.toString() +
        " should equal 0, running assert equal..."
    );
    assert.equal(endingFundMeBalance.toString(), "0");
  });
});

`

[asserules]

`// SPDX-License-Identifier: MIT
// 1. Pragma
pragma solidity ^0.8.0;
// 2. Imports
import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol";
import "./PriceConverter.sol";

// 3. Interfaces, Libraries, Contracts
error FundMe__NotOwner();

contract FundMe {
// Type Declarations
using PriceConverter for uint256;

// State variables
uint256 public constant MINIMUM_USD = 50 * 10**18;
address private immutable i_owner;
address[] private s_funders;
mapping(address => uint256) private s_addressToAmountFunded;
AggregatorV3Interface private s_priceFeed;

// Events (we have none!)

// Modifiers
modifier onlyOwner() {
    // require(msg.sender == i_owner);
    if (msg.sender != i_owner) revert FundMe__NotOwner();
    _;
}

// Functions Order:
//// constructor
//// receive
//// fallback
//// external
//// public
//// internal
//// private
//// view / pure

constructor(address priceFeed) {
    s_priceFeed = AggregatorV3Interface(priceFeed);
    i_owner = msg.sender;
}

/// @notice Funds our contract based on the ETH/USD price
function fund() public payable {
    require(
        msg.value.getConversionRate(s_priceFeed) >= MINIMUM_USD,
        "You need to spend more ETH!"
    );
    // require(PriceConverter.getConversionRate(msg.value) >= MINIMUM_USD, "You need to spend more ETH!");
    s_addressToAmountFunded[msg.sender] += msg.value;
    s_funders.push(msg.sender);
}

function withdraw() public payable onlyOwner {
    for (
        uint256 funderIndex = 0;
        funderIndex < s_funders.length;
        funderIndex++
    ) {
        address funder = s_funders[funderIndex];
        s_addressToAmountFunded[funder] = 0;
    }
    s_funders = new address[](0);
    // Transfer vs call vs Send
    // payable(msg.sender).transfer(address(this).balance);
    (bool success, ) = i_owner.call{value: address(this).balance}("");
    require(success);
}

function cheaperWithdraw() public payable onlyOwner {
    address[] memory funders = s_funders;
    // mappings can't be in memory, sorry!
    for (
        uint256 funderIndex = 0;
        funderIndex < funders.length;
        funderIndex++
    ) {
        address funder = funders[funderIndex];
        s_addressToAmountFunded[funder] = 0;
    }
    s_funders = new address[](0);
    // payable(msg.sender).transfer(address(this).balance);
    (bool success, ) = i_owner.call{value: address(this).balance}("");
    require(success);
}

/** @notice Gets the amount that an address has funded
 *  @param fundingAddress the address of the funder
 *  @return the amount funded
 */
function getAddressToAmountFunded(address fundingAddress)
    public
    view
    returns (uint256)
{
    return s_addressToAmountFunded[fundingAddress];
}

function getVersion() public view returns (uint256) {
    return s_priceFeed.version();
}

function getFunder(uint256 index) public view returns (address) {
    return s_funders[index];
}

function getOwner() public view returns (address) {
    return i_owner;
}

function getPriceFeed() public view returns (AggregatorV3Interface) {
    return s_priceFeed;
}

}
`

[asserules]

I manually increased the gas in the hardnat config and it worked. I then looked at the succsesfull transaction and saw that it used aroud 35 000 gas and the auto setting with gas undefined only supplied around 25 000 gas.