Errors when writing tests

[Benrockiee]

I get this error when writing my test, please how do i fix this?

[Benrockiee]

This is my test write up

const { ethers } = require("hardhat")
const { expect, assert } = require("chai")

describe("EtherWallet", function () {
    let etherWallet
    let etherWalletFactory
    //let etherWallet, etherWalletFactory

    beforeEach(async function () {
        const etherWalletFactory = await ethers.getContractFactory(
            "etherWallet"
        )

        const etherWallet = await etherWalletFactory.deploy()
    })

    it("should start with a deposit", async function () {
        const currentValue = await etherWallet.deposit()

        //assert
        //expect

        assert.equal(currentValue.toString(), expectedValue)
        // expect(currentValue.toString()).to.equal(expectedValue)
    })
    it("Should update when we call getBalance", async function () {
        const expectedValue = 0
        const transactionResponse = await etherWallet.getBalance(expectedValue)
        await transactionResponse.wait(1)

        const currentValue = await etherWallet.deposit()
        assert.equal(currentValue.toString(), expectedValue)
    })
})

[Benrockiee]

And my contract

//SPDX-License-Identifier: MIT
pragma solidity ^0.8.7;

contract etherWallet {
  event Deposit(address from, uint256 amount, uint256 balance);
  event Withdrawal(uint256 amount, uint256 balance);
  event Transfer(address from, address to, uint256 balance);

  address public owner;

  constructor() payable {
    owner = msg.sender;
  }

  function deposit() public payable {
    emit Deposit(msg.sender, msg.value, address(this).balance);
  }

  modifier onlyOwner() {
    require(msg.sender == owner, "Not owner");
    _;
  }

  bool internal locked;
  modifier reentrancyGuard() {
    require(!locked, "Non reentrant");
    locked = true;
    _;
    locked = false;
  }

  function withdraw() public payable onlyOwner reentrancyGuard {
    uint256 amount = address(this).balance;
    (bool success, ) = owner.call{value: amount}(" ");
    require(success, "ETHER TRANSACTION FAILED!");
    emit Withdrawal(amount, address(this).balance);
  }

  function transfer(address to) public payable onlyOwner {
    (bool success, ) = to.call{value: msg.value}(" ");
    require(success, "ETHER TRANSACTION FAILED");
    emit Transfer(msg.sender, to, address(this).balance);
  }

  function getBalance() public view returns (uint256) {
    return address(this).balance;
  }
}

[krakxn]

Obvious errors, I have explained how you can fix them below:

First error: You are incorrectly incorporating logic: rather, you should rather use .to.emit by chai and use similar logic which you are employing in the contract - as it cannot read a Solidity event in a JS variable.

Second error: You are incorrectly using here too. .getBalance(<address>) should be used in this way here with an address as a parameter, not an integer type.

Good luck with the course! (And read more documentations - to correctly implement functions provided to us)

[Benrockiee]

@krakxn I don't understand bro..
Maybe u should write out a bit of this test to be more clear so I can fix it in..
The errors keep showing

[krakxn]

In very simple terms for beginners:

First error: Use to.emit() function for tests (import chai to use it)

Second error: The problem here is that .getBalance() function should have an address inside it, not a number.

[Benrockiee]

It still give errors bro,

const { ethers } = require("hardhat")
const { expect, assert } = require("chai")

describe("EtherWallet", function () {
    let etherWallet
    let etherWalletFactory
    //let etherWallet, etherWalletFactory

    beforeEach(async function () {
        const etherWalletFactory = await ethers.getContractFactory(
            "etherWallet"
        )

        etherWallet = await etherWalletFactory.deploy()
    })

    it("should start with a deposit", async function () {
        const currentValue = await etherWallet.deposit()
        const expectedValue = 0

        //assert
        //expect

        assert.equal(currentValue.toString(), expectedValue)
        // expect(currentValue.toString()).to.equal(expectedValue)
    })
    it("Should update when we call getBalance", async function () {
        const expectedValue = 10
        const transactionResponse = await etherWallet.getBalance(
            0xd9145cce52d386f254917e481eb44e9943f39138
        )
        await transactionResponse.wait(1)

        const currentValue = await etherWallet.getBalance()
        assert.equal(currentValue.toString(), expectedValue)
    })
})

[krakxn]

There are logical errors throughout the program, please read more documentations.

First test: You cannot store event emits (in currentValue) - think of them as a console.log and indexer for blockchains
Also, when you solve the above logical error of your custom project there is one more issue, both should be of the same type: assert.equal(currentValue.toString(), expectedValue.toString())

then, the last test: assert.equal(currentValue.toString(), expectedValue) will never work - expectedValue is a number.

[Benrockiee]

@krakxn Okay thanks

[harendra-shakya]

You are not saving it to global variables that's why it's showing undefined, remove const from const etherWallet = await etherWalletFactory.deploy() in beforeEach.

[Benrockiee]

@harendra-shakya Thanks, this worked.. Just remaining the second error