Cannot test addition of object to an array of struct

[umair-mirza]

I am trying to test addition of an object to an array of struct like so:

describe("Create Horse", async function() {
        it("horses struct array initialized with 0 horses", async function() {
            expect(await stallionRace.horses.length).to.equal(0)
        })
        it.only("creates a horse and adds it to the struct array", async function() {
            await stallionRace.createHorse("pony", 1, 1000000000)
            expect(stallionRace.horses.length).to.be.greaterThan(0)
        })
    })

The function in the contract file looks like this:

function createHorse(string memory _name, uint8 _level, uint256 _price) public onlyOwner {
        if(horses.length > 0) {
            require(keccak256(bytes(horses[horses.length - 1].name)) != keccak256(bytes(_name)), "Another horse with this name already exists");
        }
        s_horseId = s_horseId + 1;
        horses.push(Horse(s_horseId, _price, _level, _name));

        emit HorseCreated(s_horseId, _price, _level, _name);
    }

I am getting this error while testing with Chai:

AssertionError: expected +0 to be above +0

What could be the issue? I know that the function has an 'onlyOwner' modifier but do I need to call from it?

[krakxn]

I have listed two snippets from docs to help you with your project, as greaterThan is strictly greater than the target, or >. Here:

.most(n[, msg])
@param { Number } n
@param { String } msg optional
Asserts that the target is a number or a date less than or equal to the given number or date n respectively. However, it’s often best to assert that the target is equal to its expected value.

expect(1).to.equal(1); // Recommended
expect(1).to.be.at.most(2); // Not recommended
expect(1).to.be.at.most(1); // Not recommended

.within(start, finish[, msg])
@param { Number } start lower bound inclusive
@param { Number } finish upper bound inclusive
@param { String } msg optional
Asserts that the target is a number or a date greater than or equal to the given number or date start, and less than or equal to the given number or date finish respectively. However, it’s often best to assert that the target is equal to its expected value.

expect(2).to.equal(2); // Recommended
expect(2).to.be.within(1, 3); // Not recommended
expect(2).to.be.within(2, 3); // Not recommended
expect(2).to.be.within(1, 2); // Not recommended

Hope this helps!

[umair-mirza]

But the problem is that it is not adding horse to the struct array. So the length will always be 0.

[krakxn]

But the problem is that it is not adding horse to the struct array. So the length will always be 0.

Could the problem be incrementing s_horseId before pushing it to the array?

s_horseId = s_horseId + 1;
        horses.push(Horse(s_horseId, _price, _level, _name));

[umair-mirza]

tried that..still not working.

[krakxn]

I see - could you paste the code for the complete program? Thanks. (the contract and any scripts involved)

[alymurtazamemon]

@umair-mirza I think you should wait for a 1 block confirmation because you are storing.

const transactionResponse = await stallionRace.createHorse("pony", 1, 1000000000);
await transactionResponse.wait(1);

[umair-mirza]

I tried that as well.. didn't work.

[alymurtazamemon]

@umair-mirza You can try the other approach and test it out, like getting the item on index zero and checking whether it is the same or not.

[mattjaf]

console.log it and see whats going on

[umair-mirza]

Yes, it fixes the Void error.

[mattjaf]

is it still failing and returning length 0 in your console?

maybe try in your before each:
instead of getContract

 const stallionRaceFactory = await ethers.getContractFactory('StallionRace', deployer); //or whatever your contract name is 
this.stallionRace = await stallionRaceFactory.deploy(/*input parameters*/);

then in your test:

const result = await this.stallionRace.connect(deployer).createHorse("pony", 1, 1000000000)

[umair-mirza]

This test passes:

describe("Constructor", async function() {
        it("initializes the race correctly", async function() {
            const raceState = await stallionRace.getRaceState()
            expect(raceState.toString()).to.equal("0") //raceState.toString() will return a big number
        })
    })

So I suppose, the contract gets deployed correctly?

[mattjaf]

I've been trying to find the documentation for getContract

If your going to use it, you might not have to specify deployer after it? Im not sure, its something I noticed in some of patricks tests.
you could try:

stallionRace = await ethers.getContract("StallionRace")
vrfCoordinatorV2Mock = await ethers.getContract("VRFCoordinatorV2Mock")

[umair-mirza]

It makes no difference at all.