Chapter 9: AssertionError for staging test.

[sanjayojha]

Some how I fix the chainlink keeper/vrf error

But now I am getting Assertion error when testing staging test on rinkeby network.

error

 AssertionError: expected '665488749346019651' to equal '665532933346284755'
      + expected - actual
      +665532933346284755

This is due to staring balance and ending balance is not same.

assert.equal(
    winnerFinalBalance.toString(),
    winnerStartingBalance.add(raffleEntranceFee).toString()
);

^ this is failing.

I am also noticing the below error when Perform Upkeep is running on rinkeby etherscan 0x39f75b9beb0a209f8d4b383395e762757b8e747d4cb5e0e58866f0e38bbe7f2b

Fail with Custom Error 'Raffle__UpkeepNotNeeded (currentBalance=10000000000000000, numPlayers=1, raffleState=1)'

This means performUpkeep method in my Raffle.sol file is reverting with Raffle_UpkeepNotNeeded error.

function performUpkeep(bytes calldata /* performData */) external override {
    (bool upkeepNeeded, ) = checkUpkeep("0x");
   //the below line is getting fired
    if (!upkeepNeeded) {
        revert Raffle__UpkeepNotNeeded(
            address(this).balance,
            s_players.length,
            uint256(s_raffleState)
        );
    }
    s_raffleState = RaffleState.Calculating;
    uint256 requestId = i_vrfCoordinator.requestRandomWords(
        i_gasLane,
        i_subscriptionId,
        REQUEST_CONFIRMATION,
        i_callbackGasLimit,
        NUM_WORDS
    );
    emit RequestRafflewinner(requestId);
}

Look like below checkUpkeep is returning false.

function checkUpkeep( bytes memory /* checkData */ ) public view override returns ( bool upkeepNeeded, bytes memory /* performData */ )
{
    bool isOpen = (RaffleState.Open == s_raffleState);
    bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
    bool hasPlayers = (s_players.length > 0);
    bool hasBalance = (address(this).balance > 0);
    upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);

    return (upkeepNeeded, "0x");
}

But the events are getting fired in my stage test and assertion is running.

Contract address on rinkeby:
0x95f281bf79c0470526c10fb4f75c125b5bfe017d

@PatrickAlphaC

Not sure why assertion is failing and why I am getting reverted error on Perfrom Upkeep method

Below is my Raffle.Staging.test.ts file

import { SignerWithAddress } from "@nomiclabs/hardhat-ethers/signers";
import { assert, expect } from "chai";
import { BigNumber } from "ethers";
import { ethers, network } from "hardhat";
import { developmentChains } from "../../helper-hardhat-config";
import { Raffle } from "../../typechain-types";

//run onlu on test/main net
developmentChains.includes(network.name)
    ? describe.skip
    : describe("Raffle Staging Test", function () {
          let player: SignerWithAddress;
          let deployer: SignerWithAddress;
          let raffle: Raffle;
          let raffleEntranceFee: BigNumber;
          beforeEach(async () => {
              const accounts = await ethers.getSigners();
              deployer = accounts[0];
              player = accounts[1];
              raffle = await ethers.getContract("Raffle", deployer); 
              raffleEntranceFee = await raffle.getEnteranceFee();
          });
          describe("fulfillRandomWords", function () {
              it("works with live Chainlink Keepers and Chainlink VRF, we get a random winner", async () => {
                  
                  console.log("Setting up test...");
                  const startingTimeStamp = await raffle.getLastTimeStamp();

                  console.log("Setting up Listener...");
                  await new Promise<void>(async (resolve, reject) => {
                      // setup listener before we enter the raffle. Just in case the blockchain moves REALLY fast
                      
                      raffle.once("WinnerPicked", async () => {
                          console.log("WinnerPicked event fired!");
                          try {
                              // get data after the winner is picked and event is fired.
                              const recentWinner = await raffle.getRecentWinner();
                              const raffleState = await raffle.getRaffleState();
                              const endingTimeStamp = await raffle.getLastTimeStamp();
                              const winnerFinalBalance = await deployer.getBalance(); //here account[0]/deployer is the only entrant also. So he is the winner.
                              //start assertation
                              assert.equal(raffleState, 0);
                              assert.equal(recentWinner.toString(), deployer.address);
                              assert(endingTimeStamp > startingTimeStamp);
                              await expect(raffle.getPlayer(0)).to.be.reverted;
                              assert.equal(
                                  winnerFinalBalance.toString(),
                                  winnerStartingBalance.add(raffleEntranceFee).toString()
                              );
                              resolve();
                          } catch (e) {
                              console.log(e);
                              reject(e);
                          }
                      });

                      
                    console.log("Entering Raffle...");
                    const tx = await raffle.enterRaffle({ value: raffleEntranceFee });
                    await tx.wait(1);
                    const winnerStartingBalance = await deployer.getBalance(); //here account[0]/deployer is the only entrant also. So he is the winner
                    await raffle.performUpkeep("0x"); //this is my fix to run keeper on testnet         
                      // And this code Wont compelte untill our listener (above) has finished listening.
                      console.log("Ok, time to wait...");
                  });
              });
          });
      });

[PatrickAlphaC]

I wouldn't let some of the staging stuff bog you down... but looking at it I can't really tell what's wrong without digging into it... I think I'd just skip it for now. I think you basically got it, and your unit tests are passing right?

[sanjayojha]

Yes, its passing.

[0xronin]

Got the same error while stage testing via rinkeby network.

try the following solution! it worked for me

#348