problem with reverted when testing fundMe in lession 7

[Vinhnv0901]

In my smart contract there is a function:

function fund() public payable {
    require(
        msg.value.getConversionRate(priceFeed) >= MINIMUM_USD,
        "You need to spend more ETH!"
    );
    addressToAmountFunded[msg.sender] += msg.value;
    funders.push(msg.sender);
}

when I test fund() with is code:

beforeEach(async function () {
    deployer = (await getNamedAccounts()).deployer
    await deployments.fixture(["all"])
    fundMe = await ethers.getContractAt("FundMe", deployer)
    mockV3Aggregator = await ethers.getContractAt(
        "MockV3Aggregator",
        deployer
    )
})

describe("fund", async function () {
    it("Fails if you don't send enough ETH", async () => {
        await expect(fundMe.fund()).to.be.revertedWith(
            "You need to spend more ETH!"
        )
    })
})

I run yarn hardhat test then I get :

     Fails if you don't send enough ETH:
 AssertionError: Expected transaction to be reverted with reason 'You need to spend more ETH!', but it didn't revert
  at processTicksAndRejections (node:internal/process/task_queues:96:5)
  at Context.<anonymous> (test/unit/FundMe.test.js:27:13)

this is code on github
I hope to receive everyone's help and opinions.

[AbhishekRH]

I am facing the same problem... could anyone help pleasee??? @PatrickAlphaC

[skarthik05]

Hey @AbhishekRH,

Please go through this comment

#6379 (comment)

[GreatApe77]

i checked your repo @Vinhnv0901 . i know this is not related to the question but you commited your .env file to your repo . you should always git ignore your .env file because it contains sensitive information. have a nice day.

[PatrickAlphaC]

What happens when you all clone this repo and try the code that is here?

https://github.com/PatrickAlphaC/hardhat-fund-me-fcc

[ProKing13]

Sir,
I tried your repo code too but still stack in this error @PatrickAlphaC

[skarthik05]

Hey @MohammadArif13,

Please go through this comment
#6379 (comment)

[skarthik05]

Hey @PatrickAlphaC,

I've submitted a pull request to address the issue.
The PR corrects the multiplication factor in the getPrice function within the PriceConverter library to ensure accurate conversion of the ETH/USD rate.

Related PR: PatrickAlphaC/hardhat-fund-me-fcc#188

[PatrickAlphaC]

I'm not sure I'm able to get how you are each getting this issue. I just tried with the codebase as-is and it's working ok.

Could you please write down exactly the steps you're taking to run into this issue starting from doing a git clone on the repo?

[skarthik05]

Hi @Vinhnv0901,

I went through the code in the repository you provided, and it seems there's an error in the getPrice function.

Your code:

function getPrice(
        AggregatorV3Interface priceFeed
    ) internal view returns (uint256) {
        (, int256 answer, , , ) = priceFeed.latestRoundData();
        return uint256(answer * 10000000000);
    }

The correct code should be:

function getPrice(
        AggregatorV3Interface priceFeed
    ) internal view returns (uint256) {
        (, int256 answer, , , ) = priceFeed.latestRoundData();
        return uint256(answer * 1e18);
    }

There should be 18 zeros (0) instead of 10.

Feel free to adjust as needed!

Happy learning!

[PatrickAlphaC]

This isn't quite right. If you multiple the answer by 1e18 instead of 1e10, you'll get a way too big answer!

See here: PatrickAlphaC/hardhat-fund-me-fcc#188 (comment)