Lesson 9 Error while running tests

[Adelani10]

I keep getting this error while running yarn hardhat test:

0 passing (2s)
1 failing

1. Raffle Unit Tests
   "before each" hook for "initializes the raffle correctly":
   ERROR processing /home/adelani/hh-sc-lottery/deploy/01-deploy-raffle.js:
   Error: value out-of-bounds (argument="callbackGasLimit", value={"type":"BigNumber","hex":"0x2386f26fc10000"}, code=INVALID_ARGUMENT, version=abi/5.7.0)
   at Logger.makeError (/home/adelani/hh-sc-lottery/node_modules/@ethersproject/logger/src.ts/index.ts:269:28)
   at Logger.throwError (/home/adelani/hh-sc-lottery/node_modules/@ethersproject/logger/src.ts/index.ts:281:20)
   at Logger.throwArgumentError (/home/adelani/hh-sc-lottery/node_modules/@ethersproject/logger/src.ts/index.ts:285:21)
   at NumberCoder.Coder._throwError (/home/adelani/hh-sc-lottery/node_modules/@ethersproject/abi/src.ts/coders/abstract-coder.ts:68:16)
   at NumberCoder.encode (/home/adelani/hh-sc-lottery/node_modules/@ethersproject/abi/src.ts/coders/number.ts:35:18)
   at /home/adelani/hh-sc-lottery/node_modules/@ethersproject/abi/src.ts/coders/array.ts:71:19
   at Array.forEach ()
   at pack (/home/adelani/hh-sc-lottery/node_modules/@ethersproject/abi/src.ts/coders/array.ts:54:12)
   at TupleCoder.encode (/home/adelani/hh-sc-lottery/node_modules/@ethersproject/abi/src.ts/coders/tuple.ts:54:20)
   at AbiCoder.encode (/home/adelani/hh-sc-lottery/node_modules/@ethersproject/abi/src.ts/abi-coder.ts:111:15)

Here is a link to my repo, I'd appreciate any help: https://github.com/Adelani10/hh-sc-lottery

[HarshDev56]

@Adelani10 The order of arguments in the deployment scripts and contract constructor arguments should be same otherwise it will not initialize properly. if you found this answer helpful then please mark it as Answer/solved . so others can get the answer

in your "01-deploy-raffle.js" file

before it has

 const arguments = [
        vrfCoordinatorV2Address,
        subscriptionId,
        networkConfig[chainId]["gasLane"],
        networkConfig[chainId]["keepersUpdateInterval"],
        networkConfig[chainId]["raffleEntranceFee"],
        networkConfig[chainId]["callbackGasLimit"],
    ]

change it to this

const arguments = [
        vrfCoordinatorV2Address,
        networkConfig[chainId]["raffleEntranceFee"],
        networkConfig[chainId]["gasLane"],
        subscriptionId,
         networkConfig[chainId]["callbackGasLimit"],
        networkConfig[chainId]["keepersUpdateInterval"],
        
       
    ]

[Adelani10]

@HarshDev56 It does solve that one issue but i run into some other failing tests, could you please take a look again. ty

[HarshDev56]

@Adelani10 sure in staging test or in unit test ?

[Adelani10]

@HarshDev56 unit tests bro

[HarshDev56]

@Adelani10 i mention all issues and there solution by comment "ERROR::" in below code . if you found this answer helpful then please mark it as Answer/solved . so others can get the answer

this is your updated Raffle.test.js file for resolving all unit test related issue replace this file with your file

const { assert, expect } = require("chai")
const { network, deployments, ethers } = require("hardhat")
const { developmentChains, networkConfig } = require("../../helper-hardhat-config")

!developmentChains.includes(network.name)
    ? describe.skip
    : describe("Raffle Unit Tests", function () {
        let raffle, raffleContract, vrfCoordinatorV2Mock, raffleEntranceFee, interval, player // , deployer

        beforeEach(async () => {
            accounts = await ethers.getSigners() // could also do with getNamedAccounts
            //   deployer = accounts[0]
            player = accounts[1]
            await deployments.fixture(["mocks", "raffle"]) // Deploys modules with the tags "mocks" and "raffle"
            vrfCoordinatorV2Mock = await ethers.getContract("VRFCoordinatorV2Mock") // Returns a new connection to the VRFCoordinatorV2Mock contract
            raffleContract = await ethers.getContract("Raffle") // Returns a new connection to the Raffle contract
            raffle = raffleContract.connect(player) // Returns a new instance of the Raffle contract connected to player
            raffleEntranceFee = await raffle.getEntranceFee()
            interval = await raffle.getInterval()
        })

        describe("constructor", function () {
            it("initializes the raffle correctly", async () => {
                // Ideally, we'd separate these out so that only 1 assert per "it" block
                // And ideally, we'd make this check everything
                const raffleState = (await raffle.getRaffleState()).toString()
                // Comparisons for Raffle initialization:
                assert.equal(raffleState, "0")
                assert.equal(
                    interval.toString(),
                    networkConfig[network.config.chainId]["keepersUpdateInterval"]
                )
            })
        })

        describe("enterRaffle", function () {
            it("reverts when you don't pay enough", async () => {
                await expect(raffle.enterRaffle()).to.be.revertedWith( // is reverted when not paid enough or raffle is not open
                    "Raffle__NotEnoughETHEntered" // ERROR:: method name is wrong it has to be same as in contract file
                )
            })

            it("records player when they enter", async () => {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                const contractPlayer = await raffle.getPlayer(0)
                assert.equal(player.address, contractPlayer)
            })

            it("emits event on enter", async () => {
                await expect(raffle.enterRaffle({ value: raffleEntranceFee })).to.emit( // emits RaffleEnter event if entered to index player(s) address
                    raffle,
                    "RaffleEnter"
                )
            })

            it("doesn't allow entrance when raffle is calculating", async () => {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                // for a documentation of the methods below, go here: https://hardhat.org/hardhat-network/reference
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                // await network.provider.request({ method: "evm_mine", params: [] }) // ERROR:: this is wroun line below line was correct
                await network.provider.send("evm_mine", []) // this line was correct
                // we pretend to be a keeper for a second
                await raffle.performUpkeep([]) // changes the state to calculating for our comparison below
                await expect(raffle.enterRaffle({ value: raffleEntranceFee })).to.be.revertedWith( // is reverted as raffle is calculating
                    "Raffle__NotOpen" // ERROR:: method name is wrong it has to be same as in contract file
                )
               
            })
        })

        describe("checkUpkeep", function () {
            it("returns false if people haven't sent any ETH", async () => {
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                await network.provider.request({ method: "evm_mine", params: [] })
                const { upkeepNeeded } = await raffle.callStatic.checkUpkeep("0x") // upkeepNeeded = (timePassed && isOpen && hasBalance && hasPlayers)
                assert(!upkeepNeeded)
            })

            it("returns false if raffle isn't open", async () => {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                await network.provider.request({ method: "evm_mine", params: [] })
                await raffle.performUpkeep([]) // changes the state to calculating
                const raffleState = await raffle.getRaffleState() // stores the new state
                const { upkeepNeeded } = await raffle.callStatic.checkUpkeep("0x") // upkeepNeeded = (timePassed && isOpen && hasBalance && hasPlayers)
                assert.equal(raffleState.toString() == "1", upkeepNeeded == false)
            })

            it("returns false if enough time hasn't passed", async () => {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                await network.provider.send("evm_increaseTime", [interval.toNumber() - 5]) // use a higher number here if this test fails
                await network.provider.request({ method: "evm_mine", params: [] })
                const { upkeepNeeded } = await raffle.callStatic.checkUpkeep("0x") // upkeepNeeded = (timePassed && isOpen && hasBalance && hasPlayers)
                assert(!upkeepNeeded)
            })

            it("returns true if enough time has passed, has players, eth, and is open", async () => {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                await network.provider.request({ method: "evm_mine", params: [] })
                const { upkeepNeeded } = await raffle.callStatic.checkUpkeep("0x") // upkeepNeeded = (timePassed && isOpen && hasBalance && hasPlayers)
                assert(upkeepNeeded)
            })
        })

        describe("performUpkeep", function () {
            it("can only run if checkupkeep is true", async () => {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                await network.provider.request({ method: "evm_mine", params: [] })
                const tx = await raffle.performUpkeep("0x") 
                assert(tx)
            })

            it("reverts if checkup is false", async () => {
                await expect(raffle.performUpkeep("0x")).to.be.revertedWith( 
                    "Raffle__UpkeepNotNeeded"
                )
            })

            it("updates the raffle state and emits a requestId", async () => {
                // Too many asserts in this test!
                await raffle.enterRaffle({ value: raffleEntranceFee })
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                await network.provider.request({ method: "evm_mine", params: [] })
                const txResponse = await raffle.performUpkeep("0x") // emits requestId
                const txReceipt = await txResponse.wait(1) // waits 1 block
                const raffleState = await raffle.getRaffleState() // updates state
                const requestId = txReceipt.events[1].args.requestId
                assert(requestId.toNumber() > 0)
                assert(raffleState == 1) // 0 = open, 1 = calculating
            })
        })

        describe("fulfillRandomWords", function () {
            beforeEach(async () => {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                await network.provider.request({ method: "evm_mine", params: [] })
            })
            it("can only be called after performupkeep", async () => {
                await expect(
                    vrfCoordinatorV2Mock.fulfillRandomWords(0, raffle.address) // reverts if not fulfilled
                ).to.be.revertedWith("nonexistent request")
                await expect(
                    vrfCoordinatorV2Mock.fulfillRandomWords(1, raffle.address) // reverts if not fulfilled
                ).to.be.revertedWith("nonexistent request")
            })

            // This test is too big...
            // This test simulates users entering the raffle and wraps the entire functionality of the raffle
            // inside a promise that will resolve if everything is successful.
            // An event listener for the WinnerPicked is set up
            // Mocks of chainlink keepers and vrf coordinator are used to kickoff this winnerPicked event
            // All the assertions are done once the WinnerPicked event is fired

            it("picks a winner, resets, and sends money", async () => {
                const additionalEntrances = 3 // to test
                const startingIndex =  1 // deployer = 0 // ERROR:: starting index should be 1
                const accounts = await ethers.getSigners() //ERROR:: this line has to be included
                for (let i = startingIndex; i < startingIndex + additionalEntrances; i++) { // i = 2; i < 5; i=i+1
                    raffle = raffleContract.connect(accounts[i]) // Returns a new instance of the Raffle contract connected to player
                    await raffle.enterRaffle({ value: raffleEntranceFee })
                }

                const startingTimeStamp = await raffle.getLastTimeStamp() // stores starting timestamp (before we fire our event)

                await new Promise(async (resolve, reject) => {
                    raffle.once("WinnerPicked", async () => { // event listener for WinnerPicked
                        console.log("WinnerPicked event fired!")
                        // assert throws an error if it fails, so we need to wrap
                        // it in a try/catch so that the promise returns event
                        // if it fails.

                        try {
                            // Now lets get the ending values...
                            const recentWinner = await raffle.getRecentWinner()
                            const raffleState = await raffle.getRaffleState()
                            const winnerBalance = await accounts[1].getBalance() // ERROR:: here accounts[1] is correct 
                            const endingTimeStamp = await raffle.getLastTimeStamp()
                            await expect(raffle.getPlayer(0)).to.be.reverted
                            // Comparisons to check if our ending values are correct:
                            assert.equal(recentWinner.toString(), accounts[1].address)
                            assert.equal(raffleState.toString(), "0") //ERROR:: here 0 should be in "" and toString method should call
                            assert.equal(
                                winnerBalance.toString(), 
                                startingBalance // startingBalance + ( (raffleEntranceFee * additionalEntrances) + raffleEntranceFee )
                                    .add(
                                        raffleEntranceFee
                                            .mul(additionalEntrances)
                                            .add(raffleEntranceFee).toString() // ERROR:: toString() should be call here 
                                    )
                                   
                            )
                            assert(endingTimeStamp > startingTimeStamp)
                            resolve() // if try passes, resolves the promise 
                        } catch (e) {
                            reject(e)
                        }
                        
                    })

                    // ERROR:: below code should be here not inside above Brackets  
                    // kicking off the event by mocking the chainlink keepers and vrf coordinator
                    const tx = await raffle.performUpkeep("0x")
                    const txReceipt = await tx.wait(1)
                    const startingBalance = await accounts[1].getBalance() // ERROR:: here accounts[1] is correct 
                    await vrfCoordinatorV2Mock.fulfillRandomWords(
                        txReceipt.events[1].args.requestId,
                        raffle.address
                    )
                })
            })
        })
    })

[Adelani10]

@HarshDev56 thanks a lot bro, I appreciate!

[alymurtazamemon]

@Adelani10 Please see the solution provided by @HarshDev56. If it solves your issue then mark it as answered otherwise let me know so I can see it further.

[Adelani10]

Can't seem to figure out how to mark as answered

[HarshDev56]

@Adelani10 you can see checkmark or round with checkmark besides of three dots on my answer you can click over there and make it answer.

[alymurtazamemon]

@Adelani10 The discussion category should be Q&A in order to see the Mark as answer option. I have done it with no issue.

[Adelani10]

okay thanks guys @alymurtazamemon @HarshDev56