lesson-3: How to access the struct inside SimpleStorage.sol from StorageFactory.sol

[MohammadRokib]

I want to access the name and the number of struct inside SimpleStorage.sol from StorageFactory.sol
How do I do it. I tried to do it in the following way but I got the following error. Any suggestions will be helpful. Thank you.

[alymurtazamemon]

@MohammadRokib Answered it here #4300

[MohammadRokib]

When I deployed the StorageFactory.sol locally using hardhat it works fine.

But when I change the network to Sepolia it gives an error on the sfGet function

// sfGet function
const updatedValue = await sfContract.sfGet("0");
console.log (`Updated value: ${updatedValue}`);

I also tried this. But it gives the same error

// sfGet function
const updatedValue = await sfContract.sfGet(0);
console.log (`Updated value: ${updatedValue}`);

[alymurtazamemon]

@MohammadRokib Can I see the full code of both contracts?

[MohammadRokib]

SimpleStorage.sol

// SPDX-License-Identifier: MIT
pragma solidity 0.8.7;

contract SimpleStorage {
    uint256 public number;
    struct People {
        string name;
        uint256 num;
    }

    People[] public list;
    mapping (string => uint256) manToNum;
    
    function store(uint256 num) public virtual {
        number = num;
    }

    function retrieve() public view returns (uint256) {
        return number;
    }

    function addPerson(string memory str, uint256 n) public {
        list.push(People(str, n));
        manToNum[str] = n;
    }
}

ExtraStorage.sol

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

import "./SimpleStorage.sol";

contract ExtraStorage is SimpleStorage {
    function store (uint256 num) public override {
        number = num;
    }
}

[alymurtazamemon]

@MohammadRokib and your factory contract?

[MohammadRokib]

I just have these two contracts.

[MohammadRokib]

Sorry my bad!

StorageFactory.sol

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

import "./SimpleStorage.sol";

contract StorageFactory {
    SimpleStorage[] public ssArray;
    string public personName;
    uint256 public personNum;

    function createSimpleStorage() public {
        SimpleStorage simpleStorage = new SimpleStorage();
        ssArray.push(simpleStorage);
    }

    function sfStore (uint256 ssIndex, uint256 ssNum) public {
        SimpleStorage sStorage = ssArray[ssIndex];
        sStorage.store (ssNum);
    }

    function sfGet (uint256 ssIndex) public view returns (uint256) {
        SimpleStorage sStorage = ssArray[ssIndex];
        return sStorage.retrieve ();
    }

    function sfAddPerson (uint256 ssIndex, string memory str, uint256 num) public {
        SimpleStorage sStorage = ssArray[ssIndex];
        sStorage.addPerson (str, num);

        ( personName, personNum ) = sStorage.list(0);
    }
}

[alymurtazamemon]

@MohammadRokib Your contracts look correct. Leave your repository link so I can test it locally.

If you do not know how to upload local code to GitHub repository then head over to this discussion #2637.

[MohammadRokib]

https://github.com/MohammadRokib/HardHat_StorageFactory

[MohammadRokib]

Any suggestion to the problem ?

[alymurtazamemon]

@MohammadRokib You were not waiting for the write request to complete and were trying to read the updated data due to that it was throwing an error. Here you can see it is working perfectly fine;

here is your deploy script updated code;

// imports
const { ethers, run } = require("hardhat");

// async main
async function main() {
    const hexString = "0";
    const index = BigInt(hexString);

    console.log("Deploying contract...");
    const StorageFactory = await ethers.getContractFactory("StorageFactory");
    const sfContract = await StorageFactory.deploy();
    await sfContract.deployed();

    console.log(`Contract deployed to: ${sfContract.address}`);
    console.log("-----------------------------------------\n");

    // if (network.config.chainId === 11155111 && process.env.ETHERSCAN_API_KEY) {
    //     await simpleStorage.deployTransaction.wait(6);
    //     await verify(simpleStorage.address, []);
    // }

    // createSimpleStorage function
    console.log("createSimpleStorage function");
    let tx = await sfContract.createSimpleStorage();
    console.log("-----------------------------------------\n");
    await tx.wait(1);

    // sfStore function
    console.log("sfStore function");
    tx = await sfContract.sfStore(0, 321);
    console.log("-----------------------------------------\n");
    await tx.wait(1);

    // sfGet function
    console.log("sfGet function");
    const updatedValue = await sfContract.sfGet(0);
    console.log(`Updated value: ${updatedValue}`);
    console.log("-----------------------------------------\n");

    // sfAddPerson;
    console.log("sfAddPerson");
    tx = await sfContract.sfAddPerson(0, "Jack", 987);
    await tx.wait(1);

    const personName = await sfContract.personName();
    const personNum = await sfContract.personNum();

    console.log(`Name: ${personName}`);
    console.log(`Number: ${personNum}`);
    console.log("-----------------------------------------\n");
}

async function verify(contractAddress, args) {
    console.log("Verifying contract...");
    try {
        await run("verify:verify", {
            address: contractAddress,
            constructorArguments: args,
        });
    } catch (e) {
        if (e.message.toLowerCase().includes("already verified")) {
            console.log("Already verified");
        } else {
            console.log(e);
        }
    }
}

// main
main()
    .then(() => process.exit(0))
    .catch((error) => {
        console.error(error);
        process.exit(1);
    });

[MohammadRokib]

It worked. Thanks alot

[MohammadRokib]

In lesson-6 HardHat SimpleStorage when I run the command:

yarn hardhat run scripts/deploy.js

The output is

Deploying contract...
Deployed contract to: 0x5FbDB2315678afecb367f032d93F642f64180aa3

Here the contract is deployed to the address: 0x5FbDB2315678afecb367f032d93F642f64180aa3
Is that contract address mine? I can't find that address in the hardhat nodes

When I deploy the contract on sepolia testnet the contract is deploying to 0xaC05a4977ed8201FCef3e34CD0C31845B3A3a142 and this is not the account from my metamask.
Is this address being created randomly?

[alymurtazamemon]

@MohammadRokib These are the addresses of deployed smart contracts not your or hardhat accounts.

[MohammadRokib]

In lesson-7 I wrote FundMe.test.js according to the video like this:

const { assert, expect } = require("chai");
const { deployments, ethers, getNamedAccounts } = require("hardhat");

describe("FundMe", async function () {
    let fundMe, deployer, mockV3Aggregator;

    beforeEach(async function () {
        deployer = (await getNamedAccounts()).deployer;
        await deployments.fixture(["all"]);
        fundMe = await ethers.getContract("FundMe", deployer);
        mockV3Aggregator = await ethers.getContract("MockV3Aggregator", deployer);
    });

    describe("constructor", async function () {
        it("sets the aggregator address correctly", async function () {
            const response = await fundMe.priceFeed();
            assert.equal(response, mockV3Aggregator.address);
        });
    });
});

But when I run the command yarn hardhat test I get the following error.

What does it mean. Where am I doing wrong here?

[MohammadRokib]

Never mind I just solved the issue. It seems that the version of ethers was causing the problem. The version of ethers was 6.3.0. But code runs perfectly with the version 5.7.2 So I just installed it with the command:

yarn add ethers@5.7.2

[MohammadRokib]

Lesson: 7 (Problem with testing the owner only modifier)

FundMe.sol:

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

import "./PriceConverter.sol";

error FundMe__NotOwner();

contract FundMe {
    using PriceConverter for uint256;

    uint256 public minUSD = 50*1e18;

    address[] public funders;
    address public immutable owner;
    mapping (address => uint256) public addToAmount;

    AggregatorV3Interface public priceFeed;

    modifier onlyOwner {
        // require(msg.sender == owner, "Administrator only");
        if (msg.sender != owner) revert FundMe__NotOwner();
        _;
    }
    
    constructor(address priceFeedAddress) {
        owner = msg.sender;
        priceFeed = AggregatorV3Interface(priceFeedAddress);
    }

    function fund() public payable {
        require(msg.value.getConversionRate(priceFeed) >= minUSD, "Insufficient fund");

        funders.push(msg.sender);
        addToAmount[msg.sender] += msg.value;
    }

    function withdraw() public onlyOwner {
        for (uint256 i = 0; i < funders.length; i++) {
            address funder = funders[i];
            addToAmount[funder] = 0;
        }

        funders = new address[](0);
        (bool callSuccess, ) = payable(msg.sender).call{value: address(this).balance}("");
        require(callSuccess, "Transaction Failed");
    }
}

FundMe.test.js

const { assert, expect } = require("chai");
const { deployments, ethers, getNamedAccounts } = require("hardhat");

describe("FundMe", async function () {
    let fundMe, deployer, mockV3Aggregator;
    const sendValue = ethers.utils.parseEther("1");

    beforeEach(async function () {
        deployer = (await getNamedAccounts()).deployer;
        await deployments.fixture(["all"]);
        fundMe = await ethers.getContract("FundMe", deployer);
        mockV3Aggregator = await ethers.getContract(
            "MockV3Aggregator",
            deployer
        );
    });

    describe("withdraw", async function () {
        beforeEach(async function () {
            await fundMe.fund({ value: sendValue });
        });

        it("only allows the owner to withdraw", async function () {
            const accounts = await ethers.getSigners();
            const connection = await fundMe.connect(accounts[1]);
            await expect(connection.withdraw()).to.be.revertedWith("FundMe__NotOwner");
        });
    });
});

When I run the command yarn hardhat test it gives the following error:

AssertionError: Expected transaction to be reverted with reason 'FundMe__NotOwner', but it reverted with a custom error