Lesson 9: Unable to deploy. Multiple warnings regarding VRFCoordinatorV2Mock.sol

[rubnx]

For some reason it has been impossible to deploy my Raffle.sol contract and also the VRFCoordinatorV2Mock.sol contract.
Whenever I try I get a bunch of warnings and then a line saying Compiled 9 Solidity files successfully but nothing gets deployed.

I tried lowering the ethers version plus a bunch of other things that I read in the discussions. I even restarted a hardhat project from scratch in case the problem was some dependencies or node modules.

This is my repository in case someone can shed some light on what is wrong.

https://github.com/rubnx/hardhat-lottery-fcc.git

Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:306:45:
    |
306 |   function requestSubscriptionOwnerTransfer(uint64 _subId, address _newOwner) external pure override {
    |                                             ^^^^^^^^^^^^^


Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:306:60:
    |
306 |   function requestSubscriptionOwnerTransfer(uint64 _subId, address _newOwner) external pure override {
    |                                                            ^^^^^^^^^^^^^^^^^


Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:310:44:
    |
310 |   function acceptSubscriptionOwnerTransfer(uint64 _subId) external pure override {
    |                                            ^^^^^^^^^^^^^


Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:314:33:
    |
314 |   function pendingRequestExists(uint64 subId) public view override returns (bool) {
    |                                 ^^^^^^^^^^^^


Warning: Function state mutability can be restricted to pure
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:261:3:
    |
261 |   function getConfig()
    |   ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:274:3:
    |
274 |   function getFeeConfig()
    |   ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:302:3:
    |
302 |   function getFallbackWeiPerUnitLink() external view returns (int256) {
    |   ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:314:3:
    |
314 |   function pendingRequestExists(uint64 subId) public view override returns (bool) {
    |   ^ (Relevant source part starts here and spans across multiple lines).


Compiled 9 Solidity files successfully

[alymurtazamemon]

@rubnx Your deploy scripts should be inside the deploy folder not in the scripts folder. We use hardhat-deploy plugin to deploy the contract and it only recognises the deploy scripts if they are inside the deploy folder.

[rubnx]

Oh, you are right! Thank you so much! I spent hours looking for the issue (I even fixed some minor issues and misspellings I found), but the real problem was right in front of me.

I created a deploy folder and placed all my deploy files there and now my contracts get deployed with no issue.

I still have a question though. Any idea why I still get all those warnings before deploying?

rubenruiz@Rubens-MBP hardhad-lottery-fcc % hh clean
rubenruiz@Rubens-MBP hardhad-lottery-fcc % hh deploy
Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:306:45:
    |
306 |   function requestSubscriptionOwnerTransfer(uint64 _subId, address _newOwner) external pure override {
    |                                             ^^^^^^^^^^^^^


Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:306:60:
    |
306 |   function requestSubscriptionOwnerTransfer(uint64 _subId, address _newOwner) external pure override {
    |                                                            ^^^^^^^^^^^^^^^^^


Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:310:44:
    |
310 |   function acceptSubscriptionOwnerTransfer(uint64 _subId) external pure override {
    |                                            ^^^^^^^^^^^^^


Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:314:33:
    |
314 |   function pendingRequestExists(uint64 subId) public view override returns (bool) {
    |                                 ^^^^^^^^^^^^


Warning: Function state mutability can be restricted to pure
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:261:3:
    |
261 |   function getConfig()
    |   ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:274:3:
    |
274 |   function getFeeConfig()
    |   ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:302:3:
    |
302 |   function getFallbackWeiPerUnitLink() external view returns (int256) {
    |   ^ (Relevant source part starts here and spans across multiple lines).


Warning: Function state mutability can be restricted to pure
   --> @chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:314:3:
    |
314 |   function pendingRequestExists(uint64 subId) public view override returns (bool) {
    |   ^ (Relevant source part starts here and spans across multiple lines).


Compiled 9 Solidity files successfully
Local network detected! Deploying mocks...
deploying "VRFCoordinatorV2Mock" (tx: 0xf50670372fe601f04f6469a19634012866cc208bc3ed8f1c902ef2b2fb6bb71f)...: deployed at 0x5FbDB2315678afecb367f032d93F642f64180aa3 with 2540078 gas
Mocks Deployed!
-------------------------------------------------
deploying "Raffle" (tx: 0x1786217c31dfe1474f0e92963b099d907678c9079ddb44bacfe8edda58c84129)...: deployed at 0xCf7Ed3AccA5a467e9e704C703E8D87F634fB0Fc9 with 1178342 gas
-------------------------------------------

[alymurtazamemon]

@rubnx You can ignore these, these are from inherited contracts where some functions are not using their parameters and some have less restricted state mutability.

[rubnx]

Good to know. Thanks a lot again.