Lesson-3 Error

[Sairam002]

Hey @PatrickAlphaC ,
I'm trying to get the value of addPerson function which is in SimpleStorage.sol from StorageFactory.sol.

Code :-
SimpleStorage.sol :-

// SPDX-License-Identifier: MIT

pragma solidity 0.8.8;

contract SimpleStorage {

    uint256 favoriteNumber;

    struct People {
        uint256 favoriteNumber;
        string name;
    }
    
    People[] public people;

    mapping(string => uint256) public nameToFavoriteNumber;

    function store(uint256 _favoriteNumber) public {
        favoriteNumber = _favoriteNumber;
    }
    
    function retrieve() public view returns (uint256){
        return favoriteNumber;
    }

    function addPerson(string memory _name, uint256 _favoriteNumber) public {
        people.push(People(_favoriteNumber, _name));
        nameToFavoriteNumber[_name] = _favoriteNumber;
    }

    function getPeople() view public returns(People[] memory){
        return people;
    }
}

StorageFactory :-

//SPDX-License-Identifier:MIT
pragma solidity ^0.8.0;

import "SimpleStorage.sol";

contract StorageFactory{

    SimpleStorage[] _simpleStorage;

    function createSimpleStorage() public {
        SimpleStorage simpleStorage = new SimpleStorage();
        _simpleStorage.push(simpleStorage);
    }

    function updateStore(uint _SimpleStorageIndex, uint _number) public{
        SimpleStorage sample = _simpleStorage[_SimpleStorageIndex];
        sample.store(_number);
    }

    function getStore(uint _SimpleStorageIndex) public view returns(uint){
        SimpleStorage sample5 = _simpleStorage[_SimpleStorageIndex];
        return sample5.retrieve();
    }

    function simpleStorageAddPerson(uint _SimpleStorageIndex,uint _favoriteNumber,string memory _name) public {
        SimpleStorage sample = _simpleStorage[_SimpleStorageIndex];
        sample.addPerson(_name,_favoriteNumber);
    }

    function getPerson(uint _SimpleStorageIndex) view public returns(People[]){
        SimpleStorage sample = _simpleStorage[_SimpleStorageIndex];
        return sample.getPeople;
    }
}

Error in StorageFactory.sol :-

In function getPerson()  I'm getting error

        function getPerson(uint _SimpleStorageIndex) view public returns(People[]){
            SimpleStorage sample = _simpleStorage[_SimpleStorageIndex];
            return sample.getPeople;

Error :-
DeclarationError: Identifier not found or not unique.
--> StorageFactory.sol
function getPerson(uint _SimpleStorageIndex) view public returns(People[]){

Can you help me why I'm getting error???

[alymurtazamemon]

@Sairam002 sample.getPeople; is not any property.

[alymurtazamemon]

@Sairam002

function getPerson(uint _SimpleStorageIndex) view public returns(People[]){
            SimpleStorage sample = _simpleStorage[_SimpleStorageIndex];
            return sample.getPeople; //here

[Sairam002]

Still getting error...

Error
Declaration error : Identifier not found or not unique!!!

Showing some error in getPerson(uint _SimpleStorageIndex) view public returns(People[] memory){

In the above line in the People[] memory showing declaration error...

[Sairam002]

Hi @PatrickAlphaC, I need some help here..
Please help me....

[PatrickAlphaC]

Is this part of the course?

[Sairam002]

Is this part of the course?

Yes, I'm trying to understand solidity better, So, I'm trying to get each and every function in SimpleStorage.sol from StorageFactory.sol.

[ppoojjaa]

You are trying to return multiple values in a function and that is a bit complicated.
Check out: https://ethereum.stackexchange.com/questions/7317/how-can-i-return-struct-when-function-is-called
https://ethereum.stackexchange.com/questions/3609/returning-a-struct-and-reading-via-web3/3614#3614

Hope this helps :)

[Sairam002]

Thanks for your effort
This helped a little bit but not completely...
I can't able to call the getPeople() function from strorageFactory.sol but can able to access it from SimpleStorage.sol

Sorry for late response...
My apologize ...