Lesson 9 Raffle__UpkeepNotNeeded being (incorrectly!) invoked

[nstapleton1]

I am running the following test. When I execute it, the error, Raffle__UpkeepNotNeeded is being thrown

it("doesn't allow entrance when raffle is calculating", async () => {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                // for a documentation of the methods below, go here: https://hardhat.org/hardhat-network/reference
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                await network.provider.request({ method: "evm_mine", params: [] })
                // we pretend to be a keeper for a second
                await raffle.performUpkeep([]) // changes the state to calculating for our comparison below
                await expect(raffle.enterRaffle({ value: raffleEntranceFee })).to.be.revertedWith( // is reverted as raffle is calculating
                    "Raffle__RaffleNotOpen"
                )
            })//end: doesn't allow....

I have extended the error in Raffle.sol to:

error  Raffle__UpkeepNotNeeded(uint256 currentBalance, uint256 numPlayers, uint256 raffleState, uint256 interv);

The error in the console is:
Error: VM Exception while processing transaction: reverted with custom error 'Raffle__UpkeepNotNeeded(10000000000000000, 1, 0, 33)'

I conclude that balance: 10000000000000000, numPlayers: 1, raffleState: 0 (i.e. OPEN) and interval: 33 (greater than 30)

The performUpkeep function is:

    function performUpkeep(
        bytes calldata /*performData*/
    ) external override {        
        (bool upkeepNeeded, ) = checkUpkeep("");
        if(!upkeepNeeded){
            revert Raffle__UpkeepNotNeeded(
                address(this).balance,
                s_players.length,
                uint256(s_raffleState),
                uint256((block.timestamp - s_lastTimeStamp))
            );
        }
        s_raffleState = RaffleState.CALCULATING;
        //request random number
        //then do something with the number
        //chainlink vrf is a 2 transaction process

        // i_vrfCoordinator.requestRandomWords(keyHash, subId, minimumRequestConfirmations, callbackGasLimit, numWords);
        uint256 requestId = i_vrfCoordinator.requestRandomWords(
            i_gasLane, 
            i_subscriptionId, 
            REQUEST_CONFIRMATIONS, 
            i_callbackGasLimit, 
            NUM_WORDS
        );
        emit RequestedRaffleWinner(requestId);
    }

The checkUpkeep function is:

    function checkUpkeep(
        bytes memory /* checkData */
    )
        public
        view
        override
        returns (
            bool upkeepNeeded,
            bytes memory /* performData */
        )
    {
        bool isOpen  = RaffleState.OPEN == s_raffleState;
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = (s_players.length>0);
        bool hasBalance = address(this).balance > 0;
        bool upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
    }

I would really appreciate any insight into why this test is failing.

[nstapleton1]

I found the answer here: #359

Add these lines to the end of checkUpkeep:
upkeepNeeded = (timePassed && isOpen && hasBalance && hasPlayers);
return (upkeepNeeded, "0x0");

I had previously tried this but when I added the lines, I forgot to re-deploy the contract before running the tests again.