Invalid TokenId, Lesson 14

[NicolasMazzoleni]

Lesson

Lesson 14

Could you please leave a link to the timestamp in the video where this error occurs? (You can right click a video and "copy video URL at current time")

https://youtu.be/gyMwXuJrbJQ?t=84834

Operating System

macOS (Apple Silicon)

Describe the bug

Hello guys,

I am facing an issue regarding the deployment of the Lesson 14 DynamicSvgNft.sol contract.
It seams like the override function tokenURI() is not working properly. When a tokenId = 0 is passed as a parameter (when called from the local nodes or when it's deployed on the Goerli testnest, the function is reverted with the custom error.
Here 's a screenshot of the console below.

import "@openzeppelin/contracts/token/ERC721/ERC721.sol"; import "@openzeppelin/contracts/access/Ownable.sol"; import "base64-sol/base64.sol"; import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol"; import "hardhat/console.sol"; error DynamicSVGNFT__UnexistenceTokenId(); contract DynamicSVGNFT is ERC721, Ownable {

uint256 private s_tokenCounter;
string private i_lowImageURI;
string private i_highImageURI;
string private c_base64EncodedSvgPrefix = "data:image/svg+xml;base64,";
AggregatorV3Interface internal immutable i_priceFeed;
mapping(uint256 => int256) public s_tokenIdToHighValue; // Is like declaring an array in JS

event createdNFT(uint256 tokenId, int256 highValue);

constructor(
    address priceFeedAddress,
    string memory lowSvg,
    string memory highSvg
) ERC721("Dynamic SVG NFT", "DSN") {
    s_tokenCounter = 0;
    i_lowImageURI = svgToImageURI(lowSvg);
    i_highImageURI = svgToImageURI(highSvg);
    i_priceFeed = AggregatorV3Interface(priceFeedAddress);
}

function svgToImageURI(string memory svg) public view returns (string memory) {
    string memory svgBase64Encoded = Base64.encode(bytes(string(abi.encodePacked(svg))));
    return string(abi.encodePacked(c_base64EncodedSvgPrefix, svgBase64Encoded));

    // string memory svgBase64Encoded = Base64.encode(bytes(string.concat(svg)));
    // return string.concat(base64EncodedSvgPrefix, svgBase64Encoded);
}

// publishing your token on the blockchain to make it purchasable
function mintNft(int256 highValue) public {
    s_tokenIdToHighValue[s_tokenCounter] = highValue;
    s_tokenCounter += 1;
    _safeMint(msg.sender, s_tokenCounter);
    emit createdNFT(s_tokenCounter, highValue);
}

function _baseURI() internal pure override returns (string memory) {
    return "data:application/json;base64,";
}

function tokenURI(uint256 tokenId) public view virtual override returns (string memory) {
    if (!_exists(tokenId)) {
        revert DynamicSVGNFT__UnexistenceTokenId();
    }
    (, int256 price, , , ) = i_priceFeed.latestRoundData();
    string memory imageURI = i_lowImageURI;
    if (price >= s_tokenIdToHighValue[tokenId]) {
        imageURI = i_highImageURI;
    }
    return
        string(
            abi.encodePacked(
                _baseURI(),
                Base64.encode(
                    bytes(
                        abi.encodePacked(
                            '{"name":"',
                            name(), // You can add whatever name here
                            '", "description":"An NFT that changes based on the Chainlink Feed", ',
                            '"attributes": [{"trait_type": "coolness", "value": 100}], "image":"',
                            imageURI,
                            '"}'
                        )
                    )
                )
            )
        );
}}`

If you guys have an idea on where I should look for this kind of error.
Thank you !
Nicolas

[alymurtazamemon]

@NicolasMazzoleni Update the token id after minting;

_safeMint(msg.sender, s_tokenCounter);
s_tokenCounter += 1;

[alymurtazamemon]

@NicolasMazzoleni You random ipfs deploy script is not working nfts token uris is not mentioned. Did you check those?

[NicolasMazzoleni]

@NicolasMazzoleni You random ipfs deploy script is not working nfts token uris is not mentioned. Did you check those?

Hey, thanks for your response, what do you mean by "Did you check those" ? Thanks, Nico

[alymurtazamemon]

@NicolasMazzoleni I mean did you check tokenURIs list is missing in the deploy script due to that it is not deploying.

[NicolasMazzoleni]

It's there no ? from 02-deploy-random-ipfs-nft.js file @alymurtazamemon

async function handleTokenURIs() {
// Store the Image in IPFS
// Store the metadata in IPFS
tokenURIs = []

const { responses: imageUploadReponses, files } = await storeImages("./images/randomNft/")
for (imageUploadReponseIndex in imageUploadReponses) {
    let tokenURIMetadata = { ...metadataTemplate }
    tokenURIMetadata.name = files[imageUploadReponseIndex].replace(".png", "")
    tokenURIMetadata.description = `An adorable ${tokenURIMetadata.name} pup!`
    tokenURIMetadata.image = `ipfs://${imageUploadReponses[imageUploadReponseIndex].IpfsHash}`
    console.log(`Uploading ${tokenURIMetadata.name}...`)

    const metadataUploadResponse = await storeTokenURIMetadata(tokenURIMetadata)
    tokenURIs.push(`ipfs://${metadataUploadResponse.IpfsHash}`)
}

console.log("Token URIs uploaded !")
return tokenURIs

}

[NicolasMazzoleni]

@alymurtazamemon