FundMe-RemixIDE: Failing to FUND after having deployed the contract.

[0xjarix]

FundMe-RemixIDE: Failing to FUND after having deployed the contract. Please do note that I am taking into account the current price of ETH in USD.
Does anyone have any idea?

[Ozoano]

send a snippet of your source code...

[0xjarix]

`pragma solidity ^0.8.13;

import "./PriceConverter.sol";

contract FundMe {
using PriceConverter for uint256; // Attaching our Library to uint256

uint256 public minimumUSD = 50 * 1e18;

address public owner;

constructor() {
    owner = msg.sender;
}
address[] public funders;
mapping(address => uint256) public addressToAmountFunded;
function fund() public payable {
    // Want to be able to set a minimum fund amount in USD
    // How do we send ETH to this contract?
    require(msg.value.getConversionRate() >= minimumUSD, "Didn't send enough"); // 1 ETH = 1e18 = 1 * 10 ** 18 = 1000000000000000000 Wei
    funders.push(msg.sender);
    addressToAmountFunded[msg.sender] = msg.value;
}

function withdraw() public onlyOwner {
    for (uint funderIndex = 0; funderIndex < funders.length; funderIndex++) {
        address funder = funders[funderIndex];
        addressToAmountFunded[funder] = 0;
    }
    // reset the array
    funders = new address[](0);
    // actually withdraw the funds
    (bool succ,) = payable(msg.sender).call{value: address(this).balance}("");
    require(succ, "Call failed");
}

modifier onlyOwner() {
    require(msg.sender == owner, "Sender is not the owner");
    _;
}

}`

[Ozoano]

what would be the problem you're running into?

One thing I noticed in your contract code is that in the line addressToAmountFunded[msg.sender] = msg.value; you just assign the value to the address that sent, and every transaction sent will replace the last amount in the "address balance", but this would not change the contract balance, only if you check the "addressToAmountFunded" for that address would be the last amount that you've sent...but the contract balance will still be right

Actually, you got it wrong, that's is a mapping - i.e key : value pairs. which aids to display the owner index when an address is provided. The source code is fine... Dunno the cause of the failure

[0xREALAldc]

Yeah, I know it's a mapping, don't know whare I said it wasn't...I didn't quite explained what I meant because I forgot to say that later Patrick uses a += in that line, so the address that is sending the ETH will have all the amounts sent sum up for that address, and yes if you send from two different addresses each one will have their place in the mapping.

I did the same "mistake" and thought that my contract was wrong because I sent two times 0.02 eth from one address and that address had only 0.02 eth as amount sent, I only saw this that was different on his contract compared to Patricks.

Also don't know why it's failing thought, if it's showing an error try and paste here for us @joe17ar

[Ozoano]

Yeah, I know it's a mapping, don't know whare I said it wasn't...I didn't quite explained what I meant because I forgot to say that later Patrick uses a += in that line, so the address that is sending the ETH will have all the amounts sent sum up for that address, and yes if you send from two different addresses each one will have their place in the mapping.

I did the same "mistake" and thought that my contract was wrong because I sent two times 0.02 eth from one address and that address had only 0.02 eth as amount sent, I only saw this that was different on his contract compared to Patricks.

Also don't know why it's failing thought, if it's showing an error try and paste here for us @joe17ar

Okay,
you are correct

[0xjarix]

thank you guys @Ozoano and @0xREALAldc, I did as you told me and changed the = to +=... I didn't realize that Patrick changed it at then end, I was like (What if the user funds several times...) Anyway, it is still not working for me
That's the alert message I am getting from Remix when I try to fund"Gas estimation errored with the following message (see below). The transaction execution will likely fail. Do you want to force sending?
execution reverted"
And that's my transaction logs:

[block:8464274 txIndex:4]

from: 0xd95...9cdcf

to: FundMe.fund() 0x75b...F6E2a

value: 40000000000000000 wei

data: 0xb60...d4288

logs: 0

hash: 0xc9e...31c05

Debug

status	false Transaction mined but execution failed
transaction hash	0x9ad885842f329662cb9f517105e14b4d3d5e326f99b0bce083cfb35bfea810a4
from	0xd95ea3d35D5B4AB1DecAA33610192dc7F459cdcf
to	FundMe.fund() 0x75b76f8205A38CE78550e2480ab63f69baCF6E2a
gas	8000000 gas
transaction cost	24159 gas
input	0xb60...d4288
decoded input	{}
decoded output	-
logs	[]
val	40000000000000000 wei

[Ozoano]

Lets see the change you made to the code...

to be sure

[0xjarix]

I kept going with the video and finished the remix part, the code I am going to send, is the same I send above but with some gas optimization (constant, immutable keywords, use of fallbacks,...) nothing that changes the logic of the code, it just reduces the gas spent at contract deployment.
Here's the code I have now:
`pragma solidity ^0.8.13;

import "./PriceConverter.sol";

error NotOwner();

contract FundMe {
using PriceConverter for uint256; // Attaching our Library to uint256

uint256 public constant minimumUSD = 50 * 1e18;

address public immutable owner;

constructor() {
    owner = msg.sender;
}
address[] public funders;
mapping(address => uint256) public addressToAmountFunded;
function fund() public payable {
    // Want to be able to set a minimum fund amount in USD
    // How do we send ETH to this contract?
    require(msg.value.getConversionRate() >= minimumUSD, "Didn't send enough"); // 1 ETH = 1e18 = 1 * 10 ** 18 = 1000000000000000000 Wei
    funders.push(msg.sender);
    addressToAmountFunded[msg.sender] += msg.value;
}

function withdraw() public onlyOwner {
    for (uint funderIndex = 0; funderIndex < funders.length; funderIndex++) {
        address funder = funders[funderIndex];
        addressToAmountFunded[funder] = 0;
    }
    // reset the array
    funders = new address[](0);
    // actually withdraw the funds
    (bool succ,) = payable(msg.sender).call{value: address(this).balance}("");
    require(succ, "Call failed");
}

modifier onlyOwner() {
    if(msg.sender != owner)
        revert NotOwner();
    _;
}

// What if someone decides to fund the contract without using the Fund() function
receive() external payable {
    fund();
}

fallback() external payable {
    fund();
}

}`

[0xjarix]

// Get Funds from users
// Witrhdraw funds
// Set a minimum funding value in USD

// SPDX-License-Identifier: MIT

pragma solidity ^0.8.13;

import "./PriceConverter.sol";

error NotOwner();

contract FundMe {
    using PriceConverter for uint256; // Attaching our Library to uint256

    uint256 public constant minimumUSD = 50 * 1e18;
    
    address public immutable owner;

    constructor() {
        owner = msg.sender;
    }
    address[] public funders;
    mapping(address => uint256) public addressToAmountFunded;
    function fund() public payable {
        // Want to be able to set a minimum fund amount in USD
        // How do we send ETH to this contract?
        require(msg.value.getConversionRate() >= minimumUSD, "Didn't send enough"); // 1 ETH = 1e18 = 1 * 10 ** 18 = 1000000000000000000 Wei
        funders.push(msg.sender);
        addressToAmountFunded[msg.sender] += msg.value;
    }

    function withdraw() public onlyOwner {
        for (uint funderIndex = 0; funderIndex < funders.length; funderIndex++) {
            address funder = funders[funderIndex];
            addressToAmountFunded[funder] = 0;
        }
        // reset the array
        funders = new address[](0);
        // actually withdraw the funds
        (bool succ,) = payable(msg.sender).call{value: address(this).balance}("");
        require(succ, "Call failed");
    }

    modifier onlyOwner() {
        if(msg.sender != owner)
            revert NotOwner();
        _;
    }

    // What if someone decides to fund the contract without using the Fund() function
    receive() external payable {
        fund();
    }

    fallback() external payable {
        fund();
    }
}

[alymurtazamemon]

@joe17ar Which price feed address are you using?

[0xjarix]

@alymurtazamemon I just checked and I used that of the mainnet instead of that of goerli now it works just fine! Thanks for your help!