Couldn't get an advisory to go away on FundMe.sol exercise, curious where I messed up.

[JohnWukong]

As 'strongly suggested', I am asking about a problem I had during FundMe.sol exercise.
The code compiled and ran/deployed, and as far as I know I copied the code verbatim, but I get an error on the following code.

function withdraw() public onlyOwner {
// require(msg.sender == owner, "Bad touch! Only the owner of this fund can withdraw");
    for(uint256 funderIndex = 0; funderIndex < funders.length; /* funderIndex = funderIndex + 1*/ funderIndex++){
        address funders = funders[funderIndex] ;   // < warning here
        addresstoamountFunded[funders] = 0;
    }
   

Were I get the following warning;

Warning: This declaration shadows an existing declaration.
  --> contracts/FundMe.sol:34:9:
   |
34 |         address funders = funders[funderIndex] ;
   |         ^^^^^^^^^^^^^^^
Note: The shadowed declaration is here:
  --> contracts/FundMe.sol:16:1:
   |
16 | address[] public funders;
   | ^^^^^^^^^^^^^^^^^^^^^^^^

I left both in and it ran fine, but I'm OCD enough that I'd like to know whether this is normal or I should of omitted one mention...

Thanks in advance

John

[umairahmed88]

try this

function withdraw() public onlyOwner {
    for (uint256 funderIndex = 0;funderIndex < funders.length; funderIndex++) {
    address funder = funders[funderIndex];  //    <==== change this line
    addressToAmountFunded[funder] = 0; //    <==== change this line
}

[alymurtazamemon]

@JohnWukong The reason is you already have a state variable of name funders and you are trying to declare another variable of the same name inside a function which is causing an error (its name is shadowing an existing declaration).