TypeError: Cannot read properties of undefined (reading 'JsonRpcProvider')

[LimbicAutomaton]

Hi All

I was getting the following error at 7:07 while trying to deploy first contract in VS:
'''solidity
TypeError: Cannot read properties of undefined (reading 'JsonRpcProvider')
at main (/home/ben_hudson/hh-fcc/ethers-simple-storage/deploy.js:8:41)
at Object. (/home/ben_hudson/hh-fcc/ethers-simple-storage/deploy.js:25:1)
at Module._compile (node:internal/modules/cjs/loader:1226:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1280:10)
at Module.load (node:internal/modules/cjs/loader:1089:32)
at Module._load (node:internal/modules/cjs/loader:930:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:23:47
'''

I found a thread that said if i change ethers version to 5.7.2 via 'yarn add ethers@5.7.2' it would solve the problem. However I got a new error message as follows:
'''solidity
Error: invalid private key (argument="privateKey", value="[[ REDACTED ]]", code=INVALID_ARGUMENT, version=signing-key/5.7.0)
at Logger.makeError (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/logger/lib/index.js:238:21)
at Logger.throwError (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/logger/lib/index.js:247:20)
at Logger.throwArgumentError (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/logger/lib/index.js:250:21)
at new SigningKey (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/signing-key/lib/index.js:22:20)
at new Wallet (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/wallet/lib/index.js:120:36)
at main (/home/ben_hudson/hh-fcc/ethers-simple-storage/deploy.js:11:18)
at Object. (/home/ben_hudson/hh-fcc/ethers-simple-storage/deploy.js:25:1)
at Module._compile (node:internal/modules/cjs/loader:1226:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1280:10)
at Module.load (node:internal/modules/cjs/loader:1089:32) {
reason: 'invalid private key',
code: 'INVALID_ARGUMENT',
argument: 'privateKey',
value: '[[ REDACTED ]]'
}
'''

My deploy.js code is as follows:
'''solidity
const ethers = require("ethers"); // const means can't change ethers. require just imports it
const fs = require("fs-extra");

async function main() {
// compile them in our code
// compile them separately
// http://127.0.0.1:7545
const provider = new ethers.providers.JsonRpcProvider(
"http://127.0.0.1:7545"
);
const wallet = new ethers.Wallet(
"0xe8ad750Af9798aA836d9751845afB2577e33aF10",
provider
);
const abi = fs.readFileSync("./SimpleStorage_sol_SimpleStorage.abi", "utf8");
const binary = fs.readFileSync(
"./SimpleStorage_sol_SimpleStorage.abi",
"utf8"
);
const contractFactory = new ethers.ContractFactory(abi, binary, wallet); // used to deploy contract
console.log("Deploying, pleast wait...");
const contract = await ContractFactory.deploy(); // STEP here! Wait for contract to deploy --> "await"
console.log(contract);
}
main()
.then(() => process.exit(0))
.catch((error) => {
console.error(error);
process.exit(1);
});
'''

It seems to be a problem in index.js? Any help is much appreciated

Thanks

[AmitKochar1]

Have you installed ether dependencies? before using JsonRpcProvider
Also, JsonRpcProvider should be your local ganache server address.

I hope this helps.

[LimbicAutomaton]

Hi - see package.json below:
Also - the JsonRpcProvider is the local ganache server address

{
"dependencies": {
"ethers": "5.7.2",
"fs-extra": "^11.1.0",
"solc": "0.8.7-fixed"
},
"scripts": {
"compile": "yarn solcjs --bin --abi --include-path node_modules/ --base-path . -o . SimpleStorage.sol"
}
}

Thanks!

[AmitKochar1]

Perfect. The first argument below should be your key private key to the ganache account, not an address.

the first argument - 0xe8ad750Af9798aA836d9751845afB2577e33aF10 - this looks like an account address, instead you should put a private key of an account.

const wallet = new ethers.Wallet(
"0xe8ad750Af9798aA836d9751845afB2577e33aF10",
provider
);

[LimbicAutomaton]

Ahh.. Thanks. Silly mistake...

However once I fixed that I got a new error message:

Error: invalid bytecode (argument="bytecode", value="[{"inputs":[{"internalType":"string","name":"_name","type":"string"},{"internalType":"uint256","name":"_favoriteNumber","type":"uint256"}],"name":"addPerson","outputs":[],"stateMutability":"nonpayable","type":"function"},{"inputs":[{"internalType":"string","name":"","type":"string"}],"name":"nameToFavoriteNumber","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"uint256","name":"","type":"uint256"}],"name":"people","outputs":[{"internalType":"uint256","name":"favoriteNumber","type":"uint256"},{"internalType":"string","name":"name","type":"string"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"retrieve","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"uint256","name":"_favoriteNumber","type":"uint256"}],"name":"store","outputs":[],"stateMutability":"nonpayable","type":"function"}]", code=INVALID_ARGUMENT, version=contracts/5.7.0)
at Logger.makeError (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/logger/lib/index.js:238:21)
at Logger.throwError (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/logger/lib/index.js:247:20)
at Logger.throwArgumentError (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/logger/lib/index.js:250:21)
at new ContractFactory (/home/ben_hudson/hh-fcc/ethers-simple-storage/node_modules/@ethersproject/contracts/lib/index.js:1082:20)
at main (/home/ben_hudson/hh-fcc/ethers-simple-storage/deploy.js:20:27)
at Object. (/home/ben_hudson/hh-fcc/ethers-simple-storage/deploy.js:25:1)
at Module._compile (node:internal/modules/cjs/loader:1226:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1280:10)
at Module.load (node:internal/modules/cjs/loader:1089:32)
at Module._load (node:internal/modules/cjs/loader:930:12) {
reason: 'invalid bytecode',
code: 'INVALID_ARGUMENT',
argument: 'bytecode',
value: '[{"inputs":[{"internalType":"string","name":"_name","type":"string"},{"internalType":"uint256","name":"_favoriteNumber","type":"uint256"}],"name":"addPerson","outputs":[],"stateMutability":"nonpayable","type":"function"},{"inputs":[{"internalType":"string","name":"","type":"string"}],"name":"nameToFavoriteNumber","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"uint256","name":"","type":"uint256"}],"name":"people","outputs":[{"internalType":"uint256","name":"favoriteNumber","type":"uint256"},{"internalType":"string","name":"name","type":"string"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"retrieve","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"uint256","name":"_favoriteNumber","type":"uint256"}],"name":"store","outputs":[],"stateMutability":"nonpayable","type":"function"}]'
}

Appreciate your patience !

[mikakort]

I got the same one, no idea where I have to go from here

[Beavnvvv]

const binary = fs.readFileSync(
"./SimpleStorage_sol_SimpleStorage.abi",
"utf8"

It's not abi, it's bin You're a bit careless

[AmitKochar1]

it seems like something is not right with your solidity code, can you compile your code first and see if you coming across any issues there? It will be helpful if you can paste your solidity code here.

[LimbicAutomaton]

Hi - solidity code is a direct copy from the repository.. I accidently closed remix:
''' solidity
// I'm a comment!
// SPDX-License-Identifier: MIT

pragma solidity 0.8.7;

// pragma solidity ^0.8.0;
// pragma solidity >=0.8.0 <0.9.0;

contract SimpleStorage {
uint256 favoriteNumber;

struct People {
    uint256 favoriteNumber;
    string name;
}
// uint256[] public anArray;
People[] public people;

mapping(string => uint256) public nameToFavoriteNumber;

function store(uint256 _favoriteNumber) public {
    favoriteNumber = _favoriteNumber;
}

function retrieve() public view returns (uint256) {
    return favoriteNumber;
}

function addPerson(string memory _name, uint256 _favoriteNumber) public {
    people.push(People(_favoriteNumber, _name));
    nameToFavoriteNumber[_name] = _favoriteNumber;
}

}
'''
Thanks !

[LimbicAutomaton]

The SimpleStorage contract deploys with no issues in remix also ...

[AmitKochar1]

I think it's something to do with your abi or binary files. I am not entirely sure what the issue is. However, I will recommend closing this issue, and opening a new issue with a current issue.

Maybe try the recommendation here - #4703 (comment)