Lesson 3 : Error Invalid big number string

[hust93]

i followed lesson 3 exactly as the video, and i even copied and paste the code from git repo to double check my typos, but after i deploy to StorageFactory whenever i try any command i get these :

call to StorageFactory.simpleStorageArray errored: Error encoding arguments: Error: invalid BigNumber string (argument="value", value="", code=INVALID_ARGUMENT, version=bignumber/5.5.0)

call to StorageFactory.sfGet errored: Error encoding arguments: Error: invalid BigNumber string (argument="value", value="", code=INVALID_ARGUMENT, version=bignumber/5.5.0)

transact to StorageFactory.sfStore errored: Error encoding arguments: Error: invalid BigNumber string (argument="value", value="", code=INVALID_ARGUMENT, version=bignumber/5.5.0)

Help please ?

[pacelliv]

Hi @hust93 it seems you're passing an empty string and not an index as an argument, can you send a screenshot of how you're calling the function? That might help me to spot the issue.

[hust93]

pragma solidity ^0.8.7;

import "./SimpleStorage.sol";

contract StorageFactory {

SimpleStorage[] public simpleStorageArray;

function createSimpleStorageContract() public {
    SimpleStorage simpleStorage = new SimpleStorage();
    simpleStorageArray.push(simpleStorage);
}

function sfStore(uint256 _simpleStorageIndex, uint256 _simpleStorageNumber) public {
    // Address 
    // ABI 
    // SimpleStorage(address(simpleStorageArray[_simpleStorageIndex])).store(_simpleStorageNumber);
    simpleStorageArray[_simpleStorageIndex].store(_simpleStorageNumber);
}

function sfGet(uint256 _simpleStorageIndex) public view returns (uint256) {
    // return SimpleStorage(address(simpleStorageArray[_simpleStorageIndex])).retrieve();
    return simpleStorageArray[_simpleStorageIndex].retrieve();
}

}

its the exact code from github , maybe it has something to do with simplestorage code of mine ? ill share that one as well down below :

pragma solidity ^0.8.8;

contract SimpleStorage {

uint256 favoriteNumber; 

struct People {
string name;
uint256 favoriteNumber;
}

People[] public people;

function store(uint256 _favoriteNumber) public {
    favoriteNumber = _favoriteNumber; 
}

function retrieve() public view returns(uint256){
    return favoriteNumber; 
}

mapping(string => uint256) public nameToFavoriteNumber; 

function addPerson (string memory _name, uint256 _favoriteNumber) public {
    People memory newPerson = People({name: _name, favoriteNumber: _favoriteNumber});
    people.push(newPerson); // note People referring to the struct name, people is the array value. 
    nameToFavoriteNumber[_name] = _favoriteNumber; 
}

}

[pacelliv]

Sorry for the long wait, I think I have an idea of what's happening. To correctly invoke the sfStore function, you need to pass the arguments (index of a contract, number to store) to the function like this:

Both numbers are separated by a comma, then I can get the stored number in any contract by passing a valid index to the sfGet function and as well to the array SimpleStorage[] .

Probably you're only passing one argument to the sfStore function and by doing that you'll get the errors you're getting.

[hust93]

oh ok ay thanks ! , just just to make sure, my code has no bugs or flaws right? cause i created this discussion in order to understand if i have to watch for mistakes during my coding journey :)

[pacelliv]

It has no bugs.