lecture 7 ,testing

[haris4121]

after testing i am not able to pass fund function but in lecture it is passing and the error i am getting is below

/*.  error */

1) FundMe
       fund
         fails if we dont send enough eth:
     AssertionError: Expected transaction to be reverted with reason 'You need to spend more eth', but it reverted with reason 'You need to spend more ETH!'
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at runNextTicks (node:internal/process/task_queues:65:3)
      at listOnTimeout (node:internal/timers:528:9)
      at processTimers (node:internal/timers:502:7)
      at Context.<anonymous> (test/unit/FundMe.test.js:30:13)



error Command failed with exit code 1.

if i use

await expect(fundMe.fund()).to.be.reverted

then i pass the test

/*.  test.  */

describe("fund", async function() {
        it("fails if we dont send enough eth", async () => {
            await expect(fundMe.fund()).to.be.revertedWith(
                "You need to spend more eth"
            )
        })
    })

[pacelliv]

Hello @haris4121, the issue seems to be the messages. In your contract you specified that you will revert the transaction with: "You need to spend more ETH!", but in your test you expect to revert with: "You need to spend more eth", which are two completed different strings.

[haris4121]

still not working even after copying test from repo .
but it is working with .

await expect(fundMe.fund()).to.be.reverted

[rin-st]

please recheck your error message in your contract and in your test

[pacelliv]

hmmm weird, the error message is very clear in the root of the problem. Can you share with us a snippet of the fund function?

[haris4121]

here is the snippet but but this issue is still unresolved due to recent update in hardhat , although i we have custom error like for withdraw fucntion .

error FundMe__NotOwner();

then we can use

await expect(
                fundMeConnectedContract.withdraw()
            ).to.be.revertedWithCustomError(
                fundMeConnectedContract,
                "FundMe__NotOwner"
            )

here is the snippet of fundme

// SPDX-License-Identifier: MIT
/* using nas stling guide*/
pragma solidity ^0.8.8;
import "./PriceConverter.sol";
error FundMe__NotOwner();

/**@title A contract for crowd funding
 * @author haris rashid
 * @notice this is demo for sample funding contract
 * @dev this implements PriceConverter as library
 */

contract FundMe {
    using PriceConverter for uint256;

    mapping(address => uint256) public addressToAmountFunded;
    address[] public funders;
    address public immutable i_owner;
    uint256 public constant MINIMUM_USD = 50 * 10 ** 18;
    AggregatorV3Interface public PriceFeed;

    modifier onlyOwner() {
        if (msg.sender != i_owner) revert FundMe__NotOwner();
        _;
    }

    constructor(address PriceFeedAdress) {
        i_owner = msg.sender;
        PriceFeed = AggregatorV3Interface(PriceFeedAdress);
    }

    function fund() public payable {
        require(
            msg.value.getConversionRate(PriceFeed) >= MINIMUM_USD,
            "You need to spend more ETH!"
        );
        addressToAmountFunded[msg.sender] += msg.value;
        funders.push(msg.sender);
    }

    function withdraw() public onlyOwner {
        for (
            uint256 funderIndex = 0;
            funderIndex < funders.length;
            funderIndex++
        ) {
            address funder = funders[funderIndex];
            addressToAmountFunded[funder] = 0;
        }
        funders = new address[](0);

        (bool callSuccess, ) = payable(msg.sender).call{
            value: address(this).balance
        }("");
        require(callSuccess, "Call failed");
    }
}

[pacelliv]

I see no syntax error, run yarn hardhat clean to clean the artifacts folder, compile again and run the test one more time.