Lesson 9: timeout staging test

[chiesa]

Hi,

I finished the lessons 9 and everything seem to work.
I made all the deployment and the local tests without problems.
When I try to do the test in staging on Goerli network I get this error:

I tried different deploy, this is the last one:

I can see was called the "RequestLotteryWinner" event on goerli etherscan: https://goerli.etherscan.io/address/0x9401C6695D947b85b0711eC9b5522b488a04dD52

I don't understand why fulfillRandomWords function isn't called or never return the event "winnerPick".
Here you can see my git repo: https://github.com/chiesa/Studio-di-Solidity/tree/main/Lottery
contract: https://github.com/chiesa/Studio-di-Solidity/blob/main/Lottery/contracts/Lottery.sol
deploy: https://github.com/chiesa/Studio-di-Solidity/blob/main/Lottery/deploy/deploy.js
staging test: https://github.com/chiesa/Studio-di-Solidity/blob/main/Lottery/test/staging/lottery.staging.test.js
and all the other file in the repo.

I configured the VRF and got the Subscription and added the costumer:

I also setted the upkeep:

Do you see what I'm doing wrong or some advice?

Thanks a lot.
Samuele

[chiesa]

Is it possible that such issue arise because I don't have enough gETH on my account?

[deep0072]

i am also facing same issue

[chiesa]

I fund a solution:

there wasn't enough LINK in VFR Subscription. I added 20LINK and now everything works.
Try to check if it works also for you!

[deep0072]

What about the balance in other chainlink automation account

…

On Wed, Nov 2, 2022, 22:24 chiesa ***@***.***> wrote: I fund a solution: [image: immagine] <https://user-images.githubusercontent.com/26421691/199551694-b6ef2626-e675-4db8-99ce-fb41dfde716c.png> there wasn't enough LINK in VFR Subscription. I added 20LINK and now everything works. Try to check if it works also for you! — Reply to this email directly, view it on GitHub <#3627 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCGNSARQF42NR6FQHQVDULWGKMDTANCNFSM6AAAAAARVGMOXU> . You are receiving this because you commented.Message ID: <smartcontractkit/full-blockchain-solidity-course-js/repo-discussions/3627/comments/4039995 @github.com>

[chiesa]

I started there with 5 LINK. This is now:

[deep0072]

Well mine still not working. Link balance more than 20 link

…

On Thu, Nov 3, 2022, 14:48 chiesa ***@***.***> wrote: I started there with 5 LINK. This is now: [image: immagine] <https://user-images.githubusercontent.com/26421691/199684587-559dbe5a-16a2-46dd-bc94-4e0bc71f830e.png> — Reply to this email directly, view it on GitHub <#3627 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCGNSD2N6UW4NDNOTSLHFDWGN7MZANCNFSM6AAAAAARVGMOXU> . You are receiving this because you commented.Message ID: <smartcontractkit/full-blockchain-solidity-course-js/repo-discussions/3627/comments/4045136 @github.com>

[deep0072]

https://github.com/deep0071/lottery/tree/master/smartContract-Lottery
please check this

[pacelliv]

A. In the contract:

A.1. Make checkUpkeep public view override

A.2. At the end of checkUpkeep add:

return (upKeepNeeded, "0x0");

A.3. Inside fulfillRandomWords make the address payable:

address payable recentWinner = s_players[indexOfWinner];

B. In Raffle.staging.test.js

Apparently the event wasn't being picked up by the test because you were asking for the balance of the winner before entering the raffle, so rearrange your test to look like this:

console.log("Entering Raffle...");
const tx = await raffle.enterRaffle({ value: raffleEntranceFee });
await tx.wait(1);
console.log("time to wait now");
const winnerStartingBalance = await accounts[0].getBalance();
//console.log(winnerStartingBalance);

Remember these changes will create a new contract so you will have to add it as a new consumer and create a new upkeep.

It should pass now!

[chiesa]

I don't think you really need to make the modify A.1 and A.2.
Also if you did a local test and everything works, you dont need A.3. But I think you need it

you have to make the change B.
@pacelliv great work.

[pacelliv]

@chiesa thanks, I noticed that this test is running slow it takes many minutes for the test to pass... could this be due to the versions of the dependencies in the package.json file ?

[deep0072]

const { network, getNamedAccounts, ethers } = require("hardhat");
const { developmentChains } = require("../../helper-hardhat-config");

developmentChains.includes(network.name)
  ? describe.skip
  : describe("Raffle staging test", function () {
      let raffle, raffleInerval, deployer, raffleEntranceFee;
      beforeEach(async function () {
        deployer = (await getNamedAccounts()).deployer;
        raffle = await ethers.getContract("Raffle", deployer);
        raffleInerval = await raffle.getInterval();
        raffleEntranceFee = await raffle.getEntranceFee();
      });

      describe("fulfillRandomwords", () => {
        it("works with chainlink keeper, chainlink vrf", async () => {
          const startingTimestamp = await raffle.getLatestTimeStamp();
          const accounts = await ethers.getSigners();
          await new Promise(async (resolve, reject) => {
            raffle.once("winnerPicked", async () => {
              console.log("winner picked");

              try {
                const recentWinner = await raffle.getRecentWinner();

                const raffleState = await raffle.getRaffleState();
                const winnerEndingBalance = await accounts[0].getBalance();
                const endingTimeStamp = await raffle.getLatestTimeStamp();
                // now check players length is zero

                await expect(raffle.getPlayer(0)).to.be.reverted;
                assert.equal(recentWinner.toString(), accounts[0].address);
                assert.equal(raffleState, 0);
                assert.equal(
                  winnerEndingBalance.toString(),
                  winnerStartingBalance.add(raffleEntranceFee).toString()
                );

                assert(endingTimeStamp > startingTimestamp);
                resolve();
              } catch (error) {
                console.log(error);
                reject(error);
              }
            });

            const tx = await raffle.enterRaffle({ value: raffleEntranceFee });

            console.log(tx);
            await tx.wait(1);
            console.log("time to wait now");
            const winnerStartingBalance = await accounts[0].getBalance();
            console.log(winnerStartingBalance);
          });
        });
      });
    });
``` well it still stucks

[deep0072]

Have you run that shared code?

…

On Fri, Nov 4, 2022, 19:21 pacelliv ***@***.***> wrote: @chiesa <https://github.com/chiesa> thanks, I noticed that this test is running slow it takes many minutes for the test to pass... could this be due to the versions of the dependencies in the package.json file ? — Reply to this email directly, view it on GitHub <#3627 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCGNSAPENW6CNNLKU5M4GTWGUIE5ANCNFSM6AAAAAARVGMOXU> . You are receiving this because you commented.Message ID: <smartcontractkit/full-blockchain-solidity-course-js/repo-discussions/3627/comments/4057090 @github.com>

[pacelliv]

Yes, I ran it, the test passed and I verified in Etherscan that I entered the Raffle, the VRF Request was made (performUpkeep and fulfillRandomWords were called by the Chainlink nodes) and the prize sent to my wallet.

[deep0072]

Without changing any code?

…

On Fri, Nov 4, 2022, 19:27 pacelliv ***@***.***> wrote: Yes, I ran it, the test passed and I verified in Etherscan that I entered the Raffle, the VRF Request was made (performUpkeep and fulfillRandomWords were called by the Chainlink nodes) and the prize sent to my wallet. — Reply to this email directly, view it on GitHub <#3627 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCGNSHXZT7LY46G5SDJCQTWGUI4RANCNFSM6AAAAAARVGMOXU> . You are receiving this because you commented.Message ID: <smartcontractkit/full-blockchain-solidity-course-js/repo-discussions/3627/comments/4057143 @github.com>

[pacelliv]

Yes, I made three changes, if you look above you will see them. Like @chiesa said you could ignore A.1 and A.2., but without modifying the the staging test I don't think the test will pass.

[deep0072]

https://github.com/deep0071/lottery please check i have done changes but still it is stuck in stage testing

[deep0072]

well my mistake was that i registered in chainlink keeper using time based option. but now i registered using custom based logic. but now new error coming. AssertionError: expected '345593590257924432' to equal '345770912272949262

…

On Fri, 4 Nov 2022 at 19:35, pacelliv ***@***.***> wrote: Yes, I made three changes, if you look above you will see them. Like @chiesa <https://github.com/chiesa> said you could ignore A.1 and A.2., but without modifying the the staging test I don't think the test will pass. — Reply to this email directly, view it on GitHub <#3627 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCGNSASRJ4DOLWHJLZPYC3WGUJ3TANCNFSM6AAAAAARVGMOXU> . You are receiving this because you commented.Message ID: <smartcontractkit/full-blockchain-solidity-course-js/repo-discussions/3627/comments/4057217 @github.com>

[jvargas2319]

Here is my staging code.

`
const { assert, expect } = require("chai")
const { getNamedAccounts, ethers, network } = require("hardhat")
const { developmentChains } = require("../../helper-hardhat-config")

              developmentChains.includes(network.name)
                  ? describe.skip
                  : describe("Raffle Staging Tests", function () {
                        let raffle, raffleEntranceFee, deployer
              
                        beforeEach(async function () {
                            deployer = (await getNamedAccounts()).deployer
                            raffle = await ethers.getContract("Raffle", deployer)
                            raffleEntranceFee = await raffle.getEntranceFee()
                       
                        })
              
                        describe("fulfillRandomWords", function () {
                            it("works with live Chainlink Keepers and Chainlink VRF, we get a random winner", async function () {
                                // enter the raffle
                                console.log("Setting up test...")
                                const startingTimeStamp = await raffle.getLastTimeStamp()
                                const accounts = await ethers.getSigners()
              
                                console.log("Setting up Listener...")
                                await new Promise(async (resolve, reject) => {
                                    // setup listener before we enter the raffle
                                    // Just in case the blockchain moves REALLY fast
                                    raffle.once("WinnerPicked", async () => {
                                        console.log("WinnerPicked event fired!")
                                        try {
                                            // add our asserts here
                                            const recentWinner = await raffle.getRecentWinner()
                                            const raffleState = await raffle.getRaffleState()
                                            const winnerEndingBalance = await accounts[0].getBalance()
                                            const endingTimeStamp = await raffle.getLastTimeStamp()
              
                                            await expect(raffle.getPlayer(0)).to.be.reverted
                                            assert.equal(recentWinner.toString(), accounts[0].address)
                                            assert.equal(raffleState, 0)
                                            assert.equal(
                                                winnerEndingBalance.toString(),
                                                winnerStartingBalance.add(raffleEntranceFee).toString()
                                            )
                                            assert(endingTimeStamp.toString() > startingTimeStamp.toString())
                                            resolve()
                                        } catch (error) {
                                            console.log(error)
                                            reject(error)
                                        }
                                    })
                                    // Then entering the raffle
                                    console.log("Entering Raffle...")
                                    const tx = await raffle.enterRaffle({ value: raffleEntranceFee })
                                    await tx.wait(1)
                                    console.log("Ok, time to wait...")
                                    const winnerStartingBalance = await accounts[0].getBalance()
              
                                    // and this code WONT complete until our listener has finished listening!
                                })
                            })
                        })
                    })

`

[pacelliv]

I see not syntax error so it seems to be the transaction for enterRaffle is not being mined on time and the test moves forward without adding raffleEntranceFee or some gas cost is not being included in winnerStartingBalance, resulting in a fail assertion. Increase the number of block confirmations to await tx.wait(2) to see if the transaction is mined.

Also, the test will consume more time so make sure the mocha timeout in hardhat.config is at least 500000 ms.

If this doesn't help push the code to GitHub and leave a link.

[jvargas2319]

ahh ok I will try that out. Thank you for your again.

[bagariaraj23]

hi @pacelliv @jvargas2319 even i'm getting a similar error

AssertionError: expected '384993087196025164' to equal '395027624697061289'
      + expected - actual

      -384993087196025164
      +395027624697061289

How did you debug the code ? Please help me out!

[pacelliv]

Hello @bagariaraj23, the last couple of weeks I've seen many issues with the staging test of this lesson on goerli. Out of curiosity I ran my code and it gave me this error and then it didn't gave me the result of the assertion, but in etherscan all goes well.

Sometimes working on goerli gets like this and it can get very frustrating. For now as long as you see that in etherscan all goes well, just leave it like that, continue the course and come back later or you can deploy to mumbai and run the test in that network.

[deep0072]

stage testing is done successfully. thanks for the cooprating

…

On Sat, 5 Nov 2022 at 23:36, pacelliv ***@***.***> wrote: Hmmm... I see... I'll look into it later. Please try to reply in the same thread (don't create new comments) and avoid jumping between discussions otherwise it'll become confusing. — Reply to this email directly, view it on GitHub <#3627 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCGNSFABUUJAXP2Y34ISL3WG2O2DANCNFSM6AAAAAARVGMOXU> . You are receiving this because you commented.Message ID: <smartcontractkit/full-blockchain-solidity-course-js/repo-discussions/3627/comments/4065158 @github.com>

[pacelliv]

Great! Good to know it's working!

[chopperttt]

mine still doesnt work after checking all the related threads and fixes, can someone help?
my repo: https://github.com/AnneBBB/hardhat-smartcontract-lottery-fcc