lesson 9 unit testing InvalidSubscription() error

[novajosky]

when running the unit test
yarn hardhat test --grep "doesn't allow entrance when raffle is calculating"
I ran into this error. I found an earlier discussion where the solution was to reinstall @chainlink/contracts but that did not fix the issue

  1) Raffle Unit Tests
       enterRaffle
         doesn't allow entrance when raffle is calculating:
     Error: VM Exception while processing transaction: reverted with custom error 'InvalidSubscription()'
    at VRFCoordinatorV2Mock.requestRandomWords (@chainlink/contracts/src/v0.8/mocks/VRFCoordinatorV2Mock.sol:112)
    at Raffle.performUpkeep (contracts/Raffle.sol:138)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at runNextTicks (node:internal/process/task_queues:64:3)
    at listOnTimeout (node:internal/timers:533:9)
    at processTimers (node:internal/timers:507:7)
    at HardhatNode._mineBlockWithPendingTxs (node_modules/hardhat/src/internal/hardhat-network/provider/node.ts:1802:23)
    at HardhatNode.mineBlock (node_modules/hardhat/src/internal/hardhat-network/provider/node.ts:491:16)
    at EthModule._sendTransactionAndReturnHash (node_modules/hardhat/src/internal/hardhat-network/provider/modules/eth.ts:1522:18)

Below is the file

const { assert, expect } = require("chai")
const { deployments, ethers, network } = require("hardhat")
const { developmentChains, networkConfig } = require("../../helper-hardhat-config")

!developmentChains.includes(network.name)
    ? describe.skip
    : describe("Raffle Unit Tests", async function () {
          let raffle, vrfCoordinatorV2Mock, raffleEntranceFee, deployer, interval
          const chainId = network.config.chainId

          beforeEach(async function () {
              deployer = (await getNamedAccounts()).deployer
              await deployments.fixture(["all"])
              raffle = await ethers.getContract("Raffle", deployer)
              vrfCoordinatorV2Mock = await ethers.getContract("VRFCoordinatorV2Mock", deployer)
              raffleEntranceFee = await raffle.getEntranceFee()
              interval = await raffle.getInterval()
          })

          describe("constructor", async function () {
              it("initializes the raffle correctly", async function () {
                  const raffleState = await raffle.getRaffleState()
                  assert.equal(raffleState.toString(), "0")
                  assert.equal(interval.toString(), networkConfig[chainId]["interval"])
              })
          })

          describe("enterRaffle", async function () {
              it("reverts when you don't pay enough", async function () {
                await expect(raffle.enterRaffle()).to.be.revertedWith("Raffle__SendMoreToEnterRaffle")
              })
              it("records players when they enter", async function () {
                await raffle.enterRaffle({ value: raffleEntranceFee })
                const playerFromContract = await raffle.getPlayer(0)
                assert.equal(playerFromContract, deployer)
              })
              it("emits event on enter", async function () {
                await expect(raffle.enterRaffle({value: raffleEntranceFee})).to.emit(raffle, "RaffleEnter")
              })
              it("doesn't allow entrance when raffle is calculating", async function () {
                await raffle.enterRaffle({value: raffleEntranceFee })
                await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                await network.provider.send("evm_mine", [])
                // simulate Chainlink keeping
                await raffle.performUpkeep([])
                await expect(raffle.enterRaffle({ value: raffleEntranceFee })).to.be.revertedWith("Raffle__RaffleNotOpen")
              })
          })
      })

[pacelliv]

I don't see any error, push your code to GitHub and leave a link. I'll give it a look in a couple of hours.

[novajosky]

thank you for your help!

https://github.com/novajosky/smartcontract

[pacelliv]

The problem is in the order of the arguments pass from 01-raffle-deploy.js to the constructor, the order should match, this is the correct order:

    const args = [
        vrfCoordinatorV2Address,
        subscriptionId,
        gasLane,
        interval,
        entranceFee,
        callbackGasLimit,
    ]

With this your test should pass.

A side note: I noticed that in both your helper-hardhat-config and hardhat-config you specified the chainId as 3 for Göerli but the correct number is 5, this is something you should change to avoid errors.

[novajosky]

i appreciate it! thanks for pointing that out! Unit tests passed with no issues!

[pacelliv]

All right! I'm glad I helped!

[Benrockiee]

Did u run the right command?

Most people used
yarn add@chainlink/contracts

instead of adding a dev dependency on it and changing the version..
yarn add --dev @chainlink/contracts@^0.4.1

[novajosky]

i tried all the commands. thanks for your help!