Lesson 7: 11:20:38 -> TypeError: ethers.getContract is not a function

[DorianDaSilva]

AssertionError: Expected transaction to be reverted with You need to spend more ETH!, but other exception was thrown: Error: Transaction reverted: function returned an unexpected amount of data

I was getting this error when runinning test for fundMe() around 11:20:38 of the video

describe("FundMe", async function () {
  let fundMe;
  let deployer;
  let MockV3Aggregator;
  beforeEach(async function () {
    deployer = (await getNamedAccounts()).deployer;
    await deployments.fixture(["all"]);
    fundMe = await ethers.getContract("FundMe", deployer);
    MockV3Aggregator = await ethers.getContract("MockV3Aggregator", deployer);
  });

  describe("constructor", async function () {
    it("sets the aggregator addresses correctly", async function () {
      const response = await fundMe.priceFeed();
      assert.equal(response, MockV3Aggregator.address);
    });
  });
  describe("fund", async function () {
    it("Fails if you don't send enough ETH", async function () {
      await expect(fundMe.fund()).to.be.revertedWith(
        "You need to spend more ETH!"
      );
    });
  });
});

After some research it seemed that the issue could ber esolved by downloading @nomicslabs/hardhat-waffle from hardhat docs
[https://hardhat.org/plugins/nomiclabs-hardhat-waffle]

But after running the install I now get the following error running the above test

  1) FundMe
       "before each" hook for "sets the aggregator addresses correctly":
     TypeError: ethers.getContract is not a function

Any ideas of what could be the issue here? thank you!

[DorianDaSilva]

yarn add hardhat --dev @nomiclabs/hardhat-ethers@npm:hardhat-deploy-ethers ethers
Ran this again and fixed the issue.

Now test 1 passes but test returns the following error when it gets to
await expect(fundMe.fund()).to.be.revertedWith("You need to spend more ETH!");

ERROR:

  1) FundMe
       fund
         Fails if you don't send enough ETH:
     AssertionError: Expected transaction to be reverted with You need to spend more ETH!, but other exception was thrown: Error: Transaction reverted: function returned an unexpected amount of data

[gmluqa]

It's been a while since I was on lesson 7, in my code the line reads like this await expect(fundMe.fund()).to.be.reverted I don't know if that would make any difference.

Do your imports look similar to this? (There may be extra ones I included since I fully finished that lesson)

const { deployments, ethers, getNamedAccounts } = require("hardhat")
const { assert, expect } = require("chai")
const { developmentChains } = require("../../helper-hardhat-config")

[gmluqa]

Seems like it's not that line specifically, I added the same thing you have and it worked fine for me:

EDIT:
Seems like it was that line since you were able to solve it by changing it

[PatrickAlphaC]

@gmluqa if you'd like to make a new canonical answer I'll mark that one as correct!

[DorianDaSilva]

@gmluqa Thank you so much for taking the time to share your answer. Your solution worked.

I tried to modify the line so it reads like yours
await expect(fundMe.fund()).to.be.reverted

Both tests seem to pass that way as you can see below

So it is definitely the line but I still don't understand why adding the string causes the error, maybe I am missing a parameter or an import.

[gmluqa]

Do you have require("@nomiclabs/hardhat-waffle") in your hardhat.config.js?
From reading documentation (https://ethereum-waffle.readthedocs.io/en/latest/matchers.html#revert-with-message) it would seem that waffle is the module that enables the functionality of string errors + revert.

[DorianDaSilva]

@gmluqa Yes, I have all the required plugins. Not sure why I am getting those errors

[gmluqa]

As @PatrickAlphaC said, here is a cannonical answer seperated from the reply section.

Error fixed by adding await expect(fundMe.fund()).to.be.reverted instead of previous code although still are figuring out why it can't work without .revertedWith("error");

[shailu2006]

Thank you @gmluqa ! In my case installing the dependencies did the trick

yarn add hardhat --dev @nomiclabs/hardhat-ethers@npm:hardhat-deploy-ethers ethers