lesson-14 dynamicNFT error

[TimeKeyRoll]

Could i get some help please?

contract

// SPDX-License-Identifier:MIT;
pragma solidity ^0.8.7;
/**
 * @author we will change `svg` to `base64`
 * and can be used `onChain` for `image Uri`.
 */

import "@openzeppelin/contracts/token/ERC721/ERC721.sol";
import "base64-sol/base64.sol";
import "hardhat/console.sol";
import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol";
import "@openzeppelin/contracts/access/Ownable.sol";

contract DynamicSvgNft is ERC721 {
    uint256 private s_tokenCounter;
    string private i_lowImageURI;
    string private i_highImageURI;
    string private constant base64EncodedSvgPrefix =
        "data:image/svg+xml;base64,";
    AggregatorV3Interface internal immutable i_priceFeed;
    mapping(uint256 => int256) public s_tokenIdToHighValues;

    // event CreatedNFT(uint256 indexed tokenId, int256 highValue);
    event CreatedNFT(uint256 indexed tokenId, int256 highValue);

    constructor(
        address priceFeedAddress,
        string memory lowSvg,
        string memory highSvg
    ) ERC721("Dynamic SVG NFT", "DSN") {
        s_tokenCounter = 0;
        i_lowImageURI = svgToImageURI(lowSvg);
        i_highImageURI = svgToImageURI(highSvg);
        i_priceFeed = AggregatorV3Interface(priceFeedAddress);
    }

    function svgToImageURI(string memory svg)
        public
        pure
        returns (string memory)
    {
        string memory svgBase64Encoded = Base64.encode(
            bytes(string(abi.encodePacked(svg)))
        );
        return
            string(abi.encodePacked(base64EncodedSvgPrefix, svgBase64Encoded));
    }

    function mintNft() public {
        s_tokenIdToHighValues[s_tokenCounter] = highValue;
        _safeMint(msg.sender, s_tokenCounter);
        s_tokenCounter = s_tokenCounter + 1;
        //emit CreatedNFT(s_tokenCounter, highValue);
        emit CreatedNFT(s_tokenCounter, highValue);
    }

    function _baseURI() internal pure override returns (string memory) {
        return "data:application/json;base64,";
    }
function tokenURI(uint256 tokenId)
        public
        view
        override
        returns (string memory)
    {
        require(_exists(tokenId), "URI query for non-exisent token!");

        (, int256 price, , , ) = i_priceFeed.latestRoundData();
        string memory imageURI = i_lowImageURI;
        if (price >= s_tokenIdToHighValues[tokenId]) {
            imageURI = i_highImageURI;
        }
        return
            string(
                abi.encodePacked(
                    _baseURI(),
                    Base64.encode(
                        bytes(
                            abi.encodePacked(
                                '{"name": "',
                                name(),
                                '", "description":"AN NFT CHANGES BASED ON CHAINLINK FEED", ',
                                '"attributes": [{"trait_type": "coolness", "value":100}], "image":"',
                                imageURI,
                                '" }'
                            )
                        )
                    )
                )
            );
    }
}

[alymurtazamemon]

@TimeKeyRoll Make sure you have declared highValue variable in this file.

See the mintNft function signature should be like this;

function mintNft(int256 highValue) public

[0xpolarzero]

Exactly. And in this example we're not declaring this variable in the contract, but passing it as a parameter in the mintNft function.

So make sure to update your mintNft function so it takes highValue (which is a int256) as a parameter.

You will then need, in the mint script, to pass this value as a parameter when calling this function from the contract.

You can check the contract and the deploy script in the repo if you're not sure.

[TimeKeyRoll]

@TimeKeyRoll Make sure you have declared highValue variable in this file.

See the mintNft function signature should be like this;

function mintNft(int256 highValue) public

Killed my half day on this. Lol
Thanks man appreciate your response.

[TimeKeyRoll]

Exactly. And in this example we're not declaring this variable in the contract, but passing it as a parameter in the mintNft function.

So make sure to update your mintNft function so it takes highValue (which is a int256) as a parameter.

You will then need, in the mint script, to pass this value as a parameter when calling this function from the contract.

You can check the contract and the deploy script in the repo if you're not sure.

Thanks @polar0 i will be taking care of this in future. Small silly mistakes gets in your nerves and then attack on your Guts.haha Thanks a ton for the explanation.

[0xpolarzero]

Exactly. And in this example we're not declaring this variable in the contract, but passing it as a parameter in the mintNft function.

So make sure to update your mintNft function so it takes highValue (which is a int256) as a parameter.

You will then need, in the mint script, to pass this value as a parameter when calling this function from the contract.

You can check the contract and the deploy script in the repo if you're not sure.

Thanks @polar0 i will be taking care of this in future. Small silly mistakes gets in your nerves and then attack on your Guts.haha Thanks a ton for the explanation.

You're welcome! That's indeed usually the case, and you end up spending hours missing the "obvious" mistake. 😅 Glad I could be of help!