Lesson 16: Two questions - upgrade-box.js script

[ManuWeb3]

Hey all,

1).
What exactly is the purpose of const proxyBoxV1 = await ethers.getContractAt("Box", transparentProxy.address) in the below script ?
And, again when this syntax was used for the second time for getContractAt(BoxV2, transparentProxy.address).

I know we use getContractAt() to return Promise(Contract) for which we input the ABI and the contract_address.

How can we load BoxV2's ABI at transparentProxy.address and what we're trying to achieve with that ?

I'm not able to understand what Patrick meant by the following:
"to work with the functions of BoxV2.sol, we're gonna give BoxV2.sol's ABI. However, we're gonna load it at transparentProxy.address"

upgrade-box.js

const { ethers } = require("hardhat")

async function main() {
    
    const boxProxyAdmin = await ethers.getContract("DefaultProxyAdmin")     
    const transparentProxy = await ethers.getContract("Box_Proxy")
    
    const proxyBoxV1 = await ethers.getContractAt("Box", transparentProxy.address)
    const versionV1 = await proxyBoxV1.version()
    console.log("Checking Box_version on transparentProxy.address")
    console.log(`Version: ${versionV1}`)

    const boxV2 = await ethers.getContract("BoxV2")
    const upgradeTx = await boxProxyAdmin.upgrade(transparentProxy.address, boxV2.address)
    await upgradeTx.wait(1)
    
    const proxyBoxV2 = await ethers.getContractAt("BoxV2", transparentProxy.address)
    const versionV2 = await proxyBoxV2.version()
    console.log("Post-upgradation...Checking Box_version on transparentProxy.address ")
    console.log(`Version: ${versionV2}`)
}

main()
.then(() => process.exit(0))
.catch((error) => {
    console.log(error)
    process.exit(1)
})

=====================

2).
How can we use transparentProxy.address as the first input parameter in the upgrade() ?
const upgradeTx = await boxProxyAdmin.upgrade(transparentProxy.address, boxV2.address)

I checked the syntax of upgrade() in ProxyAdmin.sol (below) and it takes TransparentUpgradeableProxy proxy as the argument which is a deployed instance (proxy) of TransparentUpgradeableProxy Smart Contract.

whereas we passed its address and Not the deployed instance and still it worked.

How ?

Syntax of upgrade()

function upgrade(TransparentUpgradeableProxy proxy, address implementation) public virtual onlyOwner {
        proxy.upgradeTo(implementation);
    }

=======================

[alymurtazamemon]

@ManuWeb3 Can you leave a timestamp?

[ManuWeb3]

Hey @alymurtazamemon ...

For 1). Timestamp- 01:05:41:46, when Patrick exactly explained the following:
"to work with the functions of BoxV2.sol, we're gonna give BoxV2.sol's ABI. However, we're gonna load it at transparentProxy.address"

Timestamp- 01:05:41:55 , when Patrick coded for BoxV2: getContractAt(BoxV2, transparentProxy.address) and right after this he coded for Box1: const proxyBoxV1 = await ethers.getContractAt("Box", transparentProxy.address)

==================

For 2). it's- 01:05:40:56 , coding boxProxyAdmin.upgrade(transparentProxy.address, boxV2.address)

P.S: I tried to embed the weblink of video @ these 2 timestamps so that you exactly reach there in the course but, somehow, I could not embed it correctly.
Sorry for that.

==================

Same situation I came across today in Lesson 17 @ 01:06:45:06 when GovernorContract's constructor expects the first 2 arguments to be of type ERC20Votes and TimelockController, Patrick again passed the address of GovernanceToken as governanceToken.address, and address of TimelockController as timeLock.address in args.........Why ?

In GovernorContract.sol, When the expected type of arguments is not the addresses of contracts, how come we're passing the addresses in the 03-deploy-governor-contract.js, below:

GovernorContract.sol

03-deploy-governor-contract.js

[ManuWeb3]

Hey @alymurtazamemon ...

Just wanted to check if you got chance to check this out. No rush.