lesson 9: checkUpkeep interval config

[lucasfernandes]

Hey guys,
Lesson 9 - The checkUpkeep function check if the block is greater than the interval, besides some other checks.
Once it's greater than interval and passed the other checks it will performUpkeep:

upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);

My question is:
After first winner is picked, as the interval is set on the deploy time and is immutable, how can I start a new lottery round without deploy the contract again?
Cuz if not, once we have a single player, this first player balance, blocktime hitting fast and will be greater than interval, then will perform the upkeep again.

Did I miss something?
Don't know if I need to increase the number of players, maybe increase the lottery balance check or let the interval time updatable.

Thanks in advance.

[alymurtazamemon]

@lucasfernandes

Yes, the i_interval is immutable but s_lastTimeStamp is not. i_interval we are setting through our deploy scripts is 30 and after every performUpkeep we are resetting s_lastTimeStamp = block.timestamp as we did in the constructor and as so with other variables we resetting them after performing performUpkeep function.

And we will never deploy the same contract again because it will never be the same, yes it is true that the code will be the same but also data, instances, and everything will be new for each deployed contract. So this can never happen that one contract redeploys every time for performing some functionality.

[krakxn]

You are confused b/w the properties (not referring to Solidity keywords here, but general terms) immutable and constant.

It is indeed true that the code of the contract, once deloyed, is immutable and cannot be changed. But, the state it holds, is subject to change and can be variable (i.e. not constant) if the logic of the code is so.

E.g. timePassed in this case is not constant--it varies; needless to say, the code (the logic) involving timePassed indeed is immutable, but its logic leads to a change in state for the variable timePassed. Put simply, everything in a contract is immutable but its state can be changed if designed so.

[lucasfernandes]

Hey guys, hi! Thanks for answer.
Ok, checked that the s_lastTimeStamp is being updated.
So in order to let the lottery last a bit more, should I increase the bool hasPlayers = (s_players.length > 0); / bool hasBalance = address(this).balance > 0; in the checkUpkeep verification?
I think I had this impression cuz the lottery ends so fast when testing on Goerli testnet.

[alymurtazamemon]

@lucasfernandes you should increase the interval from the helper file, it is set to 30.

[krakxn]

Have conditionals for the following state variables in checkUpkeep() to account for an increase in the duration of the Raffle.

Variables to change: 1. i_interval will inc. the duration irrespective of the no. of players; 2. s_players not dependent, but more players?

[lucasfernandes]

@alymurtazamemon Cool, will try increasing interval to test first, then maybe the players as well. Thanks!

[krakxn]

Good luck :)