Lesson 9 : Raffle deploy error.

[Cronk123]

I go to test the deploy scripts and my mocks deploy fine however there is an issue with the raffle code deploying. Attempted to diagnose it but remain unsure.

Deploy script code:

const { network } = require("hardhat");
const {
  developmentChains,
  networkConfig,
} = require("../helper-hardhat-config");
const { verify } = require("../helper-hardhat-config");

const VRF_SUB_AMOUNT = ethers.utils.parseEther("30");

module.exports = async function ({ getNamedAccounts, deployments }) {
  const { deploy, log } = deployments;
  const { deployer } = await getNamedAccounts();
  const { chainId } = network.config.chainId;
  let vrfCoordinatorV2Address, subsriptionId, vrfCoordinatorV2Mock;

  if (developmentChains.includes(network.name)) {
    const vrfCoordinatorV2Mock = await ethers.getContract(
      "VRFCoordinatorV2Mock"
    );
    vrfCoordinatorV2Address = vrfCoordinatorV2Mock.address;
    const transactionResponse = await vrfCoordinatorV2Mock.createSubscription();
    const transactionReciept = await transactionResponse.wait(1);
    subsriptionId = transactionReciept.events[0].args.subId;
    log("Subscription created successfully");
    // Subscription now exists via contract. Now need to fund the subscription
    // Mainnets need link token to fund SUB
    await vrfCoordinatorV2Mock.fundSubscription(subsriptionId, VRF_SUB_AMOUNT);
    log("Successfully Funded Subscription");
  } else {
    vrfCoordinatorV2Address = networkConfig[chainId]["vrfCoordinatorV2"];
    subsriptionId = networkConfig[chainId]["subscriptionId"];
  }

  const entranceFee = networkConfig[chainId]["entranceFee"];
  const gasLane = networkConfig[chainId]["gasLane"];
  const callbackGasLimit = networkConfig[chainId]["callbackGasLimit"];
  const interval = networkConfig[chainId]["interval"];
  const args = [
    vrfCoordinatorV2Address,
    entranceFee,
    gasLane,
    subsriptionId,
    callbackGasLimit,
    interval,
  ];
  const raffle = await deploy("Raffle", {
    from: deployer,
    args: args,
    log: true,
    waitConfirmations: 1,
  });

  if (
    !developmentChains.includes(network.name) &&
    process.env.ETHERSCAN_API_KEY
  ) {
    log("Verifying Contract Source Code...");
    await verify(raffle.address, args);
  }
  log("------------------------------------");
  log("Contract Deployed and Verified Successfully!");
};

module.exports.tags = ["all", `"raffle"];`

And the error code is as follows:

An unexpected error occurred:

Error: ERROR processing /Users/c/Desktop/Hard-Hat-Learning/hardhat-smartcontract-lottery/deploy/01-deploy-raffle.js:
TypeError: Cannot read properties of undefined (reading 'undefined')
    at Object.module.exports [as func] (/Users/c/Desktop/Hard-Hat-Learning/hardhat-smartcontract-lottery/deploy/01-deploy-raffle.js:34:36)

[krakxn]

Push to GitHub please

[ashrth]

@Cronk123 How are you verifying your script? Do you have the a folder named utils where you have created a file named verify.js? Because I see your are importing verify from helper.config. Also you have declared vrfCoordinatorV2Mock with let above and later you are using const with it.
See:

const vrfCoordinatorV2Mock = await ethers.getContract(
      "VRFCoordinatorV2Mock"
    );

this, in my opinion is not the best practice. Also I see backticks here module.exports.tags = ["all", `"raffle"];
Please try to modify these things and share your repo code so that I can look deeper into it.

[krakxn]

@Cronk123 Incorporate the fixes above.

@ashrth Just in case: to clarify, the reason why it is not a best practice is because it will lead to a DeclarationError; the reason is that if an identifer (variable) is already declared (e.g. let abc) it cannot be declared again (e.g. let abc or const abc following the previous one).

Declaration errors are syntactical errors which go against the syntax of most OOP languages; therefore, they have to be fixed in order to proceed.

[ashrth]

@Cronk123 Incorporate the fixes above.

@ashrth Just in case: to clarify, the reason why it is not a best practice is because it will lead to a DeclarationError; the reason is that if an identifer (variable) is already declared (e.g. let abc) it cannot be declared again (e.g. let abc or const abc following the previous one).

Declaration errors are syntactical errors which go against the syntax of most OOP languages; therefore, they have to be fixed in order to proceed.

Yes thank you @krakxn I was aware of it just didn't know the term.

[othaime-en]

Hey @Cronk123 First of all, there is a problem on line 13. Remove the {} on chainId. The line const { chainId } =network.config.chainId; should be const chainId = network.config.chainId;
I see the problem is coming from line 34. Make sure the entranceFee value is fetched correctly from your helper-hardhat-config.js If you feel it is okay, share a link to your github repo we'll help you look into it.
Another thing, you are fetching your verify function from helper-hardhat-config from sheer memory I'm guessing it should be in ../util/verify instead. Just check if you are fetching it correctly.
Third, as @ashrth has pointed out above, remove the backticks (``) in this line ["all", "raffle"];

[Cronk123]

@othaime-en

Helper Hardhat config file:
const { ethers } = require("ethers");

const networkConfiq = {
4: {
name: "rinkeby",
vrfCoordinatorV2: "0x6168499c0cFfCaCD319c818142124B7A15E857ab",
entranceFee: ethers.utils.parseEther("0.01"),
gasLane:
"0xd89b2bf150e3b9e13446986e571fb9cab24b13cea0a43ea20a6049a85cc807cc",
subscriptionId: "0",
callbackGasLimit: "500000",
interval: "30",
},
31337: {
name: "hardhat",
entranceFee: ethers.utils.parseEther("0.01"),
gasLane:
"0xd89b2bf150e3b9e13446986e571fb9cab24b13cea0a43ea20a6049a85cc807cc",
callbackGasLimit: "500000",
interval: "30",
},
};

const developmentChains = ["hardhat", "localhost"];

module.exports = {
networkConfiq,
developmentChains,
};

Error as stated in terminal when attempt to run yarn hardhat deploy
An unexpected error occurred:

Error: ERROR processing /Users/c/Desktop/Hard-Hat-Learning/hardhat-smartcontract-lottery/deploy/01-deploy-raffle.js: TypeError: Cannot read properties of undefined (reading '31337') at Object.module.exports [as func] (/Users/c/Desktop/Hard-Hat-Learning/hardhat-smartcontract-lottery/deploy/01-deploy-raffle.js:34:36)`

[othaime-en]

Hey @Cronk123 there is a difference in how you've named the object networkConfiq In your helper-hardhat-config you've named and exported it as networkConfiq and in your deploy script, you are importing it as networkConfig. Rename the variable networkConfiq to networkConfig in your hardhat-config.js file. Tell me if this fixes your error.

[Cronk123]

omg @othaime-en thanks so much i thought i corrected all those errors. code deploys fine now. cant believe i would miss something so simple.

[krakxn]

Which IDE are you using? Use extensions to highlight both Solidity and JS code--they make it much easier to debug (actually, since this is a syntactical error, it would have shown up even w/o a text-highlighter).

[othaime-en]

All the best! :)