Lesson 15: NftMarketplace approve() to access any NFT for listing

[ManuWeb3]

Hi all,

Is it mandatory (in Production) to approve( ) to an NftMarketplace to access any NFT before getting it listed in listItem( ) ?
OR
it's just one of the good practices ?

nft.getApproved(tokenId) != address(this)

code of listItem( ) below for reference

function listItem (address nftAddress, uint256 tokenId, uint256 price)
external  
notListed (nftAddress, tokenId, msg.sender) 
isOwnerOrApproved (nftAddress, tokenId, msg.sender)
{
if(price <= 0) {
        revert NftMarketplace__PriceMustBeAboveZero();
}

 IERC721 nft = IERC721(nftAddress);
    if(nft.getApproved(tokenId) != address(this)) {
        revert NftMarketplace__NotYetApprovedForMarketplace();
    }
s_listings[nftAddress][tokenId] = Listing(price, msg.sender);
emit ItemListed(msg.sender, nftAddress, tokenId, price);
}

[RoboCrypter]

@ManuWeb3 : Yes, It is mandatory as well as the good practice!

Because you just don't want any contract to have access to your nft, You as a Owner should have to approve that contract first!

[ManuWeb3]

Ohk... makes sense..

Actually, I got this doubt when I tried to get my BasicNFT listed through an approved address which, it seems, is not possible the way we wrote our codes for BasicNft.sol (or even RandomIpfsNft OR DynamicSVG) and NftMarketplace.sol.

Reason being: the approve( ) in ERC721.sol allows us to approve only 1 address at a time to access our any NFT contract.

If I approve any Externally Owned Account to access BasicNft, then NftMarketplace loses access to it and vice-versa.

So, I believe, provision for an approved Address to list an NFT on NftMarketplace is missing.

Is it because we made a minimalistic NftMarketplace.sol ?
Or
Is it something that I'm missing / misinterpreting here ?

P.S: I've assumed that an approved Address should be able to list the NFT if it has the privileges to execute safeTransferFrom() kind of functions on any NFT, as per EIP-721.

[ManuWeb3]

@abossofmyself : hey, I was wondering:

Is it because we made a minimalistic NftMarketplace.sol ?
Or
Is it something that I'm missing / misinterpreting here ?

[RoboCrypter]

@ManuWeb3 : Yes, This is a minimalistic NftMarketplace contract!