Lesson 14 : Unit tests failing to pass

[DorianDaSilva]

Problem

The test I wrote were failing so I decided to use the course repo to build the tests and improve my understanding of how to write tests for NFTs.

Unfortunately, none of the tests imported from the course repo are passing as you can see below:

  1) Random IPFS NFT Unit Tests
       constructor
         sets starting values correctly:
     Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="getDogTokenUris(uint256)", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.7.0)


  2) Random IPFS NFT Unit Tests
       requestNft
         Fails if payment isn't sent with request:

      AssertionError: Expected transaction to be reverted
      + expected - actual

      -Transaction NOT reverted.
      +Transaction reverted.
      
  

  3) Random IPFS NFT Unit Tests
       requestNft
         reverts if payment amount is less than the mint fee:
     Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="getMintFee()", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.7.0)

  4) Random IPFS NFT Unit Tests
       requestNft
         emits event and kicks off a random word request:
     Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="getMintFee()", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.7.0)

When I make modifications to the RandomIpfsNFT contract or to the tests, hardhat erases the constructor arguments from the artifacts throwing a new error (seen below) forcing me to add the arguments manually. Once added terminal goes back to throwing the errors described above.

     ERROR processing /home/me/hh-fcc/hardhat-nft-fcc/deploy/02-deploy-random-ipfs.js:
Error: expected 0 constructor arguments, got 6

======================================================================================

Steps taken

• Reviewing syntax: identical to the repo and video
• Modifying RandomIpfsNFT syntax for fixtures
• changing getDogTokenUris to get TokenUris
• replacing (0) by ("0") / [0]
• changing syntax to await randomIpfsNft.getDogTokenUris[index(0)] and multiple variations.
• Including the s_initialized / getInitialized() bit to the contract

None of these made a difference.

Tried making sense of the docs : https://docs.ethers.io/v5/troubleshooting/errors/#help-CALL_EXCEPTION

Although this could be the issue due to the constructor arguments being deleted by the system in artifacts
The wrong code is being accessed, for example if an artifact file was not correctly updated so an older instance of the contract is being called

I was unable to confirm this was the actual issue and fix it.

======================================================================================

Test.js

const { assert, expect } = require("chai")
const { network, deployments, ethers } = require("hardhat")
const { developmentChains, networkConfig } = require("../helper-hardhat-config")

!developmentChains.includes(network.name)
    ? describe.skip
    : describe("Random IPFS NFT Unit Tests", async function () {
          let randomIpfsNft, deployer, vrfCoordinatorV2Mock

          beforeEach(async function () {
              accounts = await ethers.getSigners()
              deployer = accounts[0]
              await deployments.fixture(["mocks", "randomIpfsNft"])
              randomIpfsNft = await ethers.getContract("RandomIpfsNFT")
              vrfCoordinatorV2Mock = await ethers.getContract("VRFCoordinatorV2Mock")
          })

          describe("constructor", function () {
              it("sets starting values correctly", async function () {
                  const dogTokenUriZero = await randomIpfsNft.getDogTokenUris(0)
                  assert(dogTokenUriZero.includes("ipfs://"))
                  //assert.equal(isInitialized, true)
              })
          })

          describe("requestNft", function () {
              it("Fails if payment isn't sent with request", async function () {
                  await expect(randomIpfsNft.requestNft()).to.be.revertedWith(
                      "RandomIpfsNFT_NeedMoreETHSent"
                  )
              })

              it("reverts if payment amount is less than the mint fee", async function () {
                  const fee = await randomIpfsNft.getMintFee()
                  await expect(
                      randomIpfsNft.requestNft({
                          value: mintFee.sub(ethers.utils.parseEther("0.001")) })
                          ).to.be.revertedWith("RandomIpfsNFT_NeedMoreETHSent")
                      })

                it("emits event and kicks off a random word request", async function () {
                    const fee = await randomIpfsNft.getMintFee()
                    await expect(randomIpfsNft.requestNft({ value: fee.toString() })).to.emit(
                        randomIpfsNft, "NftRequested"
                    )
                })
            })
        })

======================================================================================

I would appreciate if for once someone in this group could provide a working solution or point me in the direction of one as of 90% of questions in this discussion group are solved by myself...So, not much support for new developers from where i stand.

Thank you!

[RoboCrypter]

@DorianDaSilva : Can you send me your updated repo link!, and make sure to use imports directly from the chainlink dependency.

last I check your contract was abstract and when I was testing your repo I got the exact same error of constructor arguments!

[RoboCrypter]

@DorianDaSilva : On the last step fixing your test!

[RoboCrypter]

@DorianDaSilva : I'm done my friend! You code is been fixed check the PRs! Merge them and you will be good to go!

If you issue gets resolved, Mark the answer as answered! ThankYou

Look at that 👍

Have a good one!

[DorianDaSilva]

@abossofmyself Thank you so much my friend! I assumed you were busy hence why I reposted the issue because so many new discussions come up in a day that it gets lost in the bunch. Been going crazy on this since 1st posted.

I passes perfectly...Can you share what I was doing wrong, please? So I can avoid repeating the mistake.

[RoboCrypter]

@DorianDaSilva : Yes, glad you understand!

• Firstly In your contract, There was a naming mistake in your function fulfillRandomWords that is why it was not overriding and your contract was becoming abstract

• By fixing the first issue the major problem in your code was fixed then I fixed some of you tests like,

1. You wrote mintFee but above it was declared as fee
2. You wrote the revert error wrong, I fixed it according to your contract

And that's it!

[DorianDaSilva]

@abossofmyself Got it, so mostly small syntax errors that I didn't detect. I really appreciate yo taking the time to look into it.

[krakxn]

Repo please

[DorianDaSilva]

@krakxn Here is public repo: https://github.com/DorianDaSilva/deploy-random-nft-fcc-bugTests