LESSON 14: Type error deploying - Cannot read properties of undefined

[DorianDaSilva]

Terminal output:

Local network detected! Deploying mocks to local network...
deploying "vrfCoordinatorV2Mock" (tx: 0x3a4e4c4afe3ffa732c329b1cdbba306c608c43d8276dcddca66051fe11087996)...: deployed at 0x5FbDB2315678afecb367f032d93F642f64180aa3 with 53364 gas
deploying "MockV3Aggregator" (tx: 0x685426a88aac3c1caee832c6ec76bc61cd8d81f053edcec2ba48be25f7cc6b76)...: deployed at 0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512 with 697014 gas
Mocks deployer!
______________________________________________________________
You are deploying to a local network, you need a local network running to interact
 Plz run `yarn hardhat console --network localhost` to interact with deployed smart contracts!
______________________________________________________________
______________________________________________________
deploying "BasicNFT" (tx: 0x63493984b8a3f64eff58eeac27cf53841c3ab9b3bb2bb9ae769cb834608ae66b)...: deployed at 0x9fE46736679d2D9a65F0992F2272dE9f3c7fa6e0 with 2014805 gas
______________________________________________________
[ 'pug.png', 'shiba-inu.png', 'st-bernard.png' ]
Uploading to Pinata!
Working on 0...
Working on 1...
Working on 2...
Uploading pug...
Uploading shiba-inu...
Uploading st-bernard...
Token URIs Uploaded! They are:
[
  'ipfs://QmaVkBn2tKmjbhphU7eyztbvSQU5EXDdqRyXZtRhSGgJGo',
  'ipfs://QmYQC5aGZu2PTH8XzbJrbDnvhj3gVs7ya33H9mqUNvST3d',
  'ipfs://QmZYmH5iDbD6v3U2ixoVAjioSzvWJszDzYdbeCLquGSpVm'
]
An unexpected error occurred:

Error: ERROR processing /home/ionmind/hh-fcc/hardhat-nft-fcc/deploy/02-deploy-random-ipfs-nft.js:
TypeError: Cannot read properties of undefined (reading 'args')

=============================================================================

Code block triggering the error

    const args = [
        vrfCoordinatorV2Address,
        subscriptionId,
        networkConfig[chainId].gasLane,
        networkConfig[chainId].callbackGasLimit,
        networkConfig[chainId].mintFee,
        tokenUris,
    ]

======================================================================================

Deploy script

const { network, ethers } = require("hardhat")
const { developmentChains, networkConfig } = require("../helper-hardhat-config")
const { verify } = require("../utils/verify")
const { storeImages, storeTokenUriMetadata } = require("../utils/uploadToPinata")

const imagesLocation = "./images/randomNFT/"
let tokenUris = []

const metadataTemplate = {
    name: "",
    description: "",
    image: "",
    attributes: [
        {
            trait_type: "Cuteness",
            value: 100,
        },
    ],
}

module.exports = async function ({ getNamedAccounts, deployments }) {
    const { deploy, log } = deployments
    const { deployer } = await getNamedAccounts()
    const chainId = network.config.chainId
    let tokenUris

    if (process.env.UPLOAD_TO_PINATA == "true") {
        tokenUris = await handleTokenUris()
    }

    let vrfCoordinatorV2Address, subscriptionId

    if (developmentChains.includes(network.name)) {
        const vrfCoordinatorV2Mock = await ethers.getContract("vrfCoordinatorV2Mock")
        vrfCoordinatorV2Address = vrfCoordinatorV2Mock.address
        const tx = await vrfCoordinatorV2Mock.createSubscription()
        const txReceipt = await tx.wait(1)
        subscriptionId = txReceipt.events[0].args.subId
    } else {
        vrfCoordinatorV2Address = networkConfig[chainId].vrfCoordinatorV2
        subscriptionId = networkConfig[chainId].subscriptionId
    }

    log("______________________________________________________")


    const args = [
        vrfCoordinatorV2Address,
        subscriptionId,
        networkConfig[chainId].gasLane,
        networkConfig[chainId].callbackGasLimit,
        networkConfig[chainId].mintFee,
        tokenUris,
    ]

    const randomIpfsNft = await deploy("RandomIpfsNFT", {
        from: deployer,
        args: args,
        log: true,
        waitConfirmations: network.config.blockConfirmations || 1,
    })
    log("_________________________________________________________")

    if (!developmentChains.includes(network.name) && process.env.ETHERSCAN_API_KEY) {
        log("Verifying...")

        await verify(randomIpfsNft.address, args)
    }

}

async function handleTokenUris() {
    tokenUris = []
    const { responses: imageUploadResponses, files } = await storeImages(imagesLocation)
    for (imageUploadResponses.Index in imageUploadResponses) {
        //create metadata
        //upload metadata
        let tokenUriMetadata = { ...metadataTemplate }
        tokenUriMetadata.name = files[imageUploadResponses.Index].replace(".png", "")
        tokenUriMetadata.description = `An adorable ${tokenUriMetadata.name} pup!`
        tokenUriMetadata.image = `ipfs://${imageUploadResponses[imageUploadResponses.Index].IpfsHash}`
        console.log(`Uploading ${tokenUriMetadata.name}...`)

        const metadataUploadResponse = await storeTokenUriMetadata(tokenUriMetadata)
        tokenUris.push(`ipfs://${metadataUploadResponse.IpfsHash}`)
    }
    console.log("Token URIs Uploaded! They are:")
    console.log(tokenUris)
    return tokenUris
}

module.exports.tags = ["all", "randomIpfsNFT", "main"]

======================================================================================

Upload to pinata script

const pinataSDK = require("@pinata/sdk")
const path = require("path")
const fs = require("fs")
require("dotenv").config()

const pinataApiKey = process.env.PINATA_API_KEY
const pinataApiSecret = process.env.PINATA_API_SECRET
const pinata = pinataSDK(pinataApiKey, pinataApiSecret)

async function storeImages(imagesFilePath) {
    const fullImagesPath = path.resolve(imagesFilePath) //full output of the path
    const files = fs.readdirSync(fullImagesPath) //read entire directory & get files path
    console.log(files)
    let responses = []
    console.log("Uploading to Pinata!")
    for (fileIndex in files) {
        console.log(`Working on ${fileIndex}...`)
        const readableStreamForFile = fs.createReadStream(`${fullImagesPath}/${files[fileIndex]}`)
        try {
            const response = await pinata.pinFileToIPFS(readableStreamForFile)
            responses.push(response)
        } catch (error){
            console.log(error)
        }
    }
    return { responses, files }
}

async function storeTokenUriMetadata(metadata) {
    try {
        const response = await pinata.pinJSONToIPFS(metadata)
        return response
    } catch (error) {
        console.log(error)
    }
    return null

}


module.exports = { storeImages, storeTokenUriMetadata }

======================================================================================

I have literally tried everything under the sun but still unable to pinpoint the issue. Code was deploying and compiling perfectly before we unquoted the args and included tokenUris argument

[RoboCrypter]

@DorianDaSilva : I'm listing the corrections below:

1. You have a spelling mistake in getting contract VRFCoordinatorV2Mock

• Change this of code from this : const vrfCoordinatorV2Mock = await ethers.getContract("vrfCoordinatorV2Mock")

  To this : const vrfCoordinatorV2Mock = await ethers.getContract("VRFCoordinatorV2Mock")

2. And you also have to fund the subscription as well!

• First up top you have to define the FUND_AMOUNT like this : const FUND_AMOUNT = "1000000000000000000000"

• Then fund the subscription : await vrfCoordinatorV2Mock.fundSubscription(subscriptionId, FUND_AMOUNT)

Your randomIpfs-deploy.js script should look like this :

Copy & Paste this one I have updated it with corrections :

const { network, ethers } = require("hardhat")
const { developmentChains, networkConfig } = require("../helper-hardhat-config")
const { verify } = require("../utils/verify")
const { storeImages, storeTokenUriMetadata } = require("../utils/uploadToPinata")


const FUND_AMOUNT = "1000000000000000000000"
const imagesLocation = "./images/randomNFT/"
let tokenUris = []

const metadataTemplate = {
    name: "",
    description: "",
    image: "",
    attributes: [
        {
            trait_type: "Cuteness",
            value: 100,
        },
    ],
}

module.exports = async function ({ getNamedAccounts, deployments }) {
    const { deploy, log } = deployments
    const { deployer } = await getNamedAccounts()
    const chainId = network.config.chainId
    let tokenUris

    if (process.env.UPLOAD_TO_PINATA == "true") {
        tokenUris = await handleTokenUris()
    }

    let vrfCoordinatorV2Address, subscriptionId

    if (developmentChains.includes(network.name)) {
        const vrfCoordinatorV2Mock = await ethers.getContract("VRFCoordinatorV2Mock")
        vrfCoordinatorV2Address = vrfCoordinatorV2Mock.address
        const tx = await vrfCoordinatorV2Mock.createSubscription()
        const txReceipt = await tx.wait(1)
        subscriptionId = txReceipt.events[0].args.subId
        await vrfCoordinatorV2Mock.fundSubscription(subscriptionId, FUND_AMOUNT)
    } else {
        vrfCoordinatorV2Address = networkConfig[chainId].vrfCoordinatorV2
        subscriptionId = networkConfig[chainId].subscriptionId
    }

    log("______________________________________________________")


    const args = [
        vrfCoordinatorV2Address,
        subscriptionId,
        networkConfig[chainId].gasLane,
        networkConfig[chainId].callbackGasLimit,
        networkConfig[chainId].mintFee,
        tokenUris,
    ]

    const randomIpfsNft = await deploy("RandomIpfsNFT", {
        from: deployer,
        args: args,
        log: true,
        waitConfirmations: network.config.blockConfirmations || 1,
    })
    log("_________________________________________________________")

    if (!developmentChains.includes(network.name) && process.env.ETHERSCAN_API_KEY) {
        log("Verifying...")

        await verify(randomIpfsNft.address, args)
    }

}

async function handleTokenUris() {
    tokenUris = []
    const { responses: imageUploadResponses, files } = await storeImages(imagesLocation)
    for (imageUploadResponses.Index in imageUploadResponses) {
        //create metadata
        //upload metadata
        let tokenUriMetadata = { ...metadataTemplate }
        tokenUriMetadata.name = files[imageUploadResponses.Index].replace(".png", "")
        tokenUriMetadata.description = `An adorable ${tokenUriMetadata.name} pup!`
        tokenUriMetadata.image = `ipfs://${imageUploadResponses[imageUploadResponses.Index].IpfsHash}`
        console.log(`Uploading ${tokenUriMetadata.name}...`)

        const metadataUploadResponse = await storeTokenUriMetadata(tokenUriMetadata)
        tokenUris.push(`ipfs://${metadataUploadResponse.IpfsHash}`)
    }
    console.log("Token URIs Uploaded! They are:")
    console.log(tokenUris)
    return tokenUris
}

module.exports.tags = ["all", "randomIpfsNFT", "main"]

[RoboCrypter]

@DorianDaSilva : Let me know, If it resolves your issue!

[DorianDaSilva]

@abossofmyself Thank you for pointing out these issues, however I am still getting the error

TypeError: Cannot read properties of undefined (reading 'args')

[RoboCrypter]

@DorianDaSilva : Can your share your RandomIpfsNft.sol contract file! and also helper-hardhat-config.js file as well!

[RoboCrypter]

@DorianDaSilva : And also make sure your constructor arguments are in same order as they are in your contract!

If you following the course video, I'm pretty sure the order in your deploy script should be like this :

    const args = [
        vrfCoordinatorV2Address,
        subscriptionId,
        networkConfig[chainId].gasLane,
        networkConfig[chainId].callbackGasLimit,
        tokenUris,
        networkConfig[chainId].mintFee
    ]

Correct the order of your args , and let me know if it resolves your issue!

[DorianDaSilva]

@abossofmyself

NFT contract

//SPDX-License-Identifier: MIT

pragma solidity ^0.8.9;

import "../Imports/ChainLink/VRFCoordinatorV2Interface.sol";
import "../Imports/ChainLink/VRFConsumerBaseV2.sol";
import "../NFTtoken/ERC721.sol";
import "../NFTtoken/ERC721Imports/extensions/ERC721URIStorage.sol";
import "../NFTtoken/ERC721Imports/access/Ownable.sol";

error RandomIpfsNFT_RangeOutOfBounds();
error RandomIpfsNFT_NeedMoreETHSent();
error RandomIpfsNFT_TransferFailed();

abstract contract RandomIpfsNFT is VRFConsumerBaseV2, ERC721URIStorage, Ownable {

    //Type declaration
    enum Breed {
        PUG,
        SHIBA_INU,
        ST_BERNARD
    }

    //We will trigger a chainlink VRF call to get a random number
    //That number will give us a random NFT w/different rarities
    VRFCoordinatorV2Interface private immutable i_vrfCoordinator;
    uint64 private immutable i_subscriptionId;
    bytes32 private immutable i_gasLane;
    uint32 private immutable i_callbackGasLimit;
    uint16 private constant REQUEST_CONFIRMATIONS = 3;
    uint32 private constant NUM_WORDS = 1;

    //VRF Helpers\
    mapping(uint256 => address) public s_requestIdToSender;

    //NFT Variables
    uint256 public s_tokenCounter;
    uint256 internal constant MAX_CHANCE_VALUE = 100;
    string[] internal s_dogTokenUris;
    uint256 internal immutable i_mintFee;

    //Events
    event NFTRequested(uint256 indexed reuqestId, address requester);
    event NFTMinted(Breed dogBreed, address minter);

    constructor(
        address vrfCoordinatorV2,
        uint64 subscriptionId,
        bytes32 gasLane,
        uint32 callbackGasLimit,
        string[3] memory dogTokenUris,
        uint256 mintFee
    ) VRFConsumerBaseV2(vrfCoordinatorV2) ERC721("Random IPFS NFT", "RIN"){
        i_vrfCoordinator = VRFCoordinatorV2Interface(vrfCoordinatorV2);
        i_subscriptionId = subscriptionId;
        i_gasLane = gasLane;
        i_callbackGasLimit = callbackGasLimit;
        s_dogTokenUris = dogTokenUris;
        i_mintFee = mintFee;
    }

    function requestNft() public payable returns (uint256 requestId) {
        if (msg.value < i_mintFee) {
            revert RandomIpfsNFT_NeedMoreETHSent();
        }
        requestId = i_vrfCoordinator.requestRandomWords(
            i_gasLane,
            i_subscriptionId,
            REQUEST_CONFIRMATIONS,
            i_callbackGasLimit,
            NUM_WORDS
        );
        s_requestIdToSender[requestId] = msg.sender;
        emit NFTRequested(requestId, msg.sender);
    }

    function fulfillRandomwords(uint256 requestId, uint256[] memory randomWords)
    internal
    /*override*/ {
        address dogOwner = s_requestIdToSender[requestId];
        uint256 newTokenId = s_tokenCounter;
        //What does this token looks like?
        uint256 moddedRng = randomWords[0] % MAX_CHANCE_VALUE;
        Breed dogBreed = getBreedFromModdedRng(moddedRng);
        _safeMint(dogOwner, newTokenId);
        _setTokenURI(newTokenId, s_dogTokenUris[uint256(dogBreed)]);
        emit NFTMinted(dogBreed, dogOwner);
    }

    function withdraw() public onlyOwner {
        uint256 amount = address(this).balance;
        (bool success, ) = payable(msg.sender).call{value: amount}("");
        if(!success) {
            revert RandomIpfsNFT_TransferFailed();
        }
    }

    function getBreedFromModdedRng(uint256 moddedRng) public pure returns(Breed) {
        uint256 cumulativeSum = 0;
        uint256[3] memory chanceArray = getChanceArray();
        for(uint256 i = 0; i < chanceArray.length; i++){
            if(moddedRng >= cumulativeSum && moddedRng < cumulativeSum + chanceArray[i]){
                return Breed(i);
            }
            cumulativeSum += chanceArray[i];
        }
        revert RandomIpfsNFT_RangeOutOfBounds();
    }


    function getChanceArray() public pure returns(uint256[3] memory) {
        return[10, 30, MAX_CHANCE_VALUE];
    }

    function getMintFee() public view returns (uint256) {
        return i_mintFee;
    }

    function getTokenURI(uint256 index) public view returns (string memory) {
        return s_dogTokenUris[index];
    }

    function getTokenCounter() public view returns (uint256) {
        return s_tokenCounter;
    }

}

=================================================================================

helper-config

const networkConfig = {
    default: {
        name: "hardhat",
        ethUsdPriceFeed: "0x9326BFA02ADD2366b30bacB125260Af641031331",
        gasLane: "0xd89b2bf150e3b9e13446986e571fb9cab24b13cea0a43ea20a6049a85cc807cc", // 30 gwei
        mintFee: "10000000000000000", // 0.01 ETH
        callbackGasLimit: "500000", // 500,000 gas
    },
    31337: {
        name: "localhost",
        ethUsdPriceFeed: "0x9326BFA02ADD2366b30bacB125260Af641031331",
        gasLane: "0xd89b2bf150e3b9e13446986e571fb9cab24b13cea0a43ea20a6049a85cc807cc", // 30 gwei
        mintFee: "10000000000000000", // 0.01 ETH
        callbackGasLimit: "500000", // 500,000 gas
        subscriptionId: "885", // add your ID here!
    },
    // Price Feed Address, values can be obtained at https://docs.chain.link/docs/reference-contracts
    // Default one is ETH/USD contract on Kovan

    5: {
        name: "goerli",
        ethUsdPriceFeed: "0xD4a33860578De61DBAbDc8BFdb98FD742fA7028e",
        vrfCoordinatorV2: "0x2Ca8E0C643bDe4C2E08ab1fA0da3401AdAD7734D",
        gasLane: "0x79d3d8832d904592c0bf9818b621522c988bb8b0c05cdc3b15aea1b6e8db0c15",
        callbackGasLimit: "500000", // 500,000 gas
        mintFee: "10000000000000000", // 0.01 ETH
        subscriptionId: "885", // add your ID here!
    },
}

const DECIMALS = "18"
const INITIAL_PRICE = "200000000000000000000"
const developmentChains = ["hardhat", "localhost"]

module.exports = {
    networkConfig,
    developmentChains,
    DECIMALS,
    INITIAL_PRICE,
}

[RoboCrypter]

@DorianDaSilva : Do the following changes in your Deploy Script

• Correct your constructor arguments order in your deploy script as they are in your contract!

• And also remove the coma from the last argument as you can see in your current args.

  That is why the error is coming that : "Cannot read properties of undefined (reading 'args')"

In your "deploy script" change the order of your args "and" remove the coma from the last argument:

From this :

const args = [
        vrfCoordinatorV2Address,
        subscriptionId,
        networkConfig[chainId].gasLane,
        networkConfig[chainId].callbackGasLimit,
        networkConfig[chainId].mintFee,
        tokenUris,
    ]

To this : Just Copy & Paste this one exactly!

    const args = [
        vrfCoordinatorV2Address,
        subscriptionId,
        networkConfig[chainId].gasLane,
        networkConfig[chainId].callbackGasLimit,
        tokenUris,
        networkConfig[chainId].mintFee
    ]

Hopefully, It will resolve your issue!

[DorianDaSilva]

@abossofmyself Still same error...I uploaded it to a repo, the link is in the comment below in case you are interested. Thank you!

[RoboCrypter]

@DorianDaSilva : I believe, This is resolved as well! This was the same problem, as I solved!

Giving the exact same error of constructor arguments was coming during my testing!

[krakxn]

If this is not resolved yet, push to GitHub and I will look into it

[DorianDaSilva]

@krakxn Thank you!

https://github.com/DorianDaSilva/hardhat-nft-fcc-DeBug

[DorianDaSilva]

Modified the script using inheritance instead of hard coding Opensea contracts. Seems I was missing some dependencies from open sea to be able to make it work 100%...Thank you for the help guys, I appreciate it a lot!

[RoboCrypter]

@DorianDaSilva : Most Welcome!