FundMe Constructor Test Error

[Abhisek0x]

I am facing problem running yarn hardhat test to assert that contract sets the aggregator address correctly to the contract.

Error

$ C:\Users\AY\Desktop\Fundme\node_modules\.bin\hardhat test


  Fundme
    constructor
      1) Sets the aggregator address correctly in the contractor


  0 passing (1s)
  1 failing

  1) Fundme
       constructor
         Sets the aggregator address correctly in the contractor:
     TypeError: fundMe.getPriceFeed is not a function
      at Context.<anonymous> (test\unit\Fundme.test.js:15:37)
      at processImmediate (node:internal/timers:466:21)



error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Contract

// SPDX-License-Identifier: MIT

/** @title A Contract for Crowd Funding using Chainlink Feeds
    @author Abhisek Yadav
    @notice This is to demo a sample funding contract and beware it is not tested for commercial use
    @dev This implements chainlink price feed as our library

 */

pragma solidity ^0.8.0;

import "./PriceConverter.sol";
import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol";

contract Fundme {
    using PriceConverter for uint256;

    uint256 public constant MIN_USD = 50 * 1e18;
    AggregatorV3Interface public s_priceFeed;
    address[] public funders;
    mapping(address => uint256) addressToFunds;
    mapping(address => bool) addressToAdded;
    address public immutable i_owner; //i_owner because it's immutable //it saves gas

    constructor(address priceFeedAddress) {
        i_owner = msg.sender;
        s_priceFeed = AggregatorV3Interface(priceFeedAddress);
    }

    modifier onlyOwner() {
        require(msg.sender == i_owner, "Sender is not owner");
        _;
    }

    function fund() public payable {
        require(
            msg.value.getConversionRate(s_priceFeed) >= MIN_USD,
            "Not enough USD Sent"
        );
        if (!addressToAdded[msg.sender]) {
            funders.push(msg.sender);
        }
        addressToFunds[msg.sender] = msg.value;
        addressToAdded[msg.sender] = true;
    }

    function withdraw() public onlyOwner {
        for (uint256 i = 0; i < funders.length; i++) {
            address funder = funders[i];
            addressToFunds[funder] = 0;
        }

        //resetting the array
        funders = new address[](0);

        //Three Different ways to withdraw funds
        //transfer,send and call

        // payable(msg.sender).transfer(address(this).balance);

        (bool callSuccess, ) = payable(msg.sender).call{
            value: address(this).balance
        }("");
        require(callSuccess, "call failed");
    }

    receive() external payable {
        fund();
    }

    fallback() external payable {
        fund();
    }

    function getPriceFeed() public view returns (AggregatorV3Interface) {
        return s_priceFeed;
    }
}

Test

const { deployments, ethers, getNamedAccounts } = require("hardhat");
const { assert } = require("chai");

describe("Fundme", async () => {
  let fundMe, deployer, mockV3Aggregator;
  beforeEach(async () => {
    deployer = (await getNamedAccounts()).deployer;
    await deployments.fixture(["all"]);
    fundMe = await deployments.get("Fundme", deployer);

    mockV3Aggregator = await deployments.get("MockV3Aggregator", deployer);
  });
  describe("constructor", function () {
    it("Sets the aggregator address correctly in the contractor", async () => {
      const response = await fundMe.getPriceFeed();
      assert.equal(response, mockV3Aggregator.address);
    });
  });
});

[javierdash]

Hi! In your test: remove "get" from here:
const response = await fundMe.getPriceFeed();
Please then try and tell us if it works :)

[Abhisek0x]

Yes did that but still not working and I have defined a function callled getPriceFeed in the Fundme.sol ,but I don't know why while doing test it's not reading it from the deployed contracts.

[javierdash]

but you are not ask the test for that particular function.
What you are trying to test is if the address that you are passing on the constructor of FundMe contract be equal to the address from the mockV3Aggregator contract.
You call the variable “s_priceFeed” so in your test try replacing “const response = await fundMe.getPriceFeed();” for “const response = await fundMe.s_priceFeed();

[Abhisek0x]

I tried it still the same response.

[PatrickAlphaC]

deployments.get returns a deployment object
ethers.getContract returns a contract object <- This is the one you want!

Try this in your test:

    fundMe = await ethers.getContract("Fundme", deployer);

Instead of what you have.

[Abhisek0x]

Ok right, thanks a lot this worked.

[DeveloePaul]

I am facing this error below:

TypeError: no matching function (argument="key", value="address", code=INVALID_ARGUMENT, version=6.6.1)
      at makeError (node_modules/ethers/src.ts/utils/errors.ts:670:21)
      at assert (node_modules/ethers/src.ts/utils/errors.ts:694:25)
      at assertArgument (node_modules/ethers/src.ts/utils/errors.ts:706:5)
      at Interface.getFunctionName (node_modules/ethers/src.ts/abi/interface.ts:542:23)
      at buildWrappedMethod (node_modules/ethers/src.ts/contract/contract.ts:334:34)
      at Contract.getFunction (node_modules/ethers/src.ts/contract/contract.ts:849:22)
      at Object.get (node_modules/ethers/src.ts/contract/contract.ts:747:39)
      at Context.<anonymous> (test/unit/FundMe.test.js:22:53)

Here is my FundMe.test.js:

const { deployments, ethers, getNamedAccounts } = require("hardhat");
const { assert } = require("chai");

describe("FundMe", async () => {
    let fundMe, deployer, mockV3Aggregator;
    beforeEach(async () => {
        // Another way to get accounts is:
        // const accounts = await ethers.getSigners();
        // const account = accounts[0];
        // We are first going to deploy our FundMe contract using Hardhat-deploy
        deployer = (await getNamedAccounts()).deployer;
        await deployments.fixture(["all"]);
        fundMe = await ethers.getContract("FundMe", deployer);
        mockV3Aggregator = await ethers.getContract(
            "MockV3Aggregator",
            deployer
        );
    });
    describe("constructor", async () => {
        it("sets the aggregator address correctly", async () => {
            const response = await fundMe.priceFeed();
            assert.equal(response, mockV3Aggregator.address);
        });
    });
});

How do I resolve the error please?