AssertionError: Expected transaction to be reverted with reason 'FundMe__NotOWner', but it didn't revert

[blaynejosh]

Hey, please I am getting an error with my FundMe .test.js

The error is: AssertionError: Expected transaction to be reverted with reason 'FundMe__NotOWner', but it didn't revert

Here is the code:

it("Only allows the owner o withdraw", async function () {
            const accounts = await ethers.getSigners()
            const attacker = accounts[1]
            const attackerConnectedContract = await fundMe.connect(attacker)
            await expect(
                attackerConnectedContract.withdraw()
            ).to.be.revertedWith("FundMe__NotOWner")
        })

Please help if you can

[othaime-en]

What account did you use to deploy your contract?
Can I see our hardhat.config.js file and your entire test script please.

[blaynejosh]

Okay
Here is hardhat.config.js file

require("@nomicfoundation/hardhat-toolbox")
require("hardhat-deploy")
require("dotenv").config()
require("hardhat-gas-reporter")
require("@nomiclabs/hardhat-etherscan")
require("solidity-coverage")

/** @type import('hardhat/config').HardhatUserConfig */

const GOERLI_RPC_URL = process.env.GOERLI_RPC_URL
const PRIVATE_KEY = process.env.PRIVATE_KEY
const COINMARKETCAP_API_KEY = process.env.COINMARKETCAP_API_KEY
const ETHERSCAN_API_KEY = process.env.ETHERSCAN_API_KEY

module.exports = {
    // solidity: "0.8.9",
    solidity: {
        compilers: [{ version: "0.8.9" }, { version: "0.6.6" }],
    },
    networks: {
        goerli: {
            url: GOERLI_RPC_URL,
            accounts: [PRIVATE_KEY],
            chainId: 5,
            blockConfirmations: 6,
        },
    },
    gasReporter: {
        enabled: false,
        outputFile: "gas-report.txt",
        noColors: true,
        currency: "USD",
        coinmarketcap: COINMARKETCAP_API_KEY,
        token: "MATIC",
    },
    etherscan: {
        apiKey: ETHERSCAN_API_KEY,
    },
    namedAccounts: {
        deployer: {
            default: 0,
        },
        user: {
            default: 1,
        },
    },
}

And here is the entire test script

const { assert, expect } = require("chai")
const { deployments, ethers, getNamedAccounts } = require("hardhat")

describe("FundMe", async function () {
    let fundMe
    let deployer
    let mockV3Aggregator
    const sendValue = ethers.utils.parseEther("1")
    beforeEach(async function () {
        //to get accounts
        // const accounts = await ethers.getSigners()
        // const accountZero = accounts[0]
        deployer = (await getNamedAccounts()).deployer
        await deployments.fixture(["all"])
        fundMe = await ethers.getContract("FundMe", deployer)
        mockV3Aggregator = await ethers.getContract(
            "MockV3Aggregator",
            deployer
        )
    })

    describe("constructor", async function () {
        it("Sets the aggregator addresses correctly", async function () {
            const response = await fundMe.priceFeed()
            assert.equal(response, mockV3Aggregator.address)
        })
    })

    describe("receive", async function () {
        it("Receives fund into the contract address", async function () {
            const response = await fundMe.priceFeed()
            assert.equal(response, mockV3Aggregator.address)
        })
    })

    describe("fallback", async function () {
        it("Throws an error when the minimum fund is not met", async function () {
            const response = await fundMe.priceFeed()
            assert.equal(response, mockV3Aggregator.address)
        })
    })

    describe("fund", async function () {
        it("It confirms the minimum amount sent is enough", async function () {
            await expect(fundMe.fund()).to.be.revertedWith(
                "You didn't send enough funds."
            )
        })
        it("updated the amount funded data structure", async function () {
            await fundMe.fund({ value: sendValue })
            const response = await fundMe.addressToAmountFunded(deployer)
            assert.equal(response.toString(), sendValue.toString())
        })
        it("Adds funder to array of funders", async function () {
            await fundMe.fund({ value: sendValue })
            const funder = await fundMe.funders(0)
            assert.equal(funder, deployer)
        })
    })
    describe("withdraw", async function () {
        beforeEach(async function () {
            await fundMe.fund({ value: sendValue })
        })

        it("withdraws ETH from a single founder", async function () {
            // Arrange
            const startingFundMeBalance = await fundMe.provider.getBalance(
                fundMe.address
            )
            const startingDeployerBalance = await fundMe.provider.getBalance(
                deployer
            )
            // Act
            const transactionResponse = await fundMe.withdraw()
            const transactionReceipt = await transactionResponse.wait(1)
            const { gasUsed, effectiveGasPrice } = transactionReceipt
            const gasCost = gasUsed.mul(effectiveGasPrice)
            const endingFundMeBalance = await fundMe.provider.getBalance(
                fundMe.address
            )
            const endingDeployerBalance = await fundMe.provider.getBalance(
                deployer
            )
            // Gas cost
            // Assert
            assert.equal(endingFundMeBalance, 0)
            assert.equal(
                startingFundMeBalance.add(startingDeployerBalance).toString(),
                endingDeployerBalance.add(gasCost).toString()
            )
        })
        it("Allows us to withdraw with multiple funders", async function () {
            // Arrange
            const accounts = await ethers.getSigners()
            for (let i = 1; i < 6; i++) {
                const fundMeConnectedContract = await fundMe.connect(
                    accounts[i]
                )
                await fundMeConnectedContract.fund({ value: sendValue })
            }
            const startingFundMeBalance = await fundMe.provider.getBalance(
                fundMe.address
            )
            const startingDeployerBalance = await fundMe.provider.getBalance(
                deployer
            )
            // Act
            const transactionResponse = await fundMe.withdraw()
            const transactionReceipt = await transactionResponse.wait(1)
            const { gasUsed, effectiveGasPrice } = transactionReceipt
            const gasCost = gasUsed.mul(effectiveGasPrice)
            // Assert
            const endingFundMeBalance = await fundMe.provider.getBalance(
                fundMe.address
            )
            const endingDeployerBalance = await fundMe.provider.getBalance(
                deployer
            )
            //Assert
            assert.equal(endingFundMeBalance, 0)
            assert.equal(
                startingFundMeBalance.add(startingDeployerBalance).toString(),
                endingDeployerBalance.add(gasCost).toString()
            )

            // Make sure that the funders are reset properly
            await expect(fundMe.funders(0)).to.be.reverted

            for (i = 1; i < 6; i++) {
                assert.equal(
                    await fundMe.addressToAmountFunded(accounts[i].address),
                    0
                )
            }
        })
        it("Only allows the owner o withdraw", async function () {
            const accounts = await ethers.getSigners()
            const attacker = accounts[1]
            const attackerConnectedContract = await fundMe.connect(attacker)
            await expect(
                attackerConnectedContract.withdraw()
            ).to.be.revertedWith("FundMe__NotOWner")
        })
    })
})

[othaime-en]

I can't seem to see any error in these two files. Push your code to github and leave a link here. I'll run it locally and see where the issue is comming from.
Sidenote: In the meantime, check if this is not a typo ).to.be.revertedWith("FundMe__NotOWner") should it be FundMe__NotOwner?

[blaynejosh]

Okay...I will. thank you

[RoboCrypter]

@blaynejosh : Can you send me your FundMe contract!

[blaynejosh]

Okay...thanks for the assist

[blaynejosh]

However, @abossofmyself, I had some issues with the unit testing part for fund()

What I tried which worked for me was to change the require condition for the line below in the FundMe.sol

The line is:

 require(msg.value.getConversionRate(s_priceFeed) < MINIMUM_USD, "You didn't send enough funds.");

[RoboCrypter]

@blaynejosh : Alright!

[RoboCrypter]

@blaynejosh : I have found the mistakes, I'm listing them below:

• Change this revert error statement in your test according to your contract:

  From this : to.be.revertedWith("FundMe__NotOWner") To this : to.be.revertedWith("FundMe__NotOwner")

• In your contract fund function :

  Change this line from this :
  require(msg.value.getConversionRate(s_priceFeed) < MINIMUM_USD, "You didn't send enough funds.");

  To this : require(msg.value.getConversionRate(s_priceFeed) > MINIMUM_USD, "You didn't send enough funds.");

  It should be > not < !

• In your withdraw function in your contract add the modifier onlyOwner in the function :

  Change it from this : function withdraw() public {}

  To this : function withdraw() public onlyOwner {}

It will resolve your issue!

[RoboCrypter]

@blaynejosh : Look at that 👍

[othaime-en]

Hey @blaynejosh please make your withdraw function such that only the owner can withdraw. Add onlyOwner specifier.

function withdraw() public onlyOwner {

Lack of onlyOwner specifier explains why your test didn't revert because you did put such a restriction, anybody could withdraw.

[blaynejosh]

sadly, it didnt work

[othaime-en]

run yarn hardhat clean to clear your cache then yarn hardhat compile to compile your contract again.
Afterwards try running the test again and see if it works.

Remember to change FundMe__NotOWner to FundMe__NotOwner in your test script.

[krakxn]

Is this resolved yet? If not, push to GitHub and I will look into it :)

[blaynejosh]

ill drop the GitHub link soon. Thank you all for the assistance

[blaynejosh]

Hello, finally pushed to github

here is the link:
https://github.com/blaynejosh/hardhat-fund-me.git

Thank you

[hrushigawade4]

I have same problem and the answer is when you first deploy your contract you have connected to the first account address so this will be the owner and this error is coming because you are on different account so pls check on your first or second address @blaynejosh

[RoboCrypter]

@blaynejosh : I have found the mistakes, I'm listing them below:

• Change this revert error statement in your test according to your contract:
  From this : to.be.revertedWith("FundMe__NotOWner") To this : to.be.revertedWith("FundMe__NotOwner")
• In your contract fund function :
  Change this line from this :
  require(msg.value.getConversionRate(s_priceFeed) < MINIMUM_USD, "You didn't send enough funds.");
  To this : require(msg.value.getConversionRate(s_priceFeed) > MINIMUM_USD, "You didn't send enough funds.");
  It should be > not < !
• In your withdraw function in your contract add the modifier onlyOwner in the function :
  Change it from this : function withdraw() public {}
  To this : function withdraw() public onlyOwner {}

It will resolve your issue!

@blaynejosh : Made PRs in your repo, You can merge them!

And let me know, If it resolves your issue!

[blaynejosh]

Im sorry, it didnt solve the issue

those are the errors i am getting

[RoboCrypter]

@blaynejosh : Let me again copy your code, and run test, I will share screenshot in a moment!

And do merge the existing PRs! to update your repo!

And let me know!

[RoboCrypter]

@blaynejosh : It is successfully running and passing all the tests,

Kindly merge the PRs in your repo, and make the following changes in your working code as well!

Everything is working perfectly!

[hrushigawade4]

@blaynejosh

In the fundMe.sol smart contract check the minimum_usd price and then run
and you got a error because you are puttinig usd less than minimum_usd and make changes according to it

function fund() public payable {
        require(
            msg.value.getConversionRate(s_priceFeed) >= MINIMUM_USD,
            "You need to spend more ETH!"

[othaime-en]

Hey @blaynejosh I've made a PR that may fix your issue. Please check it out.

[blaynejosh]

Hello @othaime-en, thanks I will check it out