lesson 7 : Testnet Demo - Hardhat Fund Me (Error)

[gab0071]

I'm trying to verify and submit my contract source code to etherscan using a headset, but I'm getting the following error and I don't understand how to solve it. I've read through the code and can't figure out what I'm doing wrong. Please can anyone advise?
The error that I am getting when I run:

NomicLabsHardhatPluginError: The constructor for contracts/FundMe.sol:FundMe has 1 parameters
but 0 arguments were provided instead.

heres all the code FundMe.sol code

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.8;

import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol";
import "./PriceConverter.sol";

error NotOwner();

contract FundMe {
    using PriceConverter for uint256;

    mapping(address => uint256) public addressToAmountFunded;
    address[] public funders;

    address public /* immutable */ i_owner;
    uint256 public constant MINIMUM_USD = 50 * 10 ** 18;

    AggregatorV3Interface public priceFeed;
    
    constructor(address priceFeedAddress) {
        i_owner = msg.sender;
        priceFeed = AggregatorV3Interface(priceFeedAddress);
    }


    function fund() public payable {
        require(msg.value.getConversionRate(priceFeed) >= MINIMUM_USD, "You need to spend more ETH!");
     
        addressToAmountFunded[msg.sender] += msg.value;
        funders.push(msg.sender);
    }
    
        modifier onlyOwner {
        if (msg.sender != i_owner) revert NotOwner();
        _;
    }
    
    function withdraw() payable onlyOwner public {
        for (uint256 funderIndex=0; funderIndex < funders.length; funderIndex++){
            address funder = funders[funderIndex];
            addressToAmountFunded[funder] = 0;
        }
        funders = new address[](0);
 
        (bool callSuccess, ) = payable(msg.sender).call{value: address(this).balance}("");
        require(callSuccess, "Call failed");
    }

    fallback() external payable {
        fund();
    }

    receive() external payable {
        fund();
    }

}

and also the 01-deploy-fund-me.js to see the code of verify

const { getNamedAccounts, deployments, network } = require("hardhat")
const { networkConfig, developmentChains } = require("../helper-hardhat-config")
const { verify } = require("../utils/verify")

module.exports = async ({ getNamedAccounts, deployments }) => {
    const { deploy, log } = deployments
    const { deployer } = await getNamedAccounts()
    const chainId = network.config.chainId

    let ethUsdPriceFeedAddress
    if (chainId == 31337) {
        const ethUsdAggregator = await deployments.get("MockV3Aggregator")
        ethUsdPriceFeedAddress = ethUsdAggregator.address
    } else {
        ethUsdPriceFeedAddress = networkConfig[chainId]["ethUsdPriceFeed"]
    }
    log("----------------------------------------------------")
    log("Deploying FundMe and waiting for confirmations...")

    const fundMe = await deploy("FundMe", {
        from: deployer,
        args: [ethUsdPriceFeedAddress],
        log: true,
        // we need to wait if on a live network so we can verify properly
        waitConfirmations: network.config.blockConfirmations || 1,
    })
    //log("----------------------------------------------------")
    log(`FundMe deployed at ${fundMe.address}`)

    if (
        !developmentChains.includes(network.name) &&
        process.env.ETHERSCAN_API_KEY
    ) {
        await verify(fundMe.address, [ethUsdPriceFeedAddress])
    }
    log("----------------------------------------------------")
}

module.exports.tags = ["all", "fundme"]

Please help me!

[PatrickAlphaC]

ethUsdPriceFeedAddress is likely currently null.

Could you do a console.log(ethUsdPriceFeedAddress) right before you deploy in your script and see what it is?

[gab0071]

hi, Patrick!!

Yes im try right now in the file 01-deploy-fund-me.js with the console.log and its ok, still have the same ```Error````

here's the console.log(ethUsdPriceFeedAddress)

let ethUsdPriceFeedAddress
    if (developmentChains.includes(network.name)) {
        const ethUsdAggregator = await deployments.get("MockV3Aggregator")
        ethUsdPriceFeedAddress = ethUsdAggregator.address
    } else {
        ethUsdPriceFeedAddress = networkConfig[chainId]["ethUsdPriceFeed"]
    }
    log(ethUsdPriceFeedAddress)
    log("----------------------------------------------------")
    log("Deploying FundMe and waiting for confirmations...")

in the terminal throws me this

Nothing to compile
0x8A753747A1Fa494EC906cE90E9f37563A8AF630e
----------------------------------------------------
Deploying FundMe and waiting for confirmations...
reusing "FundMe" at 0xf9394D88081e68230F20e67E41C9135Dbf57b24F
FundMe deployed at 0xf9394D88081e68230F20e67E41C9135Dbf57b24F
verifying contract...
Nothing to compile
NomicLabsHardhatPluginError: The constructor for contracts/FundMe.sol:FundMe has 1 parameters
but 0 arguments were provided instead.

and the Error still happen!

[PatrickAlphaC]

It's saying:

NomicLabsHardhatPluginError: The constructor for contracts/FundMe.sol:FundMe has 1 parameters
but 0 arguments were provided instead.

What does your verify look like?

[gab0071]

Patrick! its crazy now this is this Error

Compiled 8 Solidity files successfully
----------------------------------------------------
Deploying FundMe and waiting for confirmations...
reusing "FundMe" at 0x03bAB200752977B3220fc5B2967c79b899b07d6f
FundMe deployed at 0x03bAB200752977B3220fc5B2967c79b899b07d6f
Verifying contract...
Nothing to compile
NomicLabsHardhatPluginError: Failed to send contract verification request.
Endpoint URL: https://api-rinkeby.etherscan.io/api
Reason: The Etherscan API responded that the address 0x03bAB200752977B3220fc5B2967c79b899b07d6f does not have bytecode.
This can happen if the contract was recently deployed and this fact hasn't propagated to the backend yet.
Try waiting for a minute before verifying your contract. If you are invoking this from a script,
try to wait for five confirmations of your contract deployment transaction before running the verification subtask.

I just looked at Rinkeby-etherscan and if the contract that I deployed two days ago appears verified, it just takes too long to update and even in my metamask the data of the test transactions that I have done with Rinkeby does not appear! it is something strange.

I'm going to try Kovan's testnet and I'll tell you how it goes later.

[gab0071]

PATRICCCCK!!!

Solved the problem just by changing the network to Kovan.. all super good, I just had to create an account in infura to use the Kovan test network, thanks for being attentive.

The proof that everything worked!!!! wohooo

Nothing to compile
----------------------------------------------------
Deploying FundMe and waiting for confirmations...
deploying "FundMe" (tx: 0x8b74492e00aca5d51eb08767ae895112408cfefee068120bf03d6fab15dc8b7b)...: deployed at 0x63EC38c9D966d29443a502D95Ab6EcE12a0D9776 with 1058635 gas
FundMe deployed at 0x63EC38c9D966d29443a502D95Ab6EcE12a0D9776
Verifying contract...
Nothing to compile
Successfully submitted source code for contract
contracts/FundMe.sol:FundMe at 0x63EC38c9D966d29443a502D95Ab6EcE12a0D9776
for verification on the block explorer. Waiting for verification result...

Successfully verified contract FundMe on Etherscan.
https://kovan.etherscan.io/address/0x63EC38c9D966d29443a502D95Ab6EcE12a0D9776#code
Done in 56.66s.

[PatrickAlphaC]

Boom!

[knoori]

@gab0071 @PatrickAlphaC I'm having the same issue on RInkeby.

I added an unused dummy variable to FundMe.sol to ensure a fresh Rinkeby contract address and re-ran the deploy script:

❯ yarn hardhat --network rinkeby deploy
yarn run v1.22.15
warning package.json: No license field
...
Compiled 8 Solidity files successfully
deploying "FundMe" (tx: 0x9ee0b4e658ea8f526cabb6fdbdaf03a9f6d611f16d359687f23910f1f75fef04)...: deployed at 0xBad1E1601884A08C144Ca533692a5A3fedafC6f4 with 898894 gas
Verifying contract...
contractAddress is 0xBad1E1601884A08C144Ca533692a5A3fedafC6f4
args is 0x8A753747A1Fa494EC906cE90E9f37563A8AF630e
Nothing to compile
Contract verification failed:
NomicLabsHardhatPluginError: The constructor for contracts/FundMe.sol:FundMe has 1 parameters
but 0 arguments were provided instead.
    at encodeArguments [...
...
...]
Contract(s) deployed.
==================================================
✨  Done in 99.22s.

The FundMe contract is properly deployed, but verification is is failing (not due to "already verified"). Note that I removed some of the output lines, marked with [...].
I also logged contractAddress and args inputs from the verify function in verify.js - both look correct. My verify.js script is:

const { run } = require("hardhat")

async function verify(contractAddress, args) {
    console.log("Verifying contract...")
    console.log(`contractAddress is ${contractAddress}`) //db
    console.log(`args is ${args}`) //db
    try {
        await run("verify:verify", {
            address: contractAddress,
            constructor: args,
            // constructor: ["0x8A753747A1Fa494EC906cE90E9f37563A8AF630e"], //db
        })
    } catch (e) {
        if (e.message.toLowerCase().includes("already verified")) {
            console.log("Contract already verified.")
        } else {
            console.log("Contract verification failed:")
            console.log(e)
        }
    }
}

module.exports = { verify }

Interestingly, if I verify manually via the command line I get:

❯ yarn hardhat verify --network rinkeby 0xBad1E1601884A08C144Ca533692a5A3fedafC6f4 "0x8A753747A1Fa494EC906cE90E9f37563A8AF630e"
yarn run v1.22.15
warning package.json: No license field
[...]
Nothing to compile
Successfully submitted source code for contract
contracts/FundMe.sol:FundMe at 0xBad1E1601884A08C144Ca533692a5A3fedafC6f4
for verification on the block explorer. Waiting for verification result...

Successfully verified contract FundMe on Etherscan.
https://rinkeby.etherscan.io/address/0xBad1E1601884A08C144Ca533692a5A3fedafC6f4#code
✨  Done in 27.07s.

Now the contract is being properly verified.

Not sure why exactly it's failing via the script. I tried passing the Rinkeby price feed address directly to the verify call in verify.js and it still failed.

Anyway, not a big problem, but any thoughts would be appreciated.

[PatrickAlphaC]

Could you make this a new question? Thanks!

Although it looks like you solved it?

[knoori]

ok, done. see #320.

yes, it's solved, but I posted the issue anyway in case anyone else has the same problem.

the issue was a typo when calling

await run("verify:verify", {
            address: contractAddress,
            constructor: args,
        })

changed "constructor" to "constructorArguments" and it works as expected.

thanks!

[nicolasCinzer]

changed "constructor" to "constructorArguments" and it works as expected.

This worked for me!! Thanks @knoori