Chainlink VRF and Keeper not working on testnet

[KaladinStormBlessed16]

Hello,
I was following the Lottery contract until the end, but at the final step the staging test just keeps waiting for the event until timeout:
So I downloaded the code from the repo, made yarn to install and changed the keys withing .env. Then changed the subscriptionId in hardhat-config-helper. The rest of the code is the same of the repo.

Of course I deployed on rinkeby, created a new subscription and added the new contract, same thing for the Keeper. But, even though the code is all the same the staging test fails by timeout and both the VRF and Keeper are never called. Litterally don't know what else can I do and I'm so stuck here in the course.
Any ideas of what am I missing? Thanks for your attention.

[PatrickAlphaC]

We should make an FAQ for keepers not kicking off

Keepers not kicking off guide

1. Double check the subscription ID in your contract
2. Double check the subscription is funded with enough LINK
3. Is checkUpkeep returning true?
4. Can you call performUpkeep yourself? (If you can't the keeper can't!)

Can you send me your contract address and keepers sub id?

[PatrickAlphaC]

Are your unit tests passing?

[KaladinStormBlessed16]

Yeah look

This is performUpkeep, do you see anything wrong there?

[PatrickAlphaC]

This means that likely one of your constructor parameters is off.

Could you check your constructor parameters?

[KaladinStormBlessed16]

It's the same code of the repo

[PatrickAlphaC]

In your hardhat-helper-config.js please.

[mubashirhussainkhadim]

i am dealing with same issue
Error: Timeout of 300000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/mubashirkhadim/Documents/codes/hardhat-lottery/lottery-smart-contract/test/staging/Lottery.staging.test.js)

[mubashirhussainkhadim]

in my case i add more funds in vrf subscription and problem is solved

[RijuChakraborty]

Hey, I am also facing this same problem. I would like to know if you have found a solution, if yes then can you please share it.

[harendra-shakya]

Maybe you are not using the promise correctly that's the reason you're getting timeout. Check it line by line. Or copy-paste code from repo to confirm that there is something wrong.

[harendra-shakya]

Maybe you are not using the promise correctly that's the reason you're getting timeout. Check it line by line. Or copy paste @PatrickAlphaC code from repo to confirm.

[RijuChakraborty]

Yeah I did found a mistake I made at mentioning the winner picked event under Promise. My sol file had the event name slightly different . Thanks for the help :)

[harendra-shakya]

You're welcome :)

[0xCardiE]

I had same problem of checkUpkeep not working properly. Seems that you need to have this at the end of checkUpkeep function

return (upkeepNeeded, "0x0"); // can we comment this out?

which is not said in video but it is added in repo. It does have a question mark in the repo but works with it. I would assume it is needed as there is no performData set anywhere so function needs to return it? Without this it didnt work for me.

[0xCardiE]

@PatrickAlphaC I found that upkeepNeeded function as shown in video is not working. Its not firing CL keepers.

So below doesnt work (which is seen in video)

  function checkUpkeep(
        bytes memory /*checkdata*/
    )
        public
        override
        returns (
            bool upkeepNeeded,
            bytes memory /* performData*/
        )
    {
        bool isOpen = (RaffleState.OPEN == s_raffleState);
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = (s_players.length > 0);
        bool hasBalance = address(this).balance > 0;
        upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
    }

These 2 work, first is without RETURN but we added VIEW into a function so when this is called it is read not write

 function checkUpkeep(
        bytes memory /*checkdata*/
    )
        public
        view
        override
        returns (
            bool upkeepNeeded,
            bytes memory /* performData*/
        )
    {
        bool isOpen = (RaffleState.OPEN == s_raffleState);
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = (s_players.length > 0);
        bool hasBalance = address(this).balance > 0;
        upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
    }

or return it with both params and it doesn't have to have VIEW. It will also fire keepers.

function checkUpkeep(
        bytes memory /*checkdata*/
    )
        public
        override
        returns (
            bool upkeepNeeded,
            bytes memory /* performData*/
        )
    {
        bool isOpen = (RaffleState.OPEN == s_raffleState);
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = (s_players.length > 0);
        bool hasBalance = address(this).balance > 0;
        upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
        return (upkeepNeeded, "0x0"); // can we comment this out?
    }

[ihasanreza]

@PatrickAlphaC I found that upkeepNeeded function as shown in video is not working. Its not firing CL keepers.

So below doesnt work (which is seen in video)

  function checkUpkeep(
        bytes memory /*checkdata*/
    )
        public
        override
        returns (
            bool upkeepNeeded,
            bytes memory /* performData*/
        )
    {
        bool isOpen = (RaffleState.OPEN == s_raffleState);
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = (s_players.length > 0);
        bool hasBalance = address(this).balance > 0;
        upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
    }

These 2 work, first is without RETURN but we added VIEW into a function so when this is called it is read not write

 function checkUpkeep(
        bytes memory /*checkdata*/
    )
        public
        view
        override
        returns (
            bool upkeepNeeded,
            bytes memory /* performData*/
        )
    {
        bool isOpen = (RaffleState.OPEN == s_raffleState);
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = (s_players.length > 0);
        bool hasBalance = address(this).balance > 0;
        upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
    }

or return it with both params and it doesn't have to have VIEW. It will also fire keepers.

function checkUpkeep(
        bytes memory /*checkdata*/
    )
        public
        override
        returns (
            bool upkeepNeeded,
            bytes memory /* performData*/
        )
    {
        bool isOpen = (RaffleState.OPEN == s_raffleState);
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = (s_players.length > 0);
        bool hasBalance = address(this).balance > 0;
        upkeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
        return (upkeepNeeded, "0x0"); // can we comment this out?
    }

Thanks a lot, this worked for me!