Lesson: 9 :- Error while running unit test

[RohitKS7]

ERROR

Error: VM Exception while processing transaction: reverted with custom error 'Lottery__UpKeepNotNeeded(100000000000000000, 1, 0)'

According to error I think the Lottery is still open while running this test don't no why?

Test CODE -

it("Can't Enter the Lottery when its in closed state", async () => {
                  await lottery.enterLottery({ value: lotteryEntranceFee })
                  await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                  await network.provider.send("evm_mine", [])
                  await lottery.performUpkeep([]) 
                  await expect(
                      lottery.enterLottery({ value: lotteryEntranceFee })
                  ).to.be.revertedWith("Lottery__NotOpen")
              })

My Solidity Code for this Test -

enterLottery

    function enterLottery() public payable {
        if (msg.value < i_entranceFee) {
            revert Lottery__SendMoreToEnterLottery();
        }
        // if lottery is not open for any reason
        if (s_lotteryState != LotteryState.OPEN) {
            revert Lottery__NotOpen();
        }

        s_players.push(payable(msg.sender));
        // Emit an event when we update a dynamic array or mapping
        emit LotteryEnter(msg.sender);
    }

checkUpkeep

function checkUpkeep(
        bytes memory /*checkData*/
    )
        public
        view
        override
        returns (
            bool upKeepNeeded,
            bytes memory /*performData*/
        )
    {
        bool isOpen = LotteryState.OPEN == s_lotteryState;
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = s_players.length > 0;
        bool hasBalance = address(this).balance > 0;
        bool upKeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
    }

performUpkeep

    function performUpkeep(
        bytes calldata /*performData*/
    ) external override {
        (bool upKeepNeeded, ) = checkUpkeep("");
        if (!upKeepNeeded) {
            revert Lottery__UpKeepNotNeeded(
                address(this).balance,
                s_players.length,
                uint256(s_lotteryState)
            );
        }
        s_lotteryState = LotteryState.CALCULATING;
        uint256 requestId = i_vrfCoordinator.requestRandomWords(
            i_gaslane,
            i_subscriptionId,
            REQUEST_CONFIRMATIONS,
            i_callbackGasLimit,
            NUM_WORDS
        );
        emit RequestedLotteryWinner(requestId);
    }

Any help will be appreciated

Thanks in Advance!!

[othaime-en]

From the revert error, I'm guessing the checkUpkeep() function returns false. Could you try rewriting these line

bool isOpen = LotteryState.OPEN == s_lotteryState;
bool hasPlayers = s_players.length > 0;

as I have below and see if anything changes.

bool isOpen = (LotteryState.OPEN == s_lotteryState);
bool hasPlayers = (s_players.length > 0);

[othaime-en]

Could you please push your code to github and leave a link here. I wanna look into it.

[RohitKS7]

Sure!

HERE
https://github.com/RohitKS7/hardhat-lottery-smartcontract

[othaime-en]

Hey @RohitKS7 i've made a few changes and made a pull request for you. Check it out. It should work just fine now.

[RohitKS7]

Hey Man! Great work. Thanks for your help.
But still @PatrickAlphaC didn't mentioned anything like that "add consumer manually" till 15:41:37.
SO, there's no way I can ever solve this!

[PatrickAlphaC]

Whoops 😅

Glad you got it!

[nebelmeerwanderer1]

Looks like it fails in the performUpkeep when it checks for (!upkeepNeeded).
from the error message it looks as if hasBalance, hasPlayers and isOpen all will be true.

which leaves the timePassed.

What is your interval set to? it is in the helper-hardhat-config.js and set via the 01-deploy-raffle.js

[RohitKS7]

As you can see it's 30!

 31337: {
        name: "localhost",
        entranceFee: ethers.utils.parseEther("0.1"), // 0.1 ETH
        // subscriptionId: "588",
        gaslane: "0x79d3d8832d904592c0bf9818b621522c988bb8b0c05cdc3b15aea1b6e8db0c15", // 30 gwei
        callbackGasLimit: "500000", // 500,000 gas
        interval: "30",
    },

and set via Deploy.js

    const entranceFee = networkConfig[chainId]["entranceFee"]
    const gaslane = networkConfig[chainId]["gaslane"]
    const callbackGasLimit = networkConfig[chainId]["callbackGasLimit"]
    const interval = networkConfig[chainId]["interval"]

    const arguments = [
        vrfCoordinatorV2Address,
        entranceFee,
        gaslane,
        subscriptionId,
        // networkConfig[chainId]["entranceFee"],
        callbackGasLimit,
        interval,
        // networkConfig[chainId]["gaslane"],
        // networkConfig[chainId]["callbackGasLimit"],
        // networkConfig[chainId]["interval"],
    ]

Right now I'm certain that it's bcoz of my LotteryState is still open don't know why?

This same error pops up in this test

it("returns false if lottery isn't open", async () => {
                  await lottery.enterLottery({ value: lotteryEntranceFee })
                  await network.provider.send("evm_increaseTime", [interval.toNumber() + 5])
                  await network.provider.send("evm_mine", [])
                  await lottery.performUpkeep([])
                  const lotteryState = lottery.getLotteryState()
                  const { upKeepNeeded } = await lottery.callStatic.checkUpkeep([])
                  assert.equal(lotteryState.toString(), "1")
                  assert.equal(upKeepNeeded, false)
              })

[adityabhattad2021]

Try increasing time period for a block

 await network.provider.send("evm_increaseTime", [interval.toNumber() + 5])

[RohitKS7]

Thanks for the reply bro But NO luck with this idea!

[adityabhattad2021]

Hey try debugging in raffle.sol itself.
You do it like this

import "hardhat/console.sol";

And then

function checkUpkeep(
        bytes memory /*checkData*/
    )
        public
        view
        override
        returns (
            bool upKeepNeeded,
            bytes memory /*performData*/
        )
    {
        bool isOpen = LotteryState.OPEN == s_lotteryState;
        bool timePassed = ((block.timestamp - s_lastTimeStamp) > i_interval);
        bool hasPlayers = s_players.length > 0;
        bool hasBalance = address(this).balance > 0;
        console.log(isOpen,timePassed,hasPlayers,hasBalance);
        bool upKeepNeeded = (isOpen && timePassed && hasPlayers && hasBalance);
    }

[adityabhattad2021]

And then correct the variables accordingly.

[RohitKS7]

appreciating your help bro! But I got the answer

[adityabhattad2021]

Happy coding :)

[nebelmeerwanderer1]

@RohitKS7

1. in Lottery.sol

delete the bool in row 106 :

bool upKeepNeeded = (timePassed && isOpen && hasPlayers && hasBalance);

2. in Lottery.test.js

add "await" in row 77:

const lotteryState = await lottery.getLotteryState()

[RohitKS7]

Thanks for you help Bro! Your answer works and I got a new error. Invalid consumer but don't worry now. @othaime-en answered it correctly!