getConversionRate(uint256 ethAmount) - no underscore?

[amanbthakkar]

At 4:15:59 in the video, there is no underscore for the function parameter. Is that just missing, or if a function is being internally called is an underscore not required?

[coinfeigm]

The underscores in the beginning of the tutorial is just used to differentiate the local variables to state variables (assuming you want them to be the same name), it does not matter how you name it.

The state variable declaration:
uint256 name;

The function declaration:

function store(uint256 _name) public { // The parameter can be named anything you want
        name = _name;
}

[amanbthakkar]

Ohh was that just for us to understand? I thought it was proper convention and started thinking too much lol. Thanks.

[PatrickAlphaC]

Well... a lot of large protocols still use the underscore convention for parameters, but there isn't really one convention that everyone has agreed on yet.

I used the conventions based on chainlink code... because I like that best.

So if you like it as a convention, use it!