lesson-9 Doubt while testing performUpkeep function

[Sairam002]

Hi guys, I'm currently at 15:45:11. I need some clarrification.
In this code

Here is the github link

it("reverts if upkeepNeeded is false", async function(){
            await expect(raffle.performUpkeep([])).to.be.revertedWith("upkeepNotTrue");
        })

Instead of testing it like this I tried testing it like this

it("reverts if upkeepNeeded is false", async function(){
            await raffle.enterRaffle({value:ethers.utils.parseEther("0.01")});
            await network.provider.send("evm_increaseTime", [interval.toNumber()-1]);
            await network.provider.send("evm_mine",[]);
            // const response = raffle.performUpkeep([]);
            await expect(raffle.performUpkeep([])).to.be.revertedWith("upkeepNotTrue");
        })

Notice that I changed theinterval.toNumber()+1 inside the evm_increaseTime to interval.toNumber()-1 to make it revert with the custom error

In the it("it can only run if checkUpkeep is true") @PatrickAlphaC mentioned that ** If the upkeepNeeded returned false performUpkeep will revert the transaction but when I tried testing with the code I modified it's not reverting.

Here is the photo of that

Can you please tell me what mistake I make??

[krakxn]

The code of Raffle.sol please

[krakxn]

Okay, sure thing.

[Sairam002]

Here is the link

[Sairam002]

Sorry for the delay
I'm new to github and didn't know how to push code to it...

[SatamSai]

try subtracting more time like 15sec ( i mean [interval.toNumber()-15] ) on line107 (as per above test screenshot) then it should work. It seems that you want checkupkeep to return false for not meeting the time interval but subtracting 1 doesn't works.

[krakxn]

The above is plausible, maybe reduce it even further (depending on your context accordingly).

[adityabhattad2021]

If it is not performUpkeep is not reverting try logging isOpen, timePassed, hasPlayers & hasBalance from raffle.sol itself with hardhat debugging like this
In raffle.js
add
import "hardhat/console.sol";
and then here add

 function checkUpkeep(
        bytes memory /*checkData*/
    )
        public
        view
        override
        returns (
            bool upkeepNeeded,
            bytes memory /*performData*/
        )
    {
        bool isOpen = false;
        bool timePassed = false;
        bool hasPlayers = false;
        bool hasBalance = false;
        if (s_raffleState == RaffleState.OPEN) {
            isOpen = true;
        }

        uint timeInterval = (block.timestamp - s_lastTimeStamp);
        if (timeInterval > i_interval) {
            timePassed = true;
        }

        if (s_playersArray.length > 0) {
            hasPlayers = true;
        }

        if (address(this).balance > 0) {
            hasBalance = true;
        }
        console.log(
        "isOpen: %s, timePassed: %s, hasPlayers:  %s,  hasBalance: %s ",
         isOpen,
         timePassed,
         hasPlayers,
         hasBalance
    );
        if (isOpen && timePassed && hasPlayers && hasBalance) {
            upkeepNeeded = true;
        }
    }

Check what is causing error and debug accordingly.

[Sairam002]

git init
When I run this I automatically got
Initialized empty Git repository in /home/amalesh/Raffle project/.git/
this is my file path

[Sairam002]

Finally I did it.
It's confusing to push code to github
Github link

Sorry for making delay

[RoboCrypter]

@Sairam002 No Problem!

[RoboCrypter]

@Sairam002
I have successfully debugged your code,
Your contract is totally fine.
It was a problem in your test that you were making while testing, reverts if upkeepNeeded is false.
In the test you just need to test it by:
await expect(raffle.performUpkeep([])).to.be.revertedWith("upKeepNotTrue");
If it not reverts it means something is wrong, But your test is passing pecfectly.

[adityabhattad2021]

Add Import statement at the top where you import other chainlink dependencies.