Lesson 17 DAOs: Typescript to JS

[jacobhay2626]

I have been trying to complete lesson 17 by converting the Typescript to Javascript and I have ran into an issue with the propose script:

const { network, ethers } = require("hardhat")
const fs = require("fs")
const {
    NEW_STORE_VALUE,
    FUNC,
    PROPOSAL_DESCRIPTION,
    developmentChains,
    VOTING_DELAY,
    proposalsFile,
    networkConfig,
} = require("../helper-hardhat-config")
const { moveBlocks } = require("../utils/moveBlocks")

async function propose(args, functionToCall, proposalDescription) {
    const governor = await ethers.getContract("GovernorContract")
    const box = await ethers.getContract("Box")
    const encodedFunctionCall = box.interface.encodeFunctionData(functionToCall, args)

    console.log(`Proposing ${functionToCall} on ${box.address} with ${args}`)
    console.log(`Proposal Description: ${proposalDescription}`)

    const proposeTx = await governor.propose(
        [box.address],
        [0],
        [encodedFunctionCall],
        proposalDescription
    )

    if (developmentChains.includes(network.name)) {
        await moveBlocks(VOTING_DELAY + 1)
    }

    const proposeTxReceipt = await proposeTx.wait(1)
    const proposalId = proposeTxReceipt.events[0].args.proposalId
    console.log(`Proposed with proposal ID: ${proposalId}`)

    const proposalState = await governor.state(proposalId)
    const proposalSnapShot = await governor.proposalSnapshot(proposalId)
    const proposalDeadline = await governor.proposalDeadline(proposalId)

    let proposals = JSON.parse(fs.readFileSync("proposals.json", "utf8"))
    const proposalsArray = proposals[network.config.chainId].push(proposalId.toString())
    const stringifyProposalArray = fs.writeFileSync("proposals.json", JSON.stringify(proposalArray))

    console.log(`Current Proposal State: ${proposalState}`)

    console.log(`Current Proposal Snapshot: ${proposalSnapShot}`)

    console.log(`Current Proposal Deadline: ${proposalDeadline}`)
}

propose([NEW_STORE_VALUE], FUNC, PROPOSAL_DESCRIPTION)
    .then(() => process.exit(0))
    .catch((error) => {
        console.error(error)
        process.exit(1)
    })

When running the script i am getting the error:

TypeError: Cannot read properties of undefined (reading 'push')

Which is referring to this section of the code:

    let proposals = JSON.parse(fs.readFileSync("proposals.json", "utf8"))
    const proposalsArray = proposals[network.config.chainId].push(proposalId.toString())
    const stringifyProposalArray = fs.writeFileSync("proposals.json", JSON.stringify(proposalArray))

My proposals.json file is:

{"31337": []}

And I am trying to add the proposal Ids to the array in the proposal.json file relative to the chain Id.
Any advice appreciated :)

[jacobhay2626]

In the end I wrote a test script for the whole thing and it was working fine

[Benrockiee]

@jacobhay2626 Bro im having issues as well, i rewrote the propose script into javascript but when i try doing anything like compiling, it gives me error Unexpected end of JSON input.. I had to copy this one here and paste it but same error still occurs..