Lesson14: Doubt

[adityabhattad2021]

In BasicNft.sol

    function mintNft() public returns (uint256) {
        _safeMint(msg.sender, s_tokenCounter);
        s_tokenCounter = s_tokenCounter + 1;
        return s_tokenCounter;
    }

1. Why is that we return s_tokenCounter when we have a getter function for it already, here

  function getTokenCounter() public view returns (uint256) {
        return s_tokenCounter;
    }

2. Now that as this mintNft() makes transection how can we get access to the s_tokenCounter; returned by it as
   when we try this

const transectionResponse = await basicNFT.mintNFT()
const transectionRecipt = await transectionResponse.wait(1)
console.log(transectionRecipt)

there is no s_tokenCounter

[alymurtazamemon]

@adityabhattad2021 There is no solid reason I am seeing to return a counter from the mint function. We just need a unique id for it that we can give and leave the return statement. At that time I also did not notice that and I created my test like this:

it("should mint an NFT and increment the token counter", async () => {
  const tx = await basicNft.mintNFT();
  await tx.wait(1);
  const tokenCounts = await basicNft.getTokenCounts();
  assert.equal(tokenCounts.toString(), "1");
});

[adityabhattad2021]

So should we mark this as answer or let more input come for this discussion?

[alymurtazamemon]

@adityabhattad2021 As you wish.

[adityabhattad2021]

Btw thanks for taking out your precious time to help.

[krakxn]

1. "Why is that we return s_tokenCounter when we have a getter function for it already, here"

_safeMint(msg.sender, s_tokenCounter);
s_tokenCounter = s_tokenCounter + 1;

Think of s_tokenCounter as an index. Let's assume the index is zero, so _safeMint mints with an index of zero and increments the index, and is now updated for the next execution, i.e. 1 and so on. So, to conveniently return the updated index rather than making conditionals—for the getter function—to check every time the index is updated.

2. "Now that as this mintNft() makes transection how can we get access to the s_tokenCounter; returned by it as when we try this"

This seems correct to me, check if there are any other execution/code problems.

[adityabhattad2021]

Thanks for taking out you time to help guys.

[adityabhattad2021]

should we mark this as answer or let more input come for this discussion?

[krakxn]

It's okay!

Uh.. up to you, if someone w/ a similar doubt will be satisfied—when they refer this—with these answers, then yes. Elsewise, no.

[adityabhattad2021]

Created an Issue in the code repository PatrickAlphaC/hardhat-nft-fcc#14 regarding the same.