Lesson 14: abi.encodePacked and bytes typecasting

[0xCardiE]

I wonder why do we typecast abi.encodePacked to bytes when abi.encodePacked is already returning bytes type?

    function tokenURI(uint256 tokenId) public view virtual override returns (string memory) {
    ...
        }
        return
            string(
                abi.encodePacked(
                    _baseURI(),
                    Base64.encode(
                        bytes(
                            abi.encodePacked(
                            ...

[aman-webdev]

abi.encodePacked returns bytes but it also saves space, like it would remove the unnecessary "0x000.." (example only)

[krakxn]

That is redundancy, and the typecasting should be omitted IMHO.

@alymurtazamemon Could you cross-check as well?

[alymurtazamemon]

@adriadrop Yes, we can remove this and directly use like this:

Base64.encode(
      abi.encodePacked(
          '{"name":"',
          name(), // You can add whatever name here
          '", "description":"An NFT that changes based on the Chainlink Feed", ',
          '"attributes": [{"trait_type": "coolness", "value": 100}], "image":"',
          imageURI,
          '"}'
      )
)

Also this:

string memory svgBase64Encoded = Base64.encode(
    bytes(string(abi.encodePacked(svg)))
);

to this:

string memory svgBase64Encoded = Base64.encode(abi.encodePacked(svg));

[0xCardiE]

Makes sense, I suspected there is no reason to convert to string and then back to bytes when already in bytes.