Lesson 6 Testing addPerson function [Uncovered lines(31,32) Challenge]

[oneyellowpeacock]

I was trying to test the addPerson function. I'm not sure how to pass an array. Can anyone please check the code and let me know where I'm being wrong?

Patrick asks us to do it by ourselves at 9:46:30

This is the test-deploy.js program

  it("Should add person when called and attach favourite number to person name", async function () {
        const expectedValue = ("Chad", 69)
        const transactionResponse = await simpleStorage.addPerson(expectedValue)
        await transactionResponse.wait(1)
        assert.equal(transactionResponse, expectedValue)
    })

This is the error I'm getting:

 1) SimpleStorage
       Should add person when called and attach favourite number to person name:
     Error: missing argument: passed to contract (count=1, expectedCount=2, code=MISSING_ARGUMENT, version=contracts/5.6.2)
      at Logger.makeError (node_modules/@ethersproject/logger/src.ts/index.ts:261:28)
      at Logger.throwError (node_modules/@ethersproject/logger/src.ts/index.ts:273:20)
      at Logger.checkArgumentCount (node_modules/@ethersproject/logger/src.ts/index.ts:332:18)
      at /home/anirbanweb3/Anirban/hh-fcc/hardhat-simple-storage-fcc/node_modules/@ethersproject/contracts/src.ts/index.ts:187:12
      at step (node_modules/@ethersproject/contracts/lib/index.js:48:23)
      at Object.next (node_modules/@ethersproject/contracts/lib/index.js:29:53)
      at /home/anirbanweb3/Anirban/hh-fcc/hardhat-simple-storage-fcc/node_modules/@ethersproject/contracts/lib/index.js:23:71
      at new Promise (<anonymous>)
      at __awaiter (node_modules/@ethersproject/contracts/lib/index.js:19:12)
      at populateTransaction (node_modules/@ethersproject/contracts/lib/index.js:152:12)



error Command failed with exit code 1.

I know my code is fundamentally wrong somewhere but since I'm new I can't seem to figure out. Any help would be awesome.Thanks :)

[iangechuki]

you should pass the values directly into addPerson function

     const transactionResponse = await simpleStorage.addPerson("Chad",69)

The way you did it is wrong because when the value are passed into function they will have a double brackets:

     const transactionResponse = await simpleStorage.addPerson(("Chad",69))

In your assert,It will give an error because transactionResponse is an object.You should console.log it.
Instead,try using retrieve function in your contract which gives you your favouriteNumber and then compare it to 69 because its what you passed as your favourite number.Also you can write a function that returns the people array .The first item in array will be the person you just added

[oneyellowpeacock]

Oh I got it! Thank you :) I think I don't even need the expectedValue. If I pass the values directly it should probably be a good check if the function is working.

[alymurtazamemon]

@oneyellowpeacock 1 issue that @IANGECHUKI176 mentioned above and 2 issues you are comparing with transactionResponse that is to equivalent. You need the get the added person from person array and then compare with that.

Here is my example of that test:

it("Should add a person with favorite number", async function () {
  const personName = "Ali Murtaza";
  const personFavoriteNumber = "40";
  const transactionResponse = await simpleStorage.addPerson(
    personName,
    personFavoriteNumber
  );
  await transactionResponse.wait(1);

  const person = await simpleStorage.people(0);
  assert.equal(person.name, personName);
  assert.equal(person.favoriteNumber.toString(), personFavoriteNumber);
});

[oneyellowpeacock]

This should work great! Thank you for the detailed code as well :) I see I was wrong in putting expectedValue as it was becoming two braces ((expectedValue)).

It's just better to pass all the constants and add it to transactionResponse and then check all the things in the array separately at the end.

[SidharthK2]

It should be noted here that "simpleStorage.people" returns a function, hence the need for "(0)" instead of "[0]".

[pacelliv]

Can you explain the difference between "(0)" and "[0]". I'm having a hard time understanding the last three lines.

[SidharthK2]

@pacelliv Sure, people("0") returns the 0th index of people array. You cannot call people[0] directly as you would inside solidity.

[ygorz]

@pacelliv Sure, people("0") returns the 0th index of people array. You cannot call people[0] directly as you would inside solidity.

This was all very helpful. Given that it's an array, I was using [ ] and going crazy as to why I couldn't access it. Now I know in this case to use ( ).

[SanderLoman]

Hey guys, I tried doing the addPerson mini challenge, and this is the code I wrote. I'm not sure if I did it right, although it did pass the test.

it("Should add a person and a number to the array", async function () {
    const expectedValue = "0"
    const currentValue = await simpleStorage.retrieve()
    await simpleStorage.addPerson(expectedValue, currentValue)
    assert.equal(currentValue.toString(), expectedValue)
})

--------------------|----------|----------|----------|----------|----------------|
File                |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
--------------------|----------|----------|----------|----------|----------------|
 contracts/         |      100 |      100 |      100 |      100 |                |
  SimpleStorage.sol |      100 |      100 |      100 |      100 |                |
--------------------|----------|----------|----------|----------|----------------|
All files           |      100 |      100 |      100 |      100 |                |
--------------------|----------|----------|----------|----------|----------------|

Could anyone please verify that this is a right way of doing it?

[alymurtazamemon]

@SanderLoman Your test is "Should add a person and a number to the array", but you are not doing it, so does it test the code?

[SanderLoman]

Well, I don't know if it is testing the addPerson() function correctly. All I know right now is that it passed the test, but it could be testing the wrong thing.

[alymurtazamemon]

@SanderLoman Test will also pass, if you do this:

it("Should add person when called and attach favourite number to person name", async function () {
    assert(true);
})

But our purpose is to test contract code not pass tests that do not actually test the contract correctly.

[SanderLoman]

Ahh ok, I get it now. So long story short, I only wrote the code so it would pass the test but wouldn't actually test the contract code.

Anyways, thank you for your time and help @alymurtazamemon, appreciate it ;)

[JuniorSua]

This is what I wrote maybe It will help with the console.log.... so you can see whats inside and how to show you.

'''
it("Should add a person with favorite number", async function () {
const expectedName = "Bill"
const expectedfavoriteNumber = "16"
const transactionResponse = await simpleStorage.addPerson(
${expectedName},
expectedfavoriteNumber
)
await transactionResponse.wait(1)
const currentResult = await simpleStorage.people(0)
console.log(This is the current result: ${currentResult})
assert.equal(currentResult.name, expectedName)
assert.equal(
currentResult.favoriteNumber.toString(),
expectedfavoriteNumber
)
console.log(
${ currentResult.name } was added with his/her favorite number ${currentResult.favoriteNumber.toString()} successfully
)
})
'''

[JuniorSua]

for some reason my code does not look nice when I put the 3 hashes.... did I do something wrong ?