Issue with writing test for hardhat-simplestorage

[deeptshukla]

Hey guys, I am facing an issue while writing test for SimpleStorage.sol.

const { assert } = require("chai")
const { ethers } = require("hardhat")

describe("SimpleStorage", function (params) {
    let simpleStorageFactory
    let simpleStorage
    beforeEach(async function () {
        simpleStorageFactory = await ethers.getContractFactory("SimpleStorage")
        simpleStorage = await simpleStorageFactory.deploy()
    })
    it("Person should be added when calling addPerson", async function () {
        const expectedPersonName = "deept"
        const expectedFavoriteNumber = "12"
        const transactionResponse = await simpleStorage.addPerson(
            expectedPersonName,
            expectedFavoriteNumber
        )
        await transactionResponse.wait(1)
        const { favoriteNumber, name } = await simpleStorage.people(0)
        assert.equal(name, expectedPersonName)
        assert.equal(favoriteNumber, expectedFavoriteNumber)
        const lengthOfPeople = await simpleStorage.people.length
        console.log(lengthOfPeople)
        assert.equal(lengthOfPeople, 1)
    })
})

When runnning yarn hardhat test, the test is failing as I am getting length as 0.
Can someone help on why I am getting this?
For recreating the issue,

git clone https://github.com/PatrickAlphaC/hardhat-simple-storage-fcc
cd hardhat-simple-storage-fcc

Update the test file with the content provided above

[krakxn]

Make a repo, I will look into it

[deeptshukla]

Hey @krakxn , you can clone it here.

git@github.com:deeptshukla/harhat-simple-storage.git

Thanks for the quick reply.

[krakxn]

@deeptshukla Got it. Made two PRs, merge them and then git pull the changes, it should be fixed now. Also, I added an extra way to test your deploy module. Uncomment them as necessary. Cheers

[technophile-04]

Hii, The length of a public array is not exposed by default in solidity. You can add a function in your contract which returns the length of people array

function getNumberOfpeoples() public view returns(uint256){
   return people.length
}

[technophile-04]

created a pull request

[deeptshukla]

Thanks for the quick response @krakxn and @technophile-04.
Thanks for the additional comments for improving the code even further @krakxn .

[krakxn]

All the best!