Lesson 9: Testing: AssertionError: expected '1' to equal '30'

[zulfi984]

intitiallizes the raffle correctly:

      AssertionError: expected '1' to equal '30'
      + expected - actual

      -1
      +30
      
      at Context.<anonymous> (test/unit/Raffle.test.js:29:26)

I checked helper-hardhat-config.js and deploy-raffle.js
the given keepersUpdateInterval is 30
but when i give interval = await raffle.getInterval() it returns 1

Raffle-test.js

const { assert, expect } = require("chai")
const { network, deployments, ethers } = require("hardhat")
const { developmentChains, networkConfig } = require("../../helper-hardhat-config")

!network.config.chainId == 31337
    ? describe.skip
    : describe("Raffle Unit test", function () {
          let player, vrfCoordinatorV2Mock, raffle, raffleContract, raffleEntranceFee, interval
          beforeEach(async () => {
              accounts = await ethers.getSigners()
              player = accounts[1] //   accounts[1] is deployer
              await deployments.fixture(["mocks", "raffle"])
              vrfCoordinatorV2Mock = await ethers.getContract("VRFCoordinatorV2Mock")
              raffleContract = await ethers.getContract("Raffle")
              raffle = await raffleContract.connect(player)
              raffleEntranceFee = await raffle.getEntranceFee()
              interval = await raffle.getInterval()
          })

          describe("constructor", function () {
              it("intitiallizes the raffle correctly", async () => {
                 const raffleState = (await raffle.getRaffleState()).toString()
                console.log(interval.toString())
                  assert.equal(raffleState, "0")

                  assert.equal(
                      interval.toString(),
                      networkConfig[network.config.chainId]["keepersUpdateInterval"]
                  )
              })
          })

[krakxn]

Make a repo -- I will look into it

[zulfi984]

yes, this is fixed . But how? we should not declare it on const variable?

@zulfi984 Merge the PR and then git pull. Let me know if this fixes it!

but, other all tests shows error. i pushed now in git

[adityabhattad2021]

Tests will show error because you are connected to the wrong account(not deployer), try the solution I posted.

[krakxn]

yes, this is fixed . But how? we should not declare it on const variable?

@zulfi984 The problem was the order of arguments did not match with the constructor in the main contract, hence it assigned mismatched values.

BTW, if the actual error is fixed you should close this one, make a new one if there are logical errors as it would not be relevant here.

[zulfi984]

yes, this is fixed . But how? we should not declare it on const variable?

@zulfi984 The problem was the order of arguments did not match with the constructor in the main contract, hence it assigned mismatched values.

BTW, if the actual error is fixed you should close this one, make a new one if there are logical errors as it would not be relevant here.

Ohh., Thank you so much.

[krakxn]

No problem, all the best!

(If you made a new discussion regarding the logical errors, reply w/ the link and I will look into it.)

[adityabhattad2021]

Remove this lines

accounts = await ethers.getSigners()
player = accounts[1] //   accounts[1] is deployer
raffle = await raffleContract.connect(player)

as the contract is already connected to the deployer.
and change this line

raffleContract = await ethers.getContract("Raffle")

to

raffleContract = await ethers.getContract("Raffle",deployer)

You can get deployer by importing getNamedAccounts from hardhat
and adding this line in before each

deployer = (await getNamedAccounts()).deployer;

And then your code should work fine.

[zulfi984]

The contract is already connected to the deployer, the only test where you need to connect player is the test where you check if the raffle picks the random winner. For all the other tests you don't need to connect any account other than the deployer which is already connected. Hope it Helps.

oh..? but, its done by this way in patrick's github repository

[adityabhattad2021]

Check out my lottery repository.

[zulfi984]

Check out my lottery repository.

Yes, i checked and changed. But, it shows the same failed test results that i got before.

[zulfi984]

reverted with custom error 'InvalidConsumer()'
This error because of latest version and that I'm currently on @chainlink/contracts@0.4.2
downgrading to 0.4.1 using the following command eliminates this issue:
npm i @chainlink/contracts@0.4.1

[zulfi984]

Check out my lottery repository.

by the way thank you for the help buddy