Lesson 7 problems with deploying on testnet

[pietrociarmatori]

Hi everyone, I can't get around this issue:
When I try the deploy on the rinkeby testnet I get this message from the terminal.

NomicLabsHardhatPluginError: The constructor for contracts/FundMe.sol:FundMe has 1 parameters
but 0 arguments were provided instead.

This is my code, I'm going to upload "FundMe.sol" and "01-deploy-fund-me.js" since I think these two bad boys are involved.

FundMe.sol:

 // SPDX-License-Identifier:MIT

pragma solidity ^0.8.0;

import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol";
import "./PriceConverter.sol";

error NotOwner();

contract FundMe {
    using PriceConverter for uint256;

    address public immutable i_owner;
    uint256 public constant MINIMUM_USD = 50 * 10**18;

    address[] public funders;
    mapping(address => uint256) public addressToAmountFunded;

    AggregatorV3Interface public priceFeed;

    constructor(address priceFeedAddress) {
        i_owner = msg.sender;
        priceFeed = AggregatorV3Interface(priceFeedAddress);
    }

    modifier onlyOwner() {
        if (msg.sender != i_owner) revert NotOwner();
        _;
    }

    function fund() public payable {
        require(
            msg.value.getConversionRate(priceFeed) >= MINIMUM_USD,
            "Please, forward more funds"
        );
        funders.push(address(msg.sender));
        addressToAmountFunded[msg.sender] += msg.value;
    }

    function wthdraw() public payable onlyOwner {
        for (
            uint256 funderIndex = 0;
            funderIndex < funders.length;
            funderIndex++
        ) {
            address funder = funders[funderIndex];
            addressToAmountFunded[funder] = 0;
        }
        funders = new address[](0);
        (bool callSuccess, ) = payable(msg.sender).call{
            value: address(this).balance
        }("");
        require(callSuccess, "Call failed!");
    }

    fallback() external payable {
        fund();
    }

    receive() external payable {
        fund();
    }
}

01-deploy-fund-me.js:

const {
    networkConfig,
    developmentChains,
} = require("../helper-hardhat-config");
const { network } = require("hardhat");
const { verify } = require("../utils/verify");

module.exports = async ({ getNamedAccounts, deployments }) => {
    const { deploy, log } = deployments;
    const { deployer } = await getNamedAccounts();
    const chainId = network.config.chainId;

    let ethUsdPriceFeedAddress;

    if (developmentChains.includes(network.name)) {
        const ethUsdAggregator = await deployments.get("MockV3Aggregator");
        ethUsdPriceFeedAddress = ethUsdAggregator.address;
    } else {
        ethUsdPriceFeedAddress = networkConfig[chainId]["ethUsdPriceFeed"];
    }
    log(
        "-------------------------------------------------------------------------"
    );
    log("Deploying FundMe and waiting for blocks confirmation...");

    //const args = [ethUsdPriceFeedAddress];
    const fundMe = await deploy("FundMe", {
        from: deployer,
        args: [ethUsdPriceFeedAddress],
        log: true,
        waitConfirmations: network.config.blockConfirmations || 1,
    });
    log(`FundMe address: ${fundMe.address}`);

    if (
        !developmentChains.includes(network.name) &&
        process.env.ETHERSCAN_API_KEY
    ) {
        await verify(fundMe.address, ethUsdPriceFeedAddress);
    }

    log(
        "----------------------------------------------------------------------------"
    );
};

module.exports.tags = ["all", "fundme"];

Thankyou in advance for your time, have a great day y'all :)

[linuxsirn]

make sure ethUsdPriceFeedAddress is not undifinded when you deploy on rinkeby

[alymurtazamemon]

@pietrociarmatori Push to GitHub and leave a link here.

[alymurtazamemon]

@pietrociarmatori Can you console.log the ethUsdPriceFeedAddress before deploy and see the result.

[krakxn]

Make a repo and reply with the link.

[hobbescodes]

@pietrociarmatori as @linuxsirn mentioned, you need to make sure that ethUsdPriceFeedAddress is not undefined when you deploy on rinkeby (should be defined in your networkConfig object). Also, you are missing a few things in your require statement for hardhat that is needed to access getNamedAccounts and deployments:

const { getNamedAccounts, deployments, network } = require("hardhat")

[hobbescodes]

Can you send your networkConfig from that file? Seemingly that is where the issue lies because the error is saying that nothing is being passed in for ethUsdPriceFeedAddress.

[mmuaaz]

const networkConfig = { 4: { name: "rinkeby", ethUsdPriceFeed: "0x8A753747A1Fa494EC906cE90E9f37563A8AF630e", }, 137: { name: "polygon", ethUsdPriceFeed: "0xF9680D99D6C9589e2a93a78A04A279e509205945", }, } const developmentChains = ["hardhat", "localhost"] const DECIMALS = 8 const INITIAL_ANSWER = 200000000000 module.exports = { networkConfig, developmentChains, DECIMALS, INITIAL_ANSWER, }

My setup is working fine without any errors on rinkeby or hardhat network:
can you point out any errors?? Also I have 1 question I think I lost in when we parameterize "constructor" function with a variable "priceFeedAddress" and priceFeed = AggregatorV3Interface(priceFeedAddress). I just couldnt find where we passed "priceFeedAddress", where it is coming from? as network config uses a different variable "ethUsdPriceFeed" while the deploy script is using yet another variable "ethUsdPriceFeedAddress"

[othaime-en]

Hello @mmuaaz The constructor function at FundMe.sol takes one argument and that is priceFeedAddress. It is basically the address on the blockchain where the AggregatorV3Interface is stored. In your networkConfig you used ethUsdPriceFeed to represent priceFeedAddress but it basically the same as ethUsdPriceFeedAddress. Just different variable names representing the same address.
In our deploy script, we take this address (hardcoded as ethUsdPriceFeed in networkConfig) and assigns it the variable ethUsdPriceFeedAddress. Remember that our constructor function at FundMe.sol needs this address as an argument. So we pass this argument in our deploy() function.

const args = [ethUsdPriceFeedAddress]
const fundMe = await deploy("FundMe", {
        from: deployer,
        args: args, // put priceFeedAddress here. Could also be args: [ethUsdPriceFeedAddress]
        log: true,
        waitConfirmations: network.config.blockConfirmation || 1, 
    })

I hope this improves your understanding.

[mmuaaz]

yeah this makes a little improvements in my understanding, So I think you mean to say that in FundMe.sol where constructor(address priceFeedAddress) is defined, it gets passed the price feed address and the contract that is sitting there, from where PriceConverter.sol is getting the latestRoundData

[othaime-en]

Exactly! So the ethUsdPriceFeedAddress we pass in the arguments in our deploy script is passed into the constructor at FundMe.sol which in turn passes this address to the getConversionRate() function in PriceConverter.sol which gets the latestRoundData i.e. the latest eth/usd price.

[othaime-en]

I ran into the same error. The problem is probably in the verify.js file. I fixed mine by changing constructorArg to constructorArguments in my verify() function. Because it seems that the function wasn't passing the ethUsdPriceFeedAddress argument to the constructor at FundMe.sol

await run("verify:verify", {
        address: contractAddress,
        constructorArguments: args, // changed constructorArgs to constructorArguments
    })

Try and see if it might work. Notify us if it ends up working.

[mmuaaz]

boy boy boy it works, you dont know what you have done, I had been banging my head in the FundMe.sol constructor function, why it is not getting what I am giving it and it took me 2 days, thank God I came across this answer

[othaime-en]

Glad I could help 👍

[ashrth]

As for me the problem was with verify.js

Instead of constructorArgument write constructorArguments and it should work fine.

try {
        await run("verify:verify", {
            address: contractAddress,
            constructorArguments: args,
        })