Code coverage report not correct

[mghildiy]

So I installed solidity-coverage plugin, and run test coverage command. What I get is quite different from what we see in tutorial, and result is clearly wrong.

For eg, .line 22 and 26 are in store and retrieve functions, which are invoked in tests(shown below), and report show these lines as uncovered.

it("should start with a favourite number of 0", async function () {
    const currentNumber = await simpleStorage.retrieve();

    assert.equal(currentNumber.toString(), "0");
  });

  it("should correctly update when we call store", async function () {
    const expected = "4";

    const transactionResponse = await simpleStorage.store(expected);
    // not really needed here
    await transactionResponse.wait(1);

    assert.equal((await simpleStorage.retrieve()).toString(), expected);
  });

Any idea why this is so?

[krakxn]

Could you link the repo involved? Makes it easier for me to debug

[mghildiy]

Here it is:

https://github.com/mghildiy/blockchain-learning/blob/master/test/test-deploy.js

[krakxn]

What command are you inputting in the terminal along with the network? (by default, Coverage launches its own in-process ganache server)

[mghildiy]

yarn hardhat coverage

[krakxn]

@alymurtazamemon Do you know why this is so?

By the way, @mghildiy I made a PR which does not really fix anything but makes the code cleaner as it is a concept (abbreviation: DRY) - merge the PR and pull the changes via git pull to your local repo.

[alymurtazamemon]

@krakxn going to check it.

[alymurtazamemon]

@mghildiy going to do a pull request fix some things, and also change the RPC URL name I have changes so check the name again.

[mghildiy]

I don't see any change in my output.

Edit: Cleaned the project, and now it works.

But what change actually made it work? I am not sure why it works now but not earlier. Only change I see is RINKEBY_RPC_URL replaced by RPC_URL in hardhat-config.js. Is this the change which made it work? If yes, very strange.

[alymurtazamemon]

@mghildiy See the file changes in a pull request, I do not remember changes because I have changed multiple projects in 2 days.