Why it is recommended to update the s_tokenCounter before calling _safeMint(address, uint256) function?

[sadityakumar9211]

So, I was learning through the tutorial, and at 23:24:16, @PatrickAlphaC says that it is recommended to increment the s_tokenCounter before we call the function _safeMint(address, uint256).
Why is it recommended? Also, by incrementing it before calling the _safeMint(address, uint256) wouldn't be there inconsistency in the tokenIds passed to _safeMint(address, uint256) and s_tokenIdToHighValue[s_tokenCounter]. They both will have different tokenCounter values for the same minting transaction.

Is there something under the hood happening, like updating the storage variables takes time as we're writing to the blockchain? If yes, then please, can someone elaborate?

Edit

I also wanted to add I check in @openzepplien/contracts docs, and it increments the counter after the call to function _safeMint(address, uint256).

https://docs.openzeppelin.com/contracts/4.x/erc721#constructing_an_erc721_token_contract

Edit

The GitHub repos associated with my doubt is is:
https://github.com/sadityakumar9211/hardhat-three-ways-nft/blob/main/contracts/DynamicSvgNft.sol

[krakxn]

Can you reply with the entire code relevant to your question? Or, a link to the file if you have a repo works too. Thanks

[sadityakumar9211]

https://github.com/sadityakumar9211/hardhat-three-ways-nft/blob/main/contracts/DynamicSvgNft.sol
This is the GitHub Repo. My doubt is associated with the mintNft function.

[krakxn]

Think of s_tokenCounter as a Token ID to that NFT. Or like a number tag which identifies the NFT's order precedence; which keeps track of every minted NFT (that is why we increment it).

s_tokenIdToHighValue[s_tokenCounter] = highValue; basically is: Token ID -> High Value
emit CreatedNFT(s_tokenCounter, highValue); keeps track by storing it like an ID

And since arrays and hash maps (mappings) start with an index of zero, our token counter is initialized with a zero value, and then incremented for each NFT. So: NFT A will have an index of 0, NFT B index 1, and so on. Hence, keeping track

Hope this answers your query

[sadityakumar9211]

No, this wasn't my confusion.
I checked the GitHub repo associated with the tutorial. I think @PatrickAlphaC meant that emitting the event is recommended before we actually mint the token by calling _safeMint() function. I think he incorrectly pointed in the video at [23:24:16](https://youtu.be/gyMwXuJrbJQ?t=83657) about incrementing the _tokenCounterbefore calling the_safeMint()` function.

Anyways my doubt is clear, I guess.
Really appreciate your help!

[krakxn]

No problem! BTW - can you be concise with the doubt? Confusing whether it is about the counter, the event or something else. I explained the first two above though.

[sadityakumar9211]

I checked the GitHub repo associated with the tutorial. I think @PatrickAlphaC meant that emitting the event CreatedNFT is recommended before we actually minting the token by calling _safeMint() function. I think he incorrectly pointed in the video at 23:24:16 about incrementing the _tokenCounter before calling the_safeMint()` function.