Lesson 9: ISSUES with unit testing (time limit exceeded + recent winner undefined)

[AlexK020908]

There are a few issues with my unit test/code
if I ran the test with promise following the video at mark 16:03:00 , I get a timeout exceeded error like so
Error: Timeout of 200000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/alexk47/folder/hardhatCamp/hardhat-smart-raffle/test/unit.test.js)

The test look like this:

              it("picks a winner, resets the lott, and send money", async function () {
                  //we need more entrants
                  const additionalEntrants = 3
                  const startingAccountIndex = 1 //deployer = 0;
                  const accounts = await ethers.getSigners()
                  for (
                      let i = startingAccountIndex;
                      i < startingAccountIndex + additionalEntrants;
                      i++
                  ) {
                      //connect raffle contracts to these accounts
                      const accountConnectedRaffle = raffle.connect(accounts[i])
                      accountConnectedRaffle.enterRaffle({ value: entranceFee })
                  }

                  //now we have four ppl connected

                  const startingtimeStamp = await raffle.getLatestTimeStamp()
                  //we want to perform upkeep --> MOCK chainlink
                  //requesting random words will kick of calling fulffil random words(mock the VRF)
                  //we have to wait for fulfillrandom words to be called --> we need to simulate waiting for it since local host isnt the same
                  //as the VRF
                  //using promises

                  //we set up the event listeners first
                  await new Promise(async (resolve, reject) => {
                      //once winner picked, we want to do something
                      raffle.once("winnerpicked", async () => {
                          console.log("found the event")
                          try {
                              const recentwinner = await raffle.getRecentWinner()
                              const raffleState = await raffle.getrafflestate()
                              const endingTimeStamp = await raffle.getLatestTimeStamp()
                              const numplayers = await raffle.getNumberOfPlayers()
                              assert.equal(numplayers.toString, "0")
                              assert.equal(raffleState, 0)
                              assert.equal(endingTimeStamp > startingtimeStamp)
                              console.log(`recent winner ${recentwinner.address}`)
                              console.log(accounts[0].address)
                              console.log(accounts[1].address)
                              console.log(accounts[2].address)
                              console.log(accounts[3].address)
                          } catch (error) {
                              reject(e)
                          }
                          resolve()
                      })

                      //then we add the code inside the promise but outside the once
                      //so that the code we run here may trigger fullfill random words
                      //then emit the event winner picked.
                      const tx = await raffle.performUpkeep("0x")
                      const txReceipt = await tx.wait(1)
                      await VRFCoordinatorV2Mock.fulfillRandomWords(
                          txReceipt.events[1].args.requestId,
                          raffle.address
                      )
                  })
              })

I also included a before each before this "it" :

             beforeEach(async function () {
                  await raffle.enterRaffle({ value: entranceFee })
                  await network.provider.send("evm_increaseTime", [interval.toNumber() + 1])
                  await network.provider.request({ method: "evm_mine", params: [] })
              })

when I delete everything in the try block , only leaving recent winner : I get the following test result

found the event
recent winner undefined
0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
0x70997970C51812dc3A010C7d01b50e0d17dc79C8
0x3C44CdDdB6a900fa2b585dd299e03d12FA4293BC
0x90F79bf6EB2c4f870365E785982E1f101E93b906

It seems that my fullfillrandomwords function is not setting the winner properly, so I went ahead and checked the function, but it indeed sets the winner properly, so I am not sure what the issue is:

function fulfillRandomWords(
        uint256, /*requestId*/
        uint256[] memory randomWords
    ) internal override {
        //since we only requesting one randomness, randomwords will come back as size 1
        //we can use modular operator
        //if s_players is of size 10
        //and we have random number == 202
        // we can 202 % 10   == 2 --> 2th winner
        uint256 indexOfWinner = randomWords[0] % s_players.length;
        address payable winner = s_players[indexOfWinner];
        s_recentWinner = winner;
        s_lastTimeStamp = block.timestamp;
        s_players = new address payable[](0);
        (bool success, ) = winner.call{value: address(this).balance}("");
        if (!success) {
            revert Raffle_transferFailed();
        }

        emit winnerpicked(winner);
        s_raffleState = RaffleState.OPEN;
    }

I am really confused, any help is appreciated !

[krakxn]

Do you have this in your hardhat.config.js file?

mocha: {
        timeout: 500000, // 500 seconds max for running tests
    },

[AlexK020908]

do you know why the winner returned back is undefined?

[krakxn]

Copy the above and let me know if it solves the actual error; also, it is undefined because of a logical error at raffle.getRecentWinner(), it is not a critical error as the timeout one. Check if getRecentWinner is fine for that one

[ArkX69]

Did you guys find the solution to it?

[alfaqi]

do you know why the winner returned back is undefined?

change this console.log(recent winner ${recentwinner.address})
to this console.log(recent winner ${recentwinner})
because getRecentWinner() returns address.

[alfaqi]

yes I have this, but my timeout is 20000, should I increase it?

You don't have to increase it, but
change this raffle.once("winnerpicked", async () => {
to this raffle.once("WinnerPicked", async () => {
or make sure the events are same capitalized